From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07DA9C001E0 for ; Sat, 21 Oct 2023 10:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K/zpd2nM8bDysRTjti2BmbMldldRjaXimKthW6S+844=; b=lJD2ash/2K5TVX Pk1QyrBGbFubhH6grkhRX9hXNC15VLKoXsitlhoUcA/2y2fmIpeEl9x/F1lE5RHGMyK6vr0hEJ68f yUTqCoRQveoPU51t4BDDciDo4tp3IyQhc2/KC3/1h5z3EuqWc6ogzEwB8ca8Y3zRilPvSQTMKiFIM uHv1P+HvT77RBXTmnxsjytFrQBlHmij8XS6y5emKgd+0q1Q+XJ9/ZAmfSTvgBFpg/4zwbky1qGmfu EM3EWaTVvD9K+8363WrMaKLm40X0HMdl0OP/8sOnT6zgCw73fMAPtUEYv6JcepXhKTtIvQ755GtUu xkJJBRl2LKccvBkNstLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qu8lZ-003kOA-1m; Sat, 21 Oct 2023 09:59:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qu8lT-003kMg-2Z; Sat, 21 Oct 2023 09:59:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0AD8660EF2; Sat, 21 Oct 2023 09:59:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51A86C433C7; Sat, 21 Oct 2023 09:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697882359; bh=wWc6rIlaxv84go1O69XljTR9y8Dp7PH3NzWmbHaSc28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EyS5G5XkJVgDPijceBEcmuOW9Sp+1+fiLlgDB1vQS9JkQgcKivVlPzjfDiuZh94RB nFuhDLcATWm3Wat5vFPa44mmBENjYPgvwFQWwlTWlq4cUh/VyjqhdfVR5KAipi05Yy 4aT7+lEe+JHixyU7kfHENZrQn5MCl+nNxGoWfGPs= Date: Sat, 21 Oct 2023 11:59:17 +0200 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Dave Stevenson , Dan Carpenter , Kieran Bingham , Laurent Pinchart Subject: Re: [PATCH v1 1/4] staging: vc04: Convert vchiq_log_error() to use dynamic debug Message-ID: <2023102128-bacteria-improper-66f5@gregkh> References: <20231019082147.384723-1-umang.jain@ideasonboard.com> <20231019082147.384723-2-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231019082147.384723-2-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231021_025927_883286_7699106F X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 19, 2023 at 01:51:44PM +0530, Umang Jain wrote: > Move vchiq_log_error() custom logging wrapper based on printk, > to use dynamic debug. To categorise, enum vchiq_log_category > has been introduced, which will become the part of the error > string format that will be logged to dynamic debug (for grep). > > All the vchiq_log_error() calls are adjusted to use the > dynamic debug wrapper. vchiq_loud_error_*() has been removed > as a part of this patch and replaced with dev_err (so that > they directly end up in kernel log, even if dynamic debug > isn't enabled), which serves the purpose. > > For cases where struct device pointer `dev` is not available, > NULL can be passed to vchiq_log_error() to log to dynamic debug > using pr_debug(). Ick, no, no need for that. Please don't have yet-another-logging-macro for this subsystem, use the "real" ones, in the code, so that we don't have to context-switch every time we come across one of these calls. So use dev_*() for real, where all of these have device pointers. And where they do not, use pr_*() so it stands out in bad ways so that those places can then be fixed up to use the proper logging macros as well (i.e. pass the device pointer into those functions in later patches.) Same for the other patches in this series, let's make this simpler, not more complex please. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel