From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02EA3C25B42 for ; Mon, 23 Oct 2023 22:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=baTGmei0oYoj6n7KrhE+ed/zyzBp40eqFLs37u1sqw8=; b=1yHpFGLVgtdomD S+yg9y0XEwTU0onQqAiS/v+rL763MASe0ulT9ZRpWiz+xzkqxQtEyh6Gp3AQYCF1nyaQIetp8tU5h HlN7ABiLV4Gu7GG8NpQvvWiwCcxfDxH8jQhlJu0te/Yd+8Rc3WgxET6B245TmZee35NkzLg8xjX/7 VzI2THwB4/VeuiTJnn+KZOxZsD+Hc4bRq/42iJKjNW/8f3RyPVQlGP48AKFzXqNgItu8GfaYlQ2Kb 278jdL6lcbBpZTtOBjFko0KtBGUgHIiBJdDCfGWE8pml+RM9aYuuFH5ytzRyDYhznMNx4OqNOr5TX cAQNcvuymdRbP8WlIt2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qv3cm-008NsU-39; Mon, 23 Oct 2023 22:42:16 +0000 Received: from mail-oo1-f49.google.com ([209.85.161.49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qv3cj-008NqW-0v; Mon, 23 Oct 2023 22:42:14 +0000 Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5841ab53bb4so1932688eaf.2; Mon, 23 Oct 2023 15:42:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698100927; x=1698705727; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OQtZrDjxMO0cn6Z1v3NtG+S2tU9MQ3gDl1rlW3lNWy0=; b=l5mVXb7yfM1u/gag1n/TVzF29AFnLCvVFv8mKPP9hidP1iJ9M2CtojQpnimIJlwu23 lpAJIU0HE2T885Arjluf9YiazKnTT+lCkf0MwJcWJcjwUotQqE1ZOeNrO99g423wz55e zAR0AHZIMpm7MIkrcobAuFkDJyTzkkfmngKieXOzVXGNaLTMcyu2IafLiW8mQ/OocQVL 6i/PDxzQZsPJ61INUz8MkviP0tuvqWMUEgjygdy7oCzrKZEFGO8fSINfWE9gR6LbdTIc WEUVGfhw02wMEIAyYziWIk1vFm/46SdYovwj64eXnC4iiqS5zOe+z03oodCGQ0GsKTDi J6+Q== X-Gm-Message-State: AOJu0Yy56EGfhT0bpxAXm6V6wdogSTlwc+rYpV5Wxa5476NCLbVZ3Klp Z7qR4/4Yhrj2oBCppS/I6A== X-Google-Smtp-Source: AGHT+IEx9L2hGghv2/kE/n011his5PMYgI+6kmyvJkZKOk/GWfuvIwxtr8nh8WcfcPdwpBQQHnFGOQ== X-Received: by 2002:a4a:d032:0:b0:57b:7e41:9f11 with SMTP id w18-20020a4ad032000000b0057b7e419f11mr9924525oor.2.1698100927290; Mon, 23 Oct 2023 15:42:07 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id w13-20020a4adecd000000b0057b95dc4c44sm1696534oou.48.2023.10.23.15.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 15:42:06 -0700 (PDT) Received: (nullmailer pid 1724522 invoked by uid 1000); Mon, 23 Oct 2023 22:42:05 -0000 Date: Mon, 23 Oct 2023 17:42:05 -0500 From: Rob Herring To: Sebastian Reichel Cc: Conor Dooley , Heiko Stuebner , Greg Kroah-Hartman , Thinh Nguyen , Krzysztof Kozlowski , Conor Dooley , linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v4 1/3] dt-bindings: usb: add rk3588 compatible to rockchip,dwc3 Message-ID: <20231023224205.GA1163435-robh@kernel.org> References: <20231020150022.48725-1-sebastian.reichel@collabora.com> <20231020150022.48725-2-sebastian.reichel@collabora.com> <20231020-shudder-tackle-cc98a82f1cd0@spud> <20231020160329.uqgjjr6ubfrcqjkj@mercury.elektranox.org> <20231022214219.GA706888-robh@kernel.org> <20231023001803.7fylnbv74zp2ynx7@mercury.elektranox.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231023001803.7fylnbv74zp2ynx7@mercury.elektranox.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231023_154213_320618_77B8812E X-CRM114-Status: GOOD ( 21.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 23, 2023 at 02:18:03AM +0200, Sebastian Reichel wrote: > Hi Rob, > > On Sun, Oct 22, 2023 at 04:42:19PM -0500, Rob Herring wrote: > > On Fri, Oct 20, 2023 at 06:03:29PM +0200, Sebastian Reichel wrote: > > > On Fri, Oct 20, 2023 at 04:36:19PM +0100, Conor Dooley wrote: > > > > On Fri, Oct 20, 2023 at 04:11:40PM +0200, Sebastian Reichel wrote: > > > > > [...] > > > > > +allOf: > > > > > + - $ref: snps,dwc3.yaml# > > > > > + - if: > > > > > + properties: > > > > > + compatible: > > > > > + contains: > > > > > + const: rockchip,rk3328-dwc3 > > > > > + then: > > > > > + properties: > > > > > + clocks: > > > > > + minItems: 3 > > > > > + maxItems: 4 > > > > > + clock-names: > > > > > + minItems: 3 > > > > > + items: > > > > > + - const: ref_clk > > > > > + - const: suspend_clk > > > > > + - const: bus_clk > > > > > + - const: grf_clk > > > > > > > > minItems for clocks and clock-names is already 3, is it not? > > > > > > Yes, but the following 'maxItems: 4' implicitly sets it to 4, > > > so I had to set it again. The same is true for clock-names - > > > providings new 'items:' effectively drops the "minItems: 3" > > > from the generic section. > > > > Are you sure? We don't add anything implicit in the if/then schemas. > > Could be a tool issue though. > > I had this issue in the past. But just in case I also did a re-test > before sending my last mail and I did get a warning. So yes, I'm > quite sure :) Well, I'm quite surprised no one else noticed. Anyways, I'm working on a fix for it. In the meantime, just leave it as you have it. Note that there's an existing error in this binding I noticed in the example. The clocks and clock-names lengths don't match. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel