From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AAF1C00A8F for ; Tue, 24 Oct 2023 19:50:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ty/7/K9alY70tV+JWWhsOMcA9E8ke4RlHcFKS5rQY6U=; b=EPJcJZ5ac9LVDC d0zTkIHvlVdwV1L3Cr9JmIMfe2xK4/E7r5iZjVXV7ZD+YJtS7sEcp7VHfcqA9CtpDAYIHhC3Anp+X XIPvNTYKTymbqIwGwHW4+GekLzXbYiyRmheweWXhSqbxm/yz6w+WIOk7iDi0fSaJjrZvnrXUOudaf f4oFjEglN+qEWE6wYhvLV0nLMhspRhSMeLuh37PUKaieKNRhNJ3+er9sRNkA/d8CxBEZ7SNLnKXoT wbDxLe591mTEcSm7RvZRmwr6/bp/QzIvZXYitJf1/+GjbnFsWJUvyHH4j2xVRgjtTULtQjYZBrZcH u9vPm31qB9AtKRoPegig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvNPV-00AmE7-0l; Tue, 24 Oct 2023 19:49:53 +0000 Received: from mail-oo1-f50.google.com ([209.85.161.50]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvNPS-00AmDg-1N for linux-arm-kernel@lists.infradead.org; Tue, 24 Oct 2023 19:49:51 +0000 Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-581fb6f53fcso2891840eaf.2 for ; Tue, 24 Oct 2023 12:49:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698176989; x=1698781789; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=agKMir3qcuKi14ldHG71aEKuRkt+lScGsRzAjnaqW/E=; b=D9o45NXU88jCJwih0pDkW4Ln8IRbI6K16dZQ3LptBccQhcqQBO65E7TWRfST/BXl+N 8uR1JoVBLGgwJO4U/eY5em+2IqLbfXFPGEaZWMIeD1PHDA/d5DiWHBahcBGXhS2K/xF+ /yczF6ZfTURlE0wq6ZglBafjPtBrfrWHg4GLtgaG/l/7WZC2tj7rBeFiZ90DW0trkZI6 FuwLzAzb5xad8g50lyRC1xEkEljdljObwbqn5iF3sgL369doYgb1cXdkMMrKYp9rdF85 NIMWUzFg6jyaveA/8wh+DDU9cSZJRq7O5wBwJcmkelEJ7JHWR5skErYq5pJMd9VVmhH0 2sjg== X-Gm-Message-State: AOJu0YwB1B3SNegcaN6/FyC6iTn7LjvGMnSpJgj+GTjBkJgPZ1IdJHIT T/cYOwjWijkj6lW7tvQW4g== X-Google-Smtp-Source: AGHT+IHyx9HB+5+xduv+DWRMK6EwebWorzR3T6o2xTNeFxgl5EwZIRIwryDhY3qLSLdiLQZ2wQLsaQ== X-Received: by 2002:a4a:e0ca:0:b0:581:e303:807c with SMTP id e10-20020a4ae0ca000000b00581e303807cmr12970213oot.5.1698176988888; Tue, 24 Oct 2023 12:49:48 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id r134-20020a4a378c000000b00582014b0138sm2165972oor.39.2023.10.24.12.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:49:48 -0700 (PDT) Received: (nullmailer pid 452036 invoked by uid 1000); Tue, 24 Oct 2023 19:49:46 -0000 Date: Tue, 24 Oct 2023 14:49:46 -0500 From: Rob Herring To: Alexander Stein Cc: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Ulf Hansson , Marek Vasut , Pengutronix Kernel Team , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/5] dt-bindings: soc: imx93-media-blk-ctrl: Add LDB subnode into schema and example Message-ID: <20231024194946.GA434797-robh@kernel.org> References: <20231020130019.665853-1-alexander.stein@ew.tq-group.com> <20231020130019.665853-3-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231020130019.665853-3-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231024_124950_469613_BA83924C X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 20, 2023 at 03:00:15PM +0200, Alexander Stein wrote: > Document the LDB bridge subnode and add the subnode into the example. > For the subnode to work, the block control must scan its subnodes and > bind drivers to them, do not misuse either simple-bus or simple-mfd > here. > > Signed-off-by: Alexander Stein > --- > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > index b3554e7f9e76..5ba66dfb0e05 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > @@ -24,6 +24,12 @@ properties: > reg: > maxItems: 1 > > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + Presumably the child nodes are MMIO? If so, missing 'ranges'. > '#power-domain-cells': > const: 1 > > @@ -46,9 +52,16 @@ properties: > - const: csi > - const: dsi > > + bridge@20: > + type: object > + $ref: /schemas/display/bridge/fsl,ldb.yaml# > + unevaluatedProperties: false We do this style a lot, but another way to do child nodes is: type: object additionalProperties: true properties: compatible: contains: const: fsl,imx93-ldb This way avoids applying the fsl,ldb.yaml schema twice and ensures the right LDB compatible is used. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel