From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9770FC07545 for ; Tue, 24 Oct 2023 19:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=97KlP0vc4wD8WYuyl2jFful+daYYSlzN52hI29Xgl24=; b=V5eWScz9gKF+ow YJtfyFBPACPQbUEoBM9DkxZsKkhCttB2RtqljwL0hgldDdFpqlkdk1qgnjU0rum4wqy9ykc9nYyH+ 5XfIru4yMYodGGc8pNCuTCYzOs9uoeQRzEzd6qImUVfWZnGsqQJ3KE8rxtoIWIbOH5YqTTEXfd9Ja QD8BH1aJ4Bqyfnw/xqIubhuocnsCBOSvojfTGefVko888JDYdO8iqOXXp57avCskP0xKEjC9alFU/ VVAfZsA9UIO2d26+Qy9xfrHWcjp4FWtVklq5B63MOxXtsVBb++lxEO716mIMxsLx3OOx5q16VMKH+ /mYcWX3tcxRMqfu+JNWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvNRK-00AmSN-1F; Tue, 24 Oct 2023 19:51:46 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvNRH-00AmQw-2j for linux-arm-kernel@lists.infradead.org; Tue, 24 Oct 2023 19:51:45 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-53d8320f0easo7605602a12.3 for ; Tue, 24 Oct 2023 12:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698177100; x=1698781900; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JUj/EbiokY8d7LdNm6RQo8caawEG1TrnDKw19EfO3ho=; b=PRMqHE9PoWR6ijwjbigHFRdHKtBFE+Tms9hrMh4u/tUMbviKA6fhmPML4i/sRiRFxf mVO9kNfSBcellh3OPeMCTng5m5Lr5VjQSgMIMoPyK0fL6CSTvLqJy0wwRISjCIA3gpwc yNh3nqyFqbBML9cHhDNV1OXPFDQAHqgW6o+bFmcnoMzX+IkW6+JTmP71W/0VXRZCk1TZ VLPZBXSfNZTKe/TtaEYnA5W/DLO9SL+BT7PXE+RF/Xj1CyFSWsZjSOTRWQrlNu70UyeW WcZRip89fDEQ2MIvzWAs9gJJIEM7C0B/k6NzpfKbhlGi9xdG7H/YEXsv72WdCzjudFU4 TKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698177100; x=1698781900; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JUj/EbiokY8d7LdNm6RQo8caawEG1TrnDKw19EfO3ho=; b=InZMR3TcF2Diy/i6bQ0hrwysXTTw9RX7yggNWl8LgrPhylZUi5cbBx2l2b0yfgKGM6 L64b80u1+VmcLH//vg/q5w3/jbn5DUd0/vRdr8MbIl/R+zTsatZDamaDF75xnM0c4Qyl bonYyKo+SUMUo9fkmDmnwTSnbQ4CbodRlRXl+bmnSXzxtxeFtv//6W/8DaOHo5YX+VUq JwqL/jA+VDIgcFUwtcKatMb0mhBAKP//qkCJIZjdt8eneD/OnI5XxmhVVlyIFqg4EaIk G2LM1oF5xLtVk2WNliwfc25HqPc7zLyyn9NmbY08zUG7WzgkTXYAti3TgHkb+4Wuqig2 bhHA== X-Gm-Message-State: AOJu0Yw3ytgNa6OwpZkcjWRn833ATt1vTlhb8LCRBlkpM5oMPDGQ2ZAz F6s3ygxEFFoYzTxG4ZCbnbw= X-Google-Smtp-Source: AGHT+IG1BP5ROpvBcq82uPkVt2IykY39Qtb6MXydHhu5xMIX7B2RI0+qsY/OIOKtA3Sz56zxhshLhw== X-Received: by 2002:a05:6402:5243:b0:530:e2e3:28af with SMTP id t3-20020a056402524300b00530e2e328afmr11299128edd.31.1698177100282; Tue, 24 Oct 2023 12:51:40 -0700 (PDT) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id v30-20020a50a45e000000b0053da3a9847csm8563621edb.42.2023.10.24.12.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:51:40 -0700 (PDT) Date: Tue, 24 Oct 2023 22:51:37 +0300 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Linus Walleij , Enrico Mioso , Robert Marko , Chris Packham , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek =?utf-8?B?QmVow7pu?= , Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v7 5/7] ARM64: dts: marvell: Fix some common switch mistakes Message-ID: <20231024195137.2fgustgmyl2r7cdt@skbuf> References: <20231024-marvell-88e6152-wan-led-v7-0-2869347697d1@linaro.org> <20231024-marvell-88e6152-wan-led-v7-5-2869347697d1@linaro.org> <20231024182842.flxrg3hjm3scnhjo@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231024_125143_884421_C45CD1CC X-CRM114-Status: GOOD ( 27.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 24, 2023 at 08:03:47PM +0100, Russell King (Oracle) wrote: > On Tue, Oct 24, 2023 at 09:28:42PM +0300, Vladimir Oltean wrote: > > U-Boot code does this, so you can't rename "ports": > > > > /* > > * now if there are more switches or a SFP module coming after, > > * enable corresponding ports > > */ > > if (id < peridot + topaz - 1) { > > res = fdt_status_okay_by_pathf(blob, > > "%s/switch%i@%x/ports/port@a", > > mdio_path, id, addr); > > } else if (id == peridot - 1 && !topaz && sfp) { > > res = fdt_status_okay_by_pathf(blob, > > "%s/switch%i@%x/ports/port-sfp@a", > > mdio_path, id, addr); > > } else { > > res = 0; > > } > > So that's now two platforms that do this. I think at this stage, we > have to regard these node paths as an ABI that we just can't change > without causing some breakage. No, it's still the same as the one I pointed out on v4: https://patchwork.kernel.org/project/netdevbpf/patch/20231018-marvell-88e6152-wan-led-v4-5-3ee0c67383be@linaro.org/ aka the Turris MOX. But it looks like my previous comment wasn't quite clear, thus Linus' conversion still cleans up too much in this device tree. > If we can't fix up all platforms, doesn't that make the YAML > conversion harder? Well, I do see this as a valid concern that could potentially bite back, yes. I did express that the schema should not emit warnings for $nodename, but TBH I don't know how that constraint could be eliminated: https://patchwork.kernel.org/project/netdevbpf/patch/20231018-marvell-88e6152-wan-led-v4-6-3ee0c67383be@linaro.org/ > You've asked me to test the Clearfog GT-8k change - which is something > that won't happen for a while as I don't have the hardware to hand at > my current location, nor remotely. > > What I can do is poke about in the u-boot sources I have for that > board and see# whether it's doing anything with those node paths. Off > the top of my# head, given what the board is, I think it's highly > unlikely though,# but I will check - possibly tomorrow. Ok, if U-Boot is the only bootloader, I also looked through the upstream board source files and only noticed any fixups for MOX. I don't know what these boards ship with, and how far that is from mainline U-Boot. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel