From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21E60C07545 for ; Wed, 25 Oct 2023 15:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e4YiX7iLRFXT1hWd63m6DwGcCid3Q5om/mf5zTH9viM=; b=Oz6rS6wE70pRHD 9UWWeYh/hW47CbNl/YEH7zseK+VO+avxDUX5R1sRVp/PZH/gOSlFgOoobs/8zHrJAGnutaq0jQSoy 4iqnbnHvLgAxopemjfPm3MivcpEam/6biJ/3VMnFSD46aGdJ6vXMR1PDF77Aj1FaW3zo2fAVSu+3F LilZ+taRE6R3tjdiZnz2F/FBhIfTKDNgbp9LdzdG88UGn7mQTcHbutSe8jqU2a/RIqam17KWA93Y2 npHCc8lTOlfaHk8a4MfgcJ/mPVuNpu92+HZdCD1SqxmP9OrG9ceNfb/1/lZmH1vwQQNiMYXmDd380 w7kftinrwh4r2EEhvsBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvgGZ-00CfK0-2B; Wed, 25 Oct 2023 15:57:55 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvgGW-00CfJL-1I for linux-arm-kernel@lists.infradead.org; Wed, 25 Oct 2023 15:57:54 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 39PFvhET013312; Wed, 25 Oct 2023 10:57:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1698249463; bh=EeIvSdJTPv70yRQJz4urS0T172AtomQUKqKng0i1Tq8=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=SPXkLk8T0knwJiZAGrH0ZM3/o0HwCMlCbli8aNfJZMMM6BDAwrLAZyBXmjgItr+Zf DYD/s+FXMTwblSj60kv8XpdOnJKyxDM50ID70wle81G+4KxH5FEwYLKwnUdFPb+cm5 Fz5YTtSCwXZOgckiCn+RFrIQrLZ82VrDyqrcZUkw= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 39PFvhpC114580 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Oct 2023 10:57:43 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 25 Oct 2023 10:57:43 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 25 Oct 2023 10:57:43 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 39PFvhfV100334; Wed, 25 Oct 2023 10:57:43 -0500 Date: Wed, 25 Oct 2023 10:57:43 -0500 From: Nishanth Menon To: Nitin Yadav CC: , , , , , , , Subject: Re: [PATCH] arm64: boot: dts: ti: k3-am62a-main: Fix GPIO pin count in DT nodes. Message-ID: <20231025155743.nk7un6pvib7swtxg@decorator> References: <20231025110252.1089979-1-n-yadav@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231025110252.1089979-1-n-yadav@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_085752_544210_6FD2FAFB X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:32-20231025, Nitin Yadav wrote: > Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according > to AM62a SK datasheet. The Link of datasheet is in the following line: SK? line? Please rephrase above and just mention the section of the data sheet to refer to. > > https://www.ti.com/lit/gpn/am62a3 > > Section: 6.3.10 GPIO (Page No. 52-55) > > Fixes: '5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")' What is the single quote for? Also note the additional comment in the list to drop the extra EoL. Did you check the MCU and WKUP GPIO count as well? if there are bugs around it, fix it in a single commit please. > > Signed-off-by: Nitin Yadav > --- > arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi > index 3198af08fb9f..de36abb243f1 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi > @@ -462,7 +462,7 @@ main_gpio0: gpio@600000 { > <193>, <194>, <195>; > interrupt-controller; > #interrupt-cells = <2>; > - ti,ngpio = <87>; > + ti,ngpio = <92>; > ti,davinci-gpio-unbanked = <0>; > power-domains = <&k3_pds 77 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 77 0>; > @@ -480,7 +480,7 @@ main_gpio1: gpio@601000 { > <183>, <184>, <185>; > interrupt-controller; > #interrupt-cells = <2>; > - ti,ngpio = <88>; > + ti,ngpio = <52>; > ti,davinci-gpio-unbanked = <0>; > power-domains = <&k3_pds 78 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 78 0>; > -- > 2.25.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel