* [PATCH v2 1/5] arm64: dts: mt7986: fix emmc hs400 mode without uboot initialization
2023-10-25 17:08 [PATCH v2 0/5] mt7986 DTS Patches Frank Wunderlich
@ 2023-10-25 17:08 ` Frank Wunderlich
2023-11-29 13:27 ` AngeloGioacchino Del Regno
2023-10-25 17:08 ` [PATCH v2 2/5] arm64: dts: mt7986: define 3W max power to both SFP on BPI-R3 Frank Wunderlich
` (3 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Frank Wunderlich @ 2023-10-25 17:08 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Matthias Brugger, AngeloGioacchino Del Regno,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Daniel Golle,
linux-kernel, linux-arm-kernel, Eric Woudstra, stable
From: Eric Woudstra <ericwouds@gmail.com>
Eric reports errors on emmc with hs400 mode when booting linux on bpi-r3
without uboot [1]. Booting with uboot does not show this because clocks
seem to be initialized by uboot.
Fix this by adding assigned-clocks and assigned-clock-parents like it's
done in uboot [2].
[1] https://forum.banana-pi.org/t/bpi-r3-kernel-fails-setting-emmc-clock-to-416m-depends-on-u-boot/15170
[2] https://github.com/u-boot/u-boot/blob/master/arch/arm/dts/mt7986.dtsi#L287
Cc: stable@vger.kernel.org
Fixes: 513b49d19b34 ("arm64: dts: mt7986: add mmc related device nodes")
Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
index 24eda00e320d..77ddd9e44ed2 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
@@ -374,6 +374,10 @@ mmc0: mmc@11230000 {
reg = <0 0x11230000 0 0x1000>,
<0 0x11c20000 0 0x1000>;
interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
+ assigned-clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>,
+ <&topckgen CLK_TOP_EMMC_250M_SEL>;
+ assigned-clock-parents = <&apmixedsys CLK_APMIXED_MPLL>,
+ <&topckgen CLK_TOP_NET1PLL_D5_D2>;
clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>,
<&infracfg CLK_INFRA_MSDC_HCK_CK>,
<&infracfg CLK_INFRA_MSDC_CK>,
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/5] arm64: dts: mt7986: fix emmc hs400 mode without uboot initialization
2023-10-25 17:08 ` [PATCH v2 1/5] arm64: dts: mt7986: fix emmc hs400 mode without uboot initialization Frank Wunderlich
@ 2023-11-29 13:27 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-11-29 13:27 UTC (permalink / raw)
To: linux-mediatek, Eugen Hristev, Frank Wunderlich
Cc: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, devicetree, matthias.bgg, kernel,
Frank Wunderlich, Rob Herring, Conor Dooley, Daniel Golle,
Eric Woudstra, stable
On Wed, 25 Oct 2023 19:08:28 +0200, Frank Wunderlich wrote:
> Eric reports errors on emmc with hs400 mode when booting linux on bpi-r3
> without uboot [1]. Booting with uboot does not show this because clocks
> seem to be initialized by uboot.
>
> Fix this by adding assigned-clocks and assigned-clock-parents like it's
> done in uboot [2].
>
> [...]
Applied, thanks!
[1/5] arm64: dts: mt7986: fix emmc hs400 mode without uboot initialization
(no commit info)
Best regards,
--
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/5] arm64: dts: mt7986: define 3W max power to both SFP on BPI-R3
2023-10-25 17:08 [PATCH v2 0/5] mt7986 DTS Patches Frank Wunderlich
2023-10-25 17:08 ` [PATCH v2 1/5] arm64: dts: mt7986: fix emmc hs400 mode without uboot initialization Frank Wunderlich
@ 2023-10-25 17:08 ` Frank Wunderlich
2023-11-29 13:27 ` AngeloGioacchino Del Regno
2023-10-25 17:08 ` [PATCH v2 3/5] arm64: dts: mt7986: change cooling trips Frank Wunderlich
` (2 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Frank Wunderlich @ 2023-10-25 17:08 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Matthias Brugger, AngeloGioacchino Del Regno,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Daniel Golle,
linux-kernel, linux-arm-kernel, Eric Woudstra
From: Frank Wunderlich <frank-w@public-files.de>
All SFP power supplies are connected to the system VDD33 which is 3v3/8A.
Set 3A per SFP slot to allow SFPs work which need more power than the
default 1W.
Fixes: 8e01fb15b815 ("arm64: dts: mt7986: add Bananapi R3")
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
index af4a4309bda4..f9702284607a 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
@@ -126,6 +126,7 @@ sfp1: sfp-1 {
compatible = "sff,sfp";
i2c-bus = <&i2c_sfp1>;
los-gpios = <&pio 46 GPIO_ACTIVE_HIGH>;
+ maximum-power-milliwatt = <3000>;
mod-def0-gpios = <&pio 49 GPIO_ACTIVE_LOW>;
tx-disable-gpios = <&pio 20 GPIO_ACTIVE_HIGH>;
tx-fault-gpios = <&pio 7 GPIO_ACTIVE_HIGH>;
@@ -137,6 +138,7 @@ sfp2: sfp-2 {
i2c-bus = <&i2c_sfp2>;
los-gpios = <&pio 31 GPIO_ACTIVE_HIGH>;
mod-def0-gpios = <&pio 47 GPIO_ACTIVE_LOW>;
+ maximum-power-milliwatt = <3000>;
tx-disable-gpios = <&pio 15 GPIO_ACTIVE_HIGH>;
tx-fault-gpios = <&pio 48 GPIO_ACTIVE_HIGH>;
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 2/5] arm64: dts: mt7986: define 3W max power to both SFP on BPI-R3
2023-10-25 17:08 ` [PATCH v2 2/5] arm64: dts: mt7986: define 3W max power to both SFP on BPI-R3 Frank Wunderlich
@ 2023-11-29 13:27 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-11-29 13:27 UTC (permalink / raw)
To: linux-mediatek, Eugen Hristev, Frank Wunderlich
Cc: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, devicetree, matthias.bgg, kernel,
Frank Wunderlich, Rob Herring, Conor Dooley, Daniel Golle,
Eric Woudstra
On Wed, 25 Oct 2023 19:08:29 +0200, Frank Wunderlich wrote:
> All SFP power supplies are connected to the system VDD33 which is 3v3/8A.
> Set 3A per SFP slot to allow SFPs work which need more power than the
> default 1W.
>
>
Applied, thanks!
[2/5] arm64: dts: mt7986: define 3W max power to both SFP on BPI-R3
(no commit info)
Best regards,
--
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/5] arm64: dts: mt7986: change cooling trips
2023-10-25 17:08 [PATCH v2 0/5] mt7986 DTS Patches Frank Wunderlich
2023-10-25 17:08 ` [PATCH v2 1/5] arm64: dts: mt7986: fix emmc hs400 mode without uboot initialization Frank Wunderlich
2023-10-25 17:08 ` [PATCH v2 2/5] arm64: dts: mt7986: define 3W max power to both SFP on BPI-R3 Frank Wunderlich
@ 2023-10-25 17:08 ` Frank Wunderlich
2023-11-20 13:41 ` AngeloGioacchino Del Regno
2023-11-29 13:27 ` AngeloGioacchino Del Regno
2023-10-25 17:08 ` [PATCH v2 4/5] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3 Frank Wunderlich
2023-10-25 17:08 ` [PATCH v2 5/5] arm64: dts: mt7986: add overlay for SATA power socket on BPI-R3 Frank Wunderlich
4 siblings, 2 replies; 14+ messages in thread
From: Frank Wunderlich @ 2023-10-25 17:08 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Matthias Brugger, AngeloGioacchino Del Regno,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Daniel Golle,
linux-kernel, linux-arm-kernel, Eric Woudstra
From: Frank Wunderlich <frank-w@public-files.de>
Add Critical and hot trips for emergency system shutdown and limiting
system load.
Change passive trip to active to make sure fan is activated on the
lowest trip.
Fixes: 1f5be05132f3 ("arm64: dts: mt7986: add thermal-zones")
Fixes: c26f779a2295 ("arm64: dts: mt7986: add pwm-fan and cooling-maps to BPI-R3 dts")
Suggested-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v2:
- squash patch for bpi-r3 as suggested by angelo
---
.../dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 10 +++++-----
arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 20 +++++++++++++++----
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
index f9702284607a..b876e501216b 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
@@ -152,16 +152,16 @@ cpu-active-high {
trip = <&cpu_trip_active_high>;
};
- cpu-active-low {
+ cpu-active-med {
/* active: set fan to cooling level 1 */
cooling-device = <&fan 1 1>;
- trip = <&cpu_trip_active_low>;
+ trip = <&cpu_trip_active_med>;
};
- cpu-passive {
- /* passive: set fan to cooling level 0 */
+ cpu-active-low {
+ /* active: set fan to cooling level 0 */
cooling-device = <&fan 0 0>;
- trip = <&cpu_trip_passive>;
+ trip = <&cpu_trip_active_low>;
};
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
index 77ddd9e44ed2..fc751e049953 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
@@ -614,22 +614,34 @@ cpu_thermal: cpu-thermal {
thermal-sensors = <&thermal 0>;
trips {
+ cpu_trip_crit: crit {
+ temperature = <125000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+
+ cpu_trip_hot: hot {
+ temperature = <120000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+
cpu_trip_active_high: active-high {
temperature = <115000>;
hysteresis = <2000>;
type = "active";
};
- cpu_trip_active_low: active-low {
+ cpu_trip_active_med: active-med {
temperature = <85000>;
hysteresis = <2000>;
type = "active";
};
- cpu_trip_passive: passive {
- temperature = <40000>;
+ cpu_trip_active_low: active-low {
+ temperature = <60000>;
hysteresis = <2000>;
- type = "passive";
+ type = "active";
};
};
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 3/5] arm64: dts: mt7986: change cooling trips
2023-10-25 17:08 ` [PATCH v2 3/5] arm64: dts: mt7986: change cooling trips Frank Wunderlich
@ 2023-11-20 13:41 ` AngeloGioacchino Del Regno
2023-11-29 13:27 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-11-20 13:41 UTC (permalink / raw)
To: Frank Wunderlich, linux-mediatek
Cc: Frank Wunderlich, Matthias Brugger, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Daniel Golle, linux-kernel,
linux-arm-kernel, Eric Woudstra
Il 25/10/23 19:08, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Add Critical and hot trips for emergency system shutdown and limiting
> system load.
>
> Change passive trip to active to make sure fan is activated on the
> lowest trip.
>
> Fixes: 1f5be05132f3 ("arm64: dts: mt7986: add thermal-zones")
> Fixes: c26f779a2295 ("arm64: dts: mt7986: add pwm-fan and cooling-maps to BPI-R3 dts")
> Suggested-by: Daniel Golle <daniel@makrotopia.org>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 3/5] arm64: dts: mt7986: change cooling trips
2023-10-25 17:08 ` [PATCH v2 3/5] arm64: dts: mt7986: change cooling trips Frank Wunderlich
2023-11-20 13:41 ` AngeloGioacchino Del Regno
@ 2023-11-29 13:27 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-11-29 13:27 UTC (permalink / raw)
To: linux-mediatek, Eugen Hristev, Frank Wunderlich
Cc: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, devicetree, matthias.bgg, kernel,
Frank Wunderlich, Rob Herring, Conor Dooley, Daniel Golle,
Eric Woudstra
On Wed, 25 Oct 2023 19:08:30 +0200, Frank Wunderlich wrote:
> Add Critical and hot trips for emergency system shutdown and limiting
> system load.
>
> Change passive trip to active to make sure fan is activated on the
> lowest trip.
>
>
> [...]
Applied, thanks!
[3/5] arm64: dts: mt7986: change cooling trips
(no commit info)
Best regards,
--
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 4/5] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3
2023-10-25 17:08 [PATCH v2 0/5] mt7986 DTS Patches Frank Wunderlich
` (2 preceding siblings ...)
2023-10-25 17:08 ` [PATCH v2 3/5] arm64: dts: mt7986: change cooling trips Frank Wunderlich
@ 2023-10-25 17:08 ` Frank Wunderlich
2023-12-09 14:56 ` Aw: " Frank Wunderlich
2023-10-25 17:08 ` [PATCH v2 5/5] arm64: dts: mt7986: add overlay for SATA power socket on BPI-R3 Frank Wunderlich
4 siblings, 1 reply; 14+ messages in thread
From: Frank Wunderlich @ 2023-10-25 17:08 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Matthias Brugger, AngeloGioacchino Del Regno,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Daniel Golle,
linux-kernel, linux-arm-kernel, Eric Woudstra
From: Frank Wunderlich <frank-w@public-files.de>
Build devicetree binaries for testing overlays and providing users
full dtb without using overlays.
Suggested-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/
v2:
make full dtbs multiline for better readability
---
arch/arm64/boot/dts/mediatek/Makefile | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index c99c3372a4b5..24eeba0703ce 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -8,11 +8,33 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-evb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
+
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
+mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := \
+ mt7986a-bananapi-bpi-r3.dtb \
+ mt7986a-bananapi-bpi-r3-emmc.dtbo \
+ mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
+mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := \
+ mt7986a-bananapi-bpi-r3.dtb \
+ mt7986a-bananapi-bpi-r3-emmc.dtbo \
+ mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
+mt7986a-bananapi-bpi-r3-sd-nand-dtbs := \
+ mt7986a-bananapi-bpi-r3.dtb \
+ mt7986a-bananapi-bpi-r3-sd.dtbo \
+ mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
+mt7986a-bananapi-bpi-r3-sd-nor-dtbs := \
+ mt7986a-bananapi-bpi-r3.dtb \
+ mt7986a-bananapi-bpi-r3-sd.dtbo \
+ mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
+
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Aw: [PATCH v2 4/5] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3
2023-10-25 17:08 ` [PATCH v2 4/5] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3 Frank Wunderlich
@ 2023-12-09 14:56 ` Frank Wunderlich
2024-06-04 17:01 ` Frank Wunderlich
0 siblings, 1 reply; 14+ messages in thread
From: Frank Wunderlich @ 2023-12-09 14:56 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-mediatek, Matthias Brugger, AngeloGioacchino Del Regno,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Daniel Golle,
linux-kernel, linux-arm-kernel, Eric Woudstra
Hi
Parts 1-3 are applied here, but how to proceed with this? to add further devicetrees like
for mt7988 we have to fix the "broken" dt-overlays first.
i want to keep to build the dtbo to allow dynamic apply in bootloader, but they should be checked in
compiletime too and full dtb should be created for users not wanting to handle overlays.
regards Frank
> Gesendet: Mittwoch, 25. Oktober 2023 um 18:08 Uhr
> Von: "Frank Wunderlich" <linux@fw-web.de>
> Build devicetree binaries for testing overlays and providing users
> full dtb without using overlays.
>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
> https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/
>
> v2:
> make full dtbs multiline for better readability
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index c99c3372a4b5..24eeba0703ce 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -8,11 +8,33 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-evb.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
> +
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
> +mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := \
> + mt7986a-bananapi-bpi-r3.dtb \
> + mt7986a-bananapi-bpi-r3-emmc.dtbo \
> + mt7986a-bananapi-bpi-r3-nand.dtbo
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
> +mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := \
> + mt7986a-bananapi-bpi-r3.dtb \
> + mt7986a-bananapi-bpi-r3-emmc.dtbo \
> + mt7986a-bananapi-bpi-r3-nor.dtbo
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
> +mt7986a-bananapi-bpi-r3-sd-nand-dtbs := \
> + mt7986a-bananapi-bpi-r3.dtb \
> + mt7986a-bananapi-bpi-r3-sd.dtbo \
> + mt7986a-bananapi-bpi-r3-nand.dtbo
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
> +mt7986a-bananapi-bpi-r3-sd-nor-dtbs := \
> + mt7986a-bananapi-bpi-r3.dtb \
> + mt7986a-bananapi-bpi-r3-sd.dtbo \
> + mt7986a-bananapi-bpi-r3-nor.dtbo
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
> +
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Aw: [PATCH v2 4/5] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3
2023-12-09 14:56 ` Aw: " Frank Wunderlich
@ 2024-06-04 17:01 ` Frank Wunderlich
0 siblings, 0 replies; 14+ messages in thread
From: Frank Wunderlich @ 2024-06-04 17:01 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, linux-mediatek, Matthias Brugger,
AngeloGioacchino Del Regno, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Daniel Golle, linux-kernel, linux-arm-kernel,
Eric Woudstra
Hi,
how to proceed here?
regards Frank
> Gesendet: Samstag, 09. Dezember 2023 um 16:56 Uhr
> Von: "Frank Wunderlich" <frank-w@public-files.de>
> An: "Frank Wunderlich" <linux@fw-web.de>
> Cc: linux-mediatek@lists.infradead.org, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, "Daniel Golle" <daniel@makrotopia.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Eric Woudstra" <ericwouds@gmail.com>
> Betreff: Aw: [PATCH v2 4/5] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3
>
> Hi
>
> Parts 1-3 are applied here, but how to proceed with this? to add further devicetrees like
> for mt7988 we have to fix the "broken" dt-overlays first.
>
> i want to keep to build the dtbo to allow dynamic apply in bootloader, but they should be checked in
> compiletime too and full dtb should be created for users not wanting to handle overlays.
>
> regards Frank
>
>
> > Gesendet: Mittwoch, 25. Oktober 2023 um 18:08 Uhr
> > Von: "Frank Wunderlich" <linux@fw-web.de>
>
> > Build devicetree binaries for testing overlays and providing users
> > full dtb without using overlays.
> >
> > Suggested-by: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
> > https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/
> >
> > v2:
> > make full dtbs multiline for better readability
> > ---
> > arch/arm64/boot/dts/mediatek/Makefile | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> > index c99c3372a4b5..24eeba0703ce 100644
> > --- a/arch/arm64/boot/dts/mediatek/Makefile
> > +++ b/arch/arm64/boot/dts/mediatek/Makefile
> > @@ -8,11 +8,33 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-evb.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
> > +
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
> > +mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := \
> > + mt7986a-bananapi-bpi-r3.dtb \
> > + mt7986a-bananapi-bpi-r3-emmc.dtbo \
> > + mt7986a-bananapi-bpi-r3-nand.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
> > +mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := \
> > + mt7986a-bananapi-bpi-r3.dtb \
> > + mt7986a-bananapi-bpi-r3-emmc.dtbo \
> > + mt7986a-bananapi-bpi-r3-nor.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
> > +mt7986a-bananapi-bpi-r3-sd-nand-dtbs := \
> > + mt7986a-bananapi-bpi-r3.dtb \
> > + mt7986a-bananapi-bpi-r3-sd.dtbo \
> > + mt7986a-bananapi-bpi-r3-nand.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
> > +mt7986a-bananapi-bpi-r3-sd-nor-dtbs := \
> > + mt7986a-bananapi-bpi-r3.dtb \
> > + mt7986a-bananapi-bpi-r3-sd.dtbo \
> > + mt7986a-bananapi-bpi-r3-nor.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
> > +
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 5/5] arm64: dts: mt7986: add overlay for SATA power socket on BPI-R3
2023-10-25 17:08 [PATCH v2 0/5] mt7986 DTS Patches Frank Wunderlich
` (3 preceding siblings ...)
2023-10-25 17:08 ` [PATCH v2 4/5] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3 Frank Wunderlich
@ 2023-10-25 17:08 ` Frank Wunderlich
2023-10-26 8:03 ` AngeloGioacchino Del Regno
4 siblings, 1 reply; 14+ messages in thread
From: Frank Wunderlich @ 2023-10-25 17:08 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Matthias Brugger, AngeloGioacchino Del Regno,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Daniel Golle,
linux-kernel, linux-arm-kernel, Eric Woudstra
From: Frank Wunderlich <frank-w@public-files.de>
Bananapi R3 has a Power socket entended for using external SATA drives.
This Socket is off by default but can be switched with gpio 8.
Add an overlay to activate it.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v2:
- rebase on the patch "add dtbs with applied overlays for bpi-r3"
- add sata-overlay to the full dtbs
---
arch/arm64/boot/dts/mediatek/Makefile | 13 +++++--
.../mt7986a-bananapi-bpi-r3-sata.dtso | 39 +++++++++++++++++++
2 files changed, 48 insertions(+), 4 deletions(-)
create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index 24eeba0703ce..c3b236a47513 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -13,26 +13,31 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sata.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := \
mt7986a-bananapi-bpi-r3.dtb \
mt7986a-bananapi-bpi-r3-emmc.dtbo \
- mt7986a-bananapi-bpi-r3-nand.dtbo
+ mt7986a-bananapi-bpi-r3-nand.dtbo \
+ mt7986a-bananapi-bpi-r3-sata.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := \
mt7986a-bananapi-bpi-r3.dtb \
mt7986a-bananapi-bpi-r3-emmc.dtbo \
- mt7986a-bananapi-bpi-r3-nor.dtbo
+ mt7986a-bananapi-bpi-r3-nor.dtbo \
+ mt7986a-bananapi-bpi-r3-sata.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
mt7986a-bananapi-bpi-r3-sd-nand-dtbs := \
mt7986a-bananapi-bpi-r3.dtb \
mt7986a-bananapi-bpi-r3-sd.dtbo \
- mt7986a-bananapi-bpi-r3-nand.dtbo
+ mt7986a-bananapi-bpi-r3-nand.dtbo \
+ mt7986a-bananapi-bpi-r3-sata.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
mt7986a-bananapi-bpi-r3-sd-nor-dtbs := \
mt7986a-bananapi-bpi-r3.dtb \
mt7986a-bananapi-bpi-r3-sd.dtbo \
- mt7986a-bananapi-bpi-r3-nor.dtbo
+ mt7986a-bananapi-bpi-r3-nor.dtbo \
+ mt7986a-bananapi-bpi-r3-sata.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso
new file mode 100644
index 000000000000..6ab06813412a
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso
@@ -0,0 +1,39 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2021 MediaTek Inc.
+ * Author: Frank Wunderlich <frank-w@public-files.de>
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+ compatible = "bananapi,bpi-r3", "mediatek,mt7986a";
+
+ fragment@0 {
+ target-path = "/";
+ __overlay__ {
+ reg_sata12v: regulator-sata12v {
+ compatible = "regulator-fixed";
+ regulator-name = "sata12v";
+ regulator-min-microvolt = <12000000>;
+ regulator-max-microvolt = <12000000>;
+ gpio = <&pio 8 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ regulator-always-on;
+ };
+
+ reg_sata5v: regulator-sata5v {
+ compatible = "regulator-fixed";
+ regulator-name = "sata5v";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ vin-supply = <®_sata12v>;
+ };
+ };
+ };
+};
+
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 5/5] arm64: dts: mt7986: add overlay for SATA power socket on BPI-R3
2023-10-25 17:08 ` [PATCH v2 5/5] arm64: dts: mt7986: add overlay for SATA power socket on BPI-R3 Frank Wunderlich
@ 2023-10-26 8:03 ` AngeloGioacchino Del Regno
2023-10-26 9:01 ` Frank Wunderlich
0 siblings, 1 reply; 14+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-10-26 8:03 UTC (permalink / raw)
To: Frank Wunderlich, linux-mediatek
Cc: Frank Wunderlich, Matthias Brugger, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Daniel Golle, linux-kernel,
linux-arm-kernel, Eric Woudstra
Il 25/10/23 19:08, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Bananapi R3 has a Power socket entended for using external SATA drives.
> This Socket is off by default but can be switched with gpio 8.
>
> Add an overlay to activate it.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> v2:
> - rebase on the patch "add dtbs with applied overlays for bpi-r3"
> - add sata-overlay to the full dtbs
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 13 +++++--
> .../mt7986a-bananapi-bpi-r3-sata.dtso | 39 +++++++++++++++++++
> 2 files changed, 48 insertions(+), 4 deletions(-)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index 24eeba0703ce..c3b236a47513 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -13,26 +13,31 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sata.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
The devicetree overlays make no sense without a base devicetree, right? :-)
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo <-- makes no sense!
Check how it's done in freescale (nxp) and renesas... and there's also one instance
of overlays in qualcomm.
In short:
- Remove all of the dtb-$(CONFIG_ARCH_MEDIATEK) += blah.dtbo
- xxxx-dtbs:= blah.dtb blah-overlay.dtbo, dtb-$(CONFIG_ARCH_MEDIATEK) += xxxx.dtb
is correct.
> mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := \
> mt7986a-bananapi-bpi-r3.dtb \
> mt7986a-bananapi-bpi-r3-emmc.dtbo \
> - mt7986a-bananapi-bpi-r3-nand.dtbo
> + mt7986a-bananapi-bpi-r3-nand.dtbo \
> + mt7986a-bananapi-bpi-r3-sata.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
> mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := \
> mt7986a-bananapi-bpi-r3.dtb \
> mt7986a-bananapi-bpi-r3-emmc.dtbo \
> - mt7986a-bananapi-bpi-r3-nor.dtbo
> + mt7986a-bananapi-bpi-r3-nor.dtbo \
> + mt7986a-bananapi-bpi-r3-sata.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
> mt7986a-bananapi-bpi-r3-sd-nand-dtbs := \
> mt7986a-bananapi-bpi-r3.dtb \
> mt7986a-bananapi-bpi-r3-sd.dtbo \
> - mt7986a-bananapi-bpi-r3-nand.dtbo
> + mt7986a-bananapi-bpi-r3-nand.dtbo \
> + mt7986a-bananapi-bpi-r3-sata.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
> mt7986a-bananapi-bpi-r3-sd-nor-dtbs := \
> mt7986a-bananapi-bpi-r3.dtb \
> mt7986a-bananapi-bpi-r3-sd.dtbo \
> - mt7986a-bananapi-bpi-r3-nor.dtbo
> + mt7986a-bananapi-bpi-r3-nor.dtbo \
> + mt7986a-bananapi-bpi-r3-sata.dtbo
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
>
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso
> new file mode 100644
> index 000000000000..6ab06813412a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2021 MediaTek Inc.
> + * Author: Frank Wunderlich <frank-w@public-files.de>
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + compatible = "bananapi,bpi-r3", "mediatek,mt7986a";
> +
> + fragment@0 {
> + target-path = "/";
> + __overlay__ {
This could be easier, I think.
&{/} {
reg_sata12v: regulator-sata12v {
....
};
something_else: something-else { ... };
};
Regards,
Angelo
> + reg_sata12v: regulator-sata12v {
> + compatible = "regulator-fixed";
> + regulator-name = "sata12v";
> + regulator-min-microvolt = <12000000>;
> + regulator-max-microvolt = <12000000>;
> + gpio = <&pio 8 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + regulator-always-on;
> + };
> +
> + reg_sata5v: regulator-sata5v {
> + compatible = "regulator-fixed";
> + regulator-name = "sata5v";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + vin-supply = <®_sata12v>;
> + };
> + };
> + };
> +};
> +
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 5/5] arm64: dts: mt7986: add overlay for SATA power socket on BPI-R3
2023-10-26 8:03 ` AngeloGioacchino Del Regno
@ 2023-10-26 9:01 ` Frank Wunderlich
0 siblings, 0 replies; 14+ messages in thread
From: Frank Wunderlich @ 2023-10-26 9:01 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Frank Wunderlich, linux-mediatek
Cc: Matthias Brugger, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Daniel Golle, linux-kernel, linux-arm-kernel, Eric Woudstra
Hi Angelo
Bpi-r3 can boot with only 1 mmc device and 1 spi-device. Some users may not use the sata overlay. Using overlays in fit have the advantage to probe hardware in uboot and load the required overlays instead of loading a full dtb.
Am 26. Oktober 2023 10:03:08 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>:
>Il 25/10/23 19:08, Frank Wunderlich ha scritto:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> Bananapi R3 has a Power socket entended for using external SATA drives.
>> This Socket is off by default but can be switched with gpio 8.
>>
>> Add an overlay to activate it.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> ---
>> v2:
>> - rebase on the patch "add dtbs with applied overlays for bpi-r3"
>> - add sata-overlay to the full dtbs
>> ---
>> arch/arm64/boot/dts/mediatek/Makefile | 13 +++++--
>> .../mt7986a-bananapi-bpi-r3-sata.dtso | 39 +++++++++++++++++++
>> 2 files changed, 48 insertions(+), 4 deletions(-)
>> create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
>> index 24eeba0703ce..c3b236a47513 100644
>> --- a/arch/arm64/boot/dts/mediatek/Makefile
>> +++ b/arch/arm64/boot/dts/mediatek/Makefile
>> @@ -13,26 +13,31 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sata.dtbo
>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
>
>The devicetree overlays make no sense without a base devicetree, right? :-)
The base-dtb is needed,but i prefer have 1 base-dt and overlays (in 1 fit image dynamically load in uboot) instead of 4+ full dtbs,but some people prefer using the full dtbs.
>dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo <-- makes no sense!
Depends on users preference :) full dtb is easier to load,but less flexible.
>Check how it's done in freescale (nxp) and renesas... and there's also one instance
>of overlays in qualcomm.
>In short:
> - Remove all of the dtb-$(CONFIG_ARCH_MEDIATEK) += blah.dtbo
> - xxxx-dtbs:= blah.dtb blah-overlay.dtbo, dtb-$(CONFIG_ARCH_MEDIATEK) += xxxx.dtb
> is correct.
That will break my current way :( openwrt uses same.
>> mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := \
>> mt7986a-bananapi-bpi-r3.dtb \
>> mt7986a-bananapi-bpi-r3-emmc.dtbo \
>> - mt7986a-bananapi-bpi-r3-nand.dtbo
>> + mt7986a-bananapi-bpi-r3-nand.dtbo \
>> + mt7986a-bananapi-bpi-r3-sata.dtbo
>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
>> mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := \
>> mt7986a-bananapi-bpi-r3.dtb \
>> mt7986a-bananapi-bpi-r3-emmc.dtbo \
>> - mt7986a-bananapi-bpi-r3-nor.dtbo
>> + mt7986a-bananapi-bpi-r3-nor.dtbo \
>> + mt7986a-bananapi-bpi-r3-sata.dtbo
>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
>> mt7986a-bananapi-bpi-r3-sd-nand-dtbs := \
>> mt7986a-bananapi-bpi-r3.dtb \
>> mt7986a-bananapi-bpi-r3-sd.dtbo \
>> - mt7986a-bananapi-bpi-r3-nand.dtbo
>> + mt7986a-bananapi-bpi-r3-nand.dtbo \
>> + mt7986a-bananapi-bpi-r3-sata.dtbo
>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
>> mt7986a-bananapi-bpi-r3-sd-nor-dtbs := \
>> mt7986a-bananapi-bpi-r3.dtb \
>> mt7986a-bananapi-bpi-r3-sd.dtbo \
>> - mt7986a-bananapi-bpi-r3-nor.dtbo
>> + mt7986a-bananapi-bpi-r3-nor.dtbo \
>> + mt7986a-bananapi-bpi-r3-sata.dtbo
>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso
>> new file mode 100644
>> index 000000000000..6ab06813412a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso
>> @@ -0,0 +1,39 @@
>> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> +/*
>> + * Copyright (C) 2021 MediaTek Inc.
>> + * Author: Frank Wunderlich <frank-w@public-files.de>
>> + */
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +/ {
>> + compatible = "bananapi,bpi-r3", "mediatek,mt7986a";
>> +
>> + fragment@0 {
>> + target-path = "/";
>> + __overlay__ {
>
>This could be easier, I think.
>
>&{/} {
>
> reg_sata12v: regulator-sata12v {
> ....
> };
>
> something_else: something-else { ... };
>};
Need to try this.
>Regards,
>Angelo
>
>> + reg_sata12v: regulator-sata12v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "sata12v";
>> + regulator-min-microvolt = <12000000>;
>> + regulator-max-microvolt = <12000000>;
>> + gpio = <&pio 8 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + regulator-always-on;
>> + };
>> +
>> + reg_sata5v: regulator-sata5v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "sata5v";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + regulator-always-on;
>> + vin-supply = <®_sata12v>;
>> + };
>> + };
>> + };
>> +};
>> +
>
regards Frank
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread