From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH v2 0/8] staging: vc04: Drop custom logging based on printk
Date: Wed, 25 Oct 2023 13:01:39 +0200 [thread overview]
Message-ID: <2023102528-anemia-cacti-9622@gregkh> (raw)
In-Reply-To: <20231024114428.443528-1-umang.jain@ideasonboard.com>
On Tue, Oct 24, 2023 at 07:44:20AM -0400, Umang Jain wrote:
> Hello,
>
> This series address the discussion on [1], i.e. removing the printk
> based logging mechanism and migrate it use dynamic debug.
>
> Patch 1/8 and 2/8 are prep-up patch to pass struct device pointers
> so that we can use dev_dbg() in those functions.
>
> Patch 3/8 targets migration of vchiq_log_error() to use dynamic debug
> Patch 4/8 targets migration of vchiq_log_warning() to use dynamic debug
> Patch 5/8 targets rename of vchiq_log_info() to vchiq_log_debug() and
> migration to use dynamic debug.
> Patch 6/8 targets mirgration of vchiq_log_trace to use dynamic debug.
>
> Patch 7/8 drops a unused macro.
> Patch 8/8 is log levels remnants cleanup along with debugfs entries.
>
> Changes in v2:
> - Address feedback from v1, added 1/8, 2/8 as new patches
> Hence, Remove pr_*() based logging in few cases
> - Cleanup debugfs log entries (8/8) and update TODO list
> - Fixed bugs where NULL deference was happening due to unitialised
> pointers.
Much better, thanks!
But I don't think you're done here, why not just use "real" dev_dbg()
and the like calls instead of your wrapper #defines? What is that
helping with? You now have full debug information so the additional
field should not be needed anymore, right?
I'll take this for now, as any future changes can come on top of this.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-10-25 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 11:44 [PATCH v2 0/8] staging: vc04: Drop custom logging based on printk Umang Jain
2023-10-24 11:44 ` [PATCH v2 1/8] staging: vc04_services: Pass struct device to vchiq_log_dump_mem() Umang Jain
2023-10-24 11:44 ` [PATCH v2 2/8] staging: vc04_services: Pass struct device to vchiq_init_slots() Umang Jain
2023-10-24 11:44 ` [PATCH v2 3/8] staging: vc04: Convert vchiq_log_error() to use dynamic debug Umang Jain
2023-10-24 11:44 ` [PATCH v2 4/8] staging: vc04: Convert vchiq_log_warning() " Umang Jain
2023-10-24 11:44 ` [PATCH v2 5/8] staging: vc04: Convert(and rename) vchiq_log_info() " Umang Jain
2023-10-24 11:44 ` [PATCH v2 6/8] staging: vc04: Convert vchiq_log_trace() " Umang Jain
2023-10-24 11:44 ` [PATCH v2 7/8] staging: vc04_services: Drop VCHIQ_LOG_PREFIX macro Umang Jain
2023-10-24 11:44 ` [PATCH v2 8/8] staging: vc04_services: Drop log level mechanisms Umang Jain
2023-10-25 11:03 ` Greg Kroah-Hartman
2023-10-25 11:01 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102528-anemia-cacti-9622@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=error27@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).