From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0722AC0032E for ; Wed, 25 Oct 2023 11:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R/BlaYSSVRrM+CeC+769gYipV5s68mdt/9Kjh0ka1Ac=; b=O2iqQXX68ZmTZx 8+OiyFU7EvvytzgMxzazmJAgaFI8napImdCgS6BDM3pCWuNrheG8eZO5XtpnEHx1PKwxwGwi1tf6d VB2mh5gLynUS/wX1hFW1D+Gt/dGqVJ2F2jUuHjWWYe2zXkx4AM8LF2jw9Uv6h8+H8OnC4XF+dY+qT QTN3AybHJSna7r20CMzlHZoAJaxfKf8TlAaY4CDg0lBYqP2ObEGMZSL4IeEVrCiFnT66tdKAM119e fxqUrtEIF6+072YgFKSs7OHwBhGJFKrScdJeBcp4Reur5FDeQ7RHzs0pUWGp9ECV4V0zdnJDjea4L DHdCFZ6AacR4Bisg/xmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvbe1-00C8be-1Y; Wed, 25 Oct 2023 11:01:49 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvbdw-00C8aA-2q; Wed, 25 Oct 2023 11:01:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 3B2E1B82E2F; Wed, 25 Oct 2023 11:01:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B696C433C8; Wed, 25 Oct 2023 11:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698231701; bh=1YD3YCRTlBaAan1td1ghKoOBV0EAf0BRMMakToRGbDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hjFI1AgSt44fevaGYMn9mN2I1fFdqCdoSlutapOY7iIpP/BbCv8GmsDTtR7zoV3Dh Sno92lOhbsArxe3JVyLszriR3G2W/lqyqo8OTu2j/H9sgR7WnfP7soKfAktzz48A8E PkxyvvRgyhiEr/iruERyKuZYEMaPfe6pBV2oMX9o= Date: Wed, 25 Oct 2023 13:01:39 +0200 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Phil Elwell Subject: Re: [PATCH v2 0/8] staging: vc04: Drop custom logging based on printk Message-ID: <2023102528-anemia-cacti-9622@gregkh> References: <20231024114428.443528-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231024114428.443528-1-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_040145_085175_619ECD52 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 24, 2023 at 07:44:20AM -0400, Umang Jain wrote: > Hello, > > This series address the discussion on [1], i.e. removing the printk > based logging mechanism and migrate it use dynamic debug. > > Patch 1/8 and 2/8 are prep-up patch to pass struct device pointers > so that we can use dev_dbg() in those functions. > > Patch 3/8 targets migration of vchiq_log_error() to use dynamic debug > Patch 4/8 targets migration of vchiq_log_warning() to use dynamic debug > Patch 5/8 targets rename of vchiq_log_info() to vchiq_log_debug() and > migration to use dynamic debug. > Patch 6/8 targets mirgration of vchiq_log_trace to use dynamic debug. > > Patch 7/8 drops a unused macro. > Patch 8/8 is log levels remnants cleanup along with debugfs entries. > > Changes in v2: > - Address feedback from v1, added 1/8, 2/8 as new patches > Hence, Remove pr_*() based logging in few cases > - Cleanup debugfs log entries (8/8) and update TODO list > - Fixed bugs where NULL deference was happening due to unitialised > pointers. Much better, thanks! But I don't think you're done here, why not just use "real" dev_dbg() and the like calls instead of your wrapper #defines? What is that helping with? You now have full debug information so the additional field should not be needed anymore, right? I'll take this for now, as any future changes can come on top of this. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel