From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A079C25B47 for ; Wed, 25 Oct 2023 11:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OacwwKgtY4yAxKoFPGm/BADpQhgkOyQphEwdA9Yn5nQ=; b=MrJkAKXh+3hgem M369U+D8oFec0JVATooEBSbE+F1R/VvQr5/+Qmauy1Ao7k6VyIZGJr/8/aSDT4QwI4I6QKAZDs7w4 Mhyu4OAZ5y93FHHDKeFJ6ThbedzRAXS8tq9ELxrEHpW34ODLZw02J4mxX7mXNfPs+kdijHpPN3v+i GNE6f7pTPocHYjjwPJ64EjX1ldjbF8+3q9htSDphjtttkJJSWleVzuQrRVdYjsG91mRRVek5bkkI/ T3WjDQg9RfHcK3r7VIgoEQ2l+P8IWkp0Qdj2XwgP/YH6v8wzEEuuRomE/fcpPPPm6yFmGOiVF28yN XIVTZqHapxLV9dqqOV+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvbfh-00C8qa-3C; Wed, 25 Oct 2023 11:03:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvbfe-00C8pZ-1g; Wed, 25 Oct 2023 11:03:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BD501619EC; Wed, 25 Oct 2023 11:03:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E1E7C433C8; Wed, 25 Oct 2023 11:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698231809; bh=Aa57aTVELvtasTdJr4xDdJMqfS+s+yVwDJlL6+u2dCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EKyxDa2lU2R6ezw0pLmooF8XUeITjd9FUERmZEgBIrS3865haVuWekmDn3/2Y5jLi +TuHGnXmO68Num9MxWK8dddAuOs+nsJJhnq8HrcVIEbMblnVbD/4cCiLEqgRgYY+14 vxRbDJn2wx2g8GpraSviv+4/UjzFyK1sB0AHem5g= Date: Wed, 25 Oct 2023 13:03:26 +0200 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Phil Elwell Subject: Re: [PATCH v2 8/8] staging: vc04_services: Drop log level mechanisms Message-ID: <2023102543-chapter-spending-4978@gregkh> References: <20231024114428.443528-1-umang.jain@ideasonboard.com> <20231024114428.443528-9-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231024114428.443528-9-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_040330_600054_16EB42CD X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 24, 2023 at 07:44:28AM -0400, Umang Jain wrote: > Drop the log level remnants since the logs are now ported to use > dynamic logging. Drop macros, externs and global variables which > were used in the log level mechanisms along with debugfs log entries. > > Update the drivers/staging/vc04_services/interface/TODO list as well. > > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/interface/TODO | 5 - > .../interface/vchiq_arm/vchiq_arm.c | 4 - > .../interface/vchiq_arm/vchiq_arm.h | 3 - > .../interface/vchiq_arm/vchiq_core.c | 87 ++++++--------- > .../interface/vchiq_arm/vchiq_core.h | 11 -- > .../interface/vchiq_arm/vchiq_debugfs.c | 103 ------------------ > 6 files changed, 33 insertions(+), 180 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > index 6d9d4a800aa7..05eb5140d096 100644 > --- a/drivers/staging/vc04_services/interface/TODO > +++ b/drivers/staging/vc04_services/interface/TODO > @@ -23,11 +23,6 @@ should properly handle a module unload. This also includes that all > resources must be freed (kthreads, debugfs entries, ...) and global > variables avoided. > > -* Cleanup logging mechanism > - > -The driver should probably be using the standard kernel logging mechanisms > -such as dev_info, dev_dbg, and friends. > - > * Documentation > > A short top-down description of this driver's architecture (function of I dropped this chunk, and the changlog description of it, as I'm not fully convinced that this portion is done yet. You did the hard work, I think the remaining tiny bit can probably be scripted. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel