From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 418A1C4167D for ; Sun, 29 Oct 2023 16:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IgzwK4xAq1FISWrDD7EnNGN7xpAkXJV/l3jo/4NWlS8=; b=HyrMWnq6U9EReZ mdMPPpM3YXprzlNBE9fFy1V1Ki3pcH1RE4wAmF72V4S5LoeKPrE0eQAjVvoZeLvRnROxC4RY3xPFO me5IUjvXNiyUZho+uO3uJg7GfYuN8kB+aoHj2x1fpvAWIaqtYXjcOTx3dH0iOVH5XP9EO/JDH/CI8 R+8CMVDrtq+/s/XCHHvhbEq+Cb7HDe6jYKVMtvquCcAPQDb5luiqwoZMFRUa2mUHCC6c/TU+w+uzA CZdtfNiohUD/ow43R3jNJhm7Bn5YlJFzC2CUUWM6CEIh0PQ61r7uhQEIP7TZvfFF9MuLRWKxI7Iyg qz9jPJ2Mv4J9djanhEvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qx8Te-001tiU-2e; Sun, 29 Oct 2023 16:17:26 +0000 Received: from www.linux-watchdog.org ([185.87.125.42]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qx8Tc-001ti6-1N for linux-arm-kernel@lists.infradead.org; Sun, 29 Oct 2023 16:17:25 +0000 Received: by www.linux-watchdog.org (Postfix, from userid 500) id 734AC40A00; Sun, 29 Oct 2023 17:10:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 www.linux-watchdog.org 734AC40A00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-watchdog.org; s=odk20180602; t=1698595856; bh=K01uBZjOi6MJBggCB1PXyOP/1H5GeP1Q9SQyHlNOR9o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FiwAXl6cid4H//9jwshG3o0P+lziIRrfSk7HMNHElnfRGqIJ+kEj82SF9MWkReqmD lRxDl09YSMlRRd3BVsCCAICgp13QqRrE09MGmjrzTozlGeqxBYo9dVAO8awWOLFRcl Dtlti4dwJ76pOqmfT+yN8GyKNYaV+yDUn/QEmsVI= Date: Sun, 29 Oct 2023 17:10:56 +0100 From: Wim Van Sebroeck To: Guenter Roeck Cc: Darren Hart , linux-kernel@vger.kernel.org, Vanshidhar Konda , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH] sbsa_gwdt: Calculate timeout with 64-bit math Message-ID: <20231029161056.GB5887@www.linux-watchdog.org> References: <7d1713c5ffab19b0f3de796d82df19e8b1f340de.1695286124.git.darren@os.amperecomputing.com> <1fae4d2c-4bc7-f169-7b84-501674a82ee4@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1fae4d2c-4bc7-f169-7b84-501674a82ee4@roeck-us.net> User-Agent: Mutt/1.5.20 (2009-12-10) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231029_091724_614518_5E7F2EFE X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Guenter, > On 10/14/23 02:12, Darren Hart wrote: > >On Tue, Sep 26, 2023 at 05:45:13AM -0700, Guenter Roeck wrote: > >>On Thu, Sep 21, 2023 at 02:02:36AM -0700, Darren Hart wrote: > >>>Commit abd3ac7902fb ("watchdog: sbsa: Support architecture version 1") > >>>introduced new timer math for watchdog revision 1 with the 48 bit offset > >>>register. > >>> > >>>The gwdt->clk and timeout are u32, but the argument being calculated is > >>>u64. Without a cast, the compiler performs u32 operations, truncating > >>>intermediate steps, resulting in incorrect values. > >>> > >>>A watchdog revision 1 implementation with a gwdt->clk of 1GHz and a > >>>timeout of 600s writes 3647256576 to the one shot watchdog instead of > >>>300000000000, resulting in the watchdog firing in 3.6s instead of 600s. > >>> > >>>Force u64 math by casting the first argument (gwdt->clk) as a u64. Make > >>>the order of operations explicit with parenthesis. > >>> > >>>Fixes: abd3ac7902fb ("watchdog: sbsa: Support architecture version 1") > >>>Reported-by: Vanshidhar Konda > >>>Signed-off-by: Darren Hart > >>>Cc: Wim Van Sebroeck > >>>Cc: Guenter Roeck > >>>Cc: linux-watchdog@vger.kernel.org > >>>Cc: linux-kernel@vger.kernel.org > >>>Cc: linux-arm-kernel@lists.infradead.org > >>>Cc: # 5.14.x > >> > >>Reviewed-by: Guenter Roeck > > > >Guenter or Wim, I haven't seen this land in the RCs or in next yet. Have > >you already picked it up? Anything more needed from me? > > > >Thanks, > > > > Sorry, I am suffering from what I can only describe as a severe case of > maintainer/reviewer PTSD, and I have yet to find a way of dealing with that. I can imagine what it is like. And I do know that if you wouldn't have been there, that I would have allready stopped being a maintainer. So I hope you can find the right cooping mechanisms. I also had to work non-stop the last 4 to 5 weeks and it was hell. So I wish you all the best. PS: picking up all patches that have your review-by tag on it as we speack. Kind regards, Wim. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel