From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD790C4332F for ; Sun, 29 Oct 2023 12:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lQWajAL3PHeJ3VmyLw1Jdvja1fk38RBdU+D/iSaQiZ0=; b=WtQ4A1aaqP+w6S kKVJ14yh90iatH/CdRBkvXSiI14K/nTkw4jxWem/9mioFRfp2Hgcxyl/ZFuBfWINU7r50Nxgnq0nm Hby+ZRZc2z388RRT9MTLKZOtC1rLPISXaBRHI8F4wup92iEL5ArbL5oejoYazj6Y2UUDRcPYdg9zE SH2Nzhlmv6aP2dMtVOMeLBr/KPg/XdAfwGNDkZfM/rkmnL3Olunl6xTZvWSk3PL4TMhUoFIgPcIK/ 13eNoYSoJbAH5SesrFDqZsWpyNlB2Vip6uHXctff6SE+LrNMPUk9nteIdqx4KTKnbrHz0skSrIEte 0Tja8rbi6Sitd6muPS9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qx4cS-001iph-2v; Sun, 29 Oct 2023 12:10:16 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qx4cO-001ipJ-33 for linux-arm-kernel@lists.infradead.org; Sun, 29 Oct 2023 12:10:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 83352B80ADA; Sun, 29 Oct 2023 12:10:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF153C433C8; Sun, 29 Oct 2023 12:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698581408; bh=Tt2zBbYMPZAuRK60SLouG6hIoBx1BUwr3/PJQYhilQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DTJcwgTpcvNVi65l6K3LPvwFBNlhbcf85N51LlceLdolMoiwtQGiPq3oLQrjEtSRr UZpwqUZCJijXj/AXm2QdBq8sSiHFV8zPDzJ69kvN1NeIsl9OAuCnYTRTCz3kAx4xP/ IEekay5Z70j4Ct03QyuwStvWsumtnwCgArrs9nhk= Date: Sun, 29 Oct 2023 13:10:02 +0100 From: Greg Kroah-Hartman To: Krzysztof Kozlowski Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Thierry Reding , linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Alim Akhtar , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, kernel test robot , Stephen Rothwell Subject: Re: [PATCH] pwm: samsung: Document new member .channel in struct samsung_pwm_chip Message-ID: <2023102946-chain-resource-ae1d@gregkh> References: <20231012210228.1009473-2-u.kleine-koenig@pengutronix.de> <169720375693.285367.8034783567173304872.b4-ty@gmail.com> <20231013172750.nxcw2ftihpemnymx@pengutronix.de> <20231024145524.7qkzrrdm6zg5hfji@pengutronix.de> <20231024164627.ejcqrtbhvohduvpg@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231029_051013_338708_4F6EEEBA X-CRM114-Status: GOOD ( 24.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 29, 2023 at 12:07:02PM +0100, Krzysztof Kozlowski wrote: > On 24/10/2023 18:46, Uwe Kleine-K=F6nig wrote: > > On Tue, Oct 24, 2023 at 04:58:22PM +0200, Krzysztof Kozlowski wrote: > >> On 24/10/2023 16:55, Uwe Kleine-K=F6nig wrote: > >>> Hello, > >>> > >>> On Fri, Oct 13, 2023 at 07:27:50PM +0200, Uwe Kleine-K=F6nig wrote: > >>>> On Fri, Oct 13, 2023 at 03:29:35PM +0200, Thierry Reding wrote: > >>>>> On Thu, 12 Oct 2023 23:02:29 +0200, Uwe Kleine-K=F6nig wrote: > >>>>>> Fixes: 4c9548d24c0d ("pwm: samsung: Put per-channel data into driv= er data") > >>>>> > >>>>> Applied, thanks! > >>>>> > >>>>> [1/1] pwm: samsung: Document new member .channel in struct samsung_= pwm_chip > >>>>> commit: 4bb36d126cb3147d6bbfd00242a5b846dacad595 > >>>> > >>>> You might want to change 4c9548d24c0d to e3fe982b2e4e now that you > >>>> rewrote your for-next branch. > >>> > >>> This is still open. I wonder there is no automated check that warns if > >>> there is a Fixes: line in next that doesn't refer to an ancestor. > >> > >> I am using Greg's/Stephen's scripts in commit hooks: > >> https://github.com/krzk/tools/blob/master/linux/git-hooks-post-commit > >> https://github.com/krzk/tools/blob/master/linux/verify_fixes.sh > > = > > Skimming throud the verify_fixes script I'd say the following addition > > to verify_fixes should do: > > = > > diff --git a/linux/verify_fixes.sh b/linux/verify_fixes.sh > > index f22384bb6bb8..12e73da82dd4 100755 > > --- a/linux/verify_fixes.sh > > +++ b/linux/verify_fixes.sh > > @@ -100,6 +100,13 @@ verify_fixes() > > continue > > fi > > = > > + if ! git merge-base --is-ancestor "$sha" "$c"; then > > + printf '%s%s\t\t- %s\n' "$commit_msg" "$fixes_msg" 'Target SHA sho= uld be an ancestor of your tree' > > + commit_msg=3D'' > > + error=3D1 > > + continue > > + fi > > + > > if [ "${#sha}" -lt 12 ]; then > > msg=3D"${msg:+${msg}${nl}}${tab}${tab}- SHA1 should be at least 12= digits long${nl}${tab}${tab} Can be fixed by setting core.abbrev to 12 (o= r more) or (for git v2.11${nl}${tab}${tab} or later) just making sure it i= s not set (or set to \"auto\")." > > fi > > = > = > Thanks Uwe for the snippet. I went further and it allowed to simplify > checking for commit in Linus' tree. > = > Cc, Greg, Stephen, > Maybe you will find it useful to update your scripts as well (I forked > from yours): > https://github.com/krzk/tools/commit/39d2c71a72f5d4f30d0752e45b9bcc09b75b= 5026 > = > https://github.com/krzk/tools/commit/0061331501fac2f4b24709adb0ec5cf267bc= b661#diff-0100377e067a4cd4cb89c0f0ae8732d3e814ed25e816a392bf2e0855a392adbcL= 11 Thanks, I've applied this to my tree, let's see how it works out. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel