From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A291C4332F for ; Tue, 31 Oct 2023 01:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=sEaY3VQc8qYqWSmNoBIlMen2Ruao6mar1Go5EfoFHKc=; b=YIVpyqQmlGD9zr jyDdwou7teA4aKj6LkCmiOJ9cSOctpSsoC19i+BAUfSNZasHnM04xPt/QdGGBnMTK85FGKFSbVhUe YpXCd6XhmqS20cJeVzD0lSbQats7dLbp97RvKKpHe62wi1D8mtJyaWKMkdppLaMjgSFH7NaXp1pAL FLRd2QzoOys3QbqOFweXz6FgQe4KcWbbhCLneUIpw/pIjCZsFLL+WPxsPb9KP1L4Daff9ldk7vC0X qh14nGZZxFKGtzl6HVXAItgnyPMxK1BtTGj6ffeu4i5RSwF/RBbqsUcK16i3x6qOBEKeZrv5lBr90 8doY9+IdfoqYH74/zGrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qxdfx-004MqS-0Z; Tue, 31 Oct 2023 01:36:13 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qxdfu-004Mq0-0d for linux-arm-kernel@lists.infradead.org; Tue, 31 Oct 2023 01:36:11 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1c9b95943beso46772285ad.1 for ; Mon, 30 Oct 2023 18:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698716168; x=1699320968; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qcTkR9pEn1ZeTff+u0rkADwaO0ETpeYsvQ+/OjWLa74=; b=k5QWEZ9Yq/5qlmSB/43f/W9Uc0xGH5FIBTRMDyNpQhlmwEUTFWYqnnwX0hutZRf5cf Rt6CfDCPBNBZpndSWpmcEZHO+iuCwTOlIQEpBCqPbIai/qL/7PGQmSr0M7w9bl5rf2Gh v9P6bVsKYVNJPLUYKqWIxTUHcy7u0eYtoOXNgMGcrylpGiDxi2hrrtCoQj5u2/qsr0z5 o/7ySKh4Aj0V8Rn4p4YI2WzelZqQbkGQNen6zhlXCEVtWr00KMuRUwajMIfmx2ywx7Zo SJwtZBcbaxpGQglmFfwek8ugi2HPhvMd7LvtNN823A2Vn7TkTfDu83MgPNBXW76hXjRn tJ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698716168; x=1699320968; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qcTkR9pEn1ZeTff+u0rkADwaO0ETpeYsvQ+/OjWLa74=; b=l4INbKaW0ZnJ6zrK8No02jlTh8puInRTecTg+h6jVy4g+9wnxdT+E5u/LL9VOhLNrE 31csx9s3S4g3qQRrqA/7TkyPcS0PMzMOBr/GMM7CUq0RL1A2if7orr7lytGfD2CbVj18 5pzO0ufEHicsaT2cFP1TD0/XaQoESf/JJptRwXvI7FMof0C/2YIrLQIeFxmcBnDLaCnl muS6DS7hxYvBYo8EJHqS11Cw9b7LXIHkwjuV6XvJj94naPVEXUn/UaDhezzd65QTmzG2 6vcpvWtyWbFddxMouE4fNwYn6obB7Tbvu/FCMsdUafoKd6SQeZM7HOVt4xPHrpM15MCK WQ1Q== X-Gm-Message-State: AOJu0YxseIrQ2aNTeKZz7dOpoqnGHzVd15lWZEiXXeZGLxlAdzHGTqsf kLCx7PCVsnbqGbgXj5DmmmQ= X-Google-Smtp-Source: AGHT+IHkspUMEv8LeL75cvf2xiTNEpYmr0TDCG0yBmk8R32koQhxVnIaYCUoKJmiSXgCIt3IftMazg== X-Received: by 2002:a17:902:c40b:b0:1cc:3a8a:f197 with SMTP id k11-20020a170902c40b00b001cc3a8af197mr9011002plk.20.1698716168667; Mon, 30 Oct 2023 18:36:08 -0700 (PDT) Received: from localhost.localdomain ([58.48.52.254]) by smtp.gmail.com with ESMTPSA id o12-20020a170902d4cc00b001c0ce518e98sm133228plg.224.2023.10.30.18.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 18:36:08 -0700 (PDT) From: "xinglong.yang" X-Google-Original-From: "xinglong.yang" To: xinglong.yang@cixtech.com, sudeep.holla@arm.com, cristian.marussi@arm.com Cc: linux-arm-kernel@lists.infradead.org Subject: [PATCH] firmware: arm_scmi:: Add opinion for init fastchannel Date: Tue, 31 Oct 2023 09:36:01 +0800 Message-ID: <20231031013601.925009-1-xinglong.yang@cixtech.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231030_183610_235096_8907E20C X-CRM114-Status: GOOD ( 11.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fastchannel may not be supported by the platform. It is not need to init the fastchannel if the fastchannel is not supported. Signed-off-by: xinglong.yang Change-Id: Id73ab1f37d5a3726243f97beb40c5b2239d65727 --- drivers/firmware/arm_scmi/perf.c | 38 ++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c index ecf5c4de851b..26fa71e2aff8 100644 --- a/drivers/firmware/arm_scmi/perf.c +++ b/drivers/firmware/arm_scmi/perf.c @@ -526,32 +526,36 @@ static int scmi_perf_level_limits_notify(const struct scmi_protocol_handle *ph, } static void scmi_perf_domain_init_fc(const struct scmi_protocol_handle *ph, - u32 domain, struct scmi_fc_info **p_fc) + u32 domain, struct perf_dom_info* dom) { + struct scmi_fc_info **p_fc = &dom->fc_info; struct scmi_fc_info *fc; fc = devm_kcalloc(ph->dev, PERF_FC_MAX, sizeof(*fc), GFP_KERNEL); if (!fc) return; - ph->hops->fastchannel_init(ph, PERF_DESCRIBE_FASTCHANNEL, - PERF_LEVEL_SET, 4, domain, - &fc[PERF_FC_LEVEL].set_addr, - &fc[PERF_FC_LEVEL].set_db); + if (dom->set_perf) { + ph->hops->fastchannel_init(ph, PERF_DESCRIBE_FASTCHANNEL, + PERF_LEVEL_SET, 4, domain, + &fc[PERF_FC_LEVEL].set_addr, + &fc[PERF_FC_LEVEL].set_db); - ph->hops->fastchannel_init(ph, PERF_DESCRIBE_FASTCHANNEL, - PERF_LEVEL_GET, 4, domain, - &fc[PERF_FC_LEVEL].get_addr, NULL); - - ph->hops->fastchannel_init(ph, PERF_DESCRIBE_FASTCHANNEL, - PERF_LIMITS_SET, 8, domain, - &fc[PERF_FC_LIMIT].set_addr, - &fc[PERF_FC_LIMIT].set_db); + ph->hops->fastchannel_init(ph, PERF_DESCRIBE_FASTCHANNEL, + PERF_LEVEL_GET, 4, domain, + &fc[PERF_FC_LEVEL].get_addr, NULL); + } - ph->hops->fastchannel_init(ph, PERF_DESCRIBE_FASTCHANNEL, - PERF_LIMITS_GET, 8, domain, - &fc[PERF_FC_LIMIT].get_addr, NULL); + if (dom->set_limits) { + ph->hops->fastchannel_init(ph, PERF_DESCRIBE_FASTCHANNEL, + PERF_LIMITS_SET, 8, domain, + &fc[PERF_FC_LIMIT].set_addr, + &fc[PERF_FC_LIMIT].set_db); + ph->hops->fastchannel_init(ph, PERF_DESCRIBE_FASTCHANNEL, + PERF_LIMITS_GET, 8, domain, + &fc[PERF_FC_LIMIT].get_addr, NULL); + } *p_fc = fc; } @@ -835,7 +839,7 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph) scmi_perf_describe_levels_get(ph, domain, dom); if (dom->perf_fastchannels) - scmi_perf_domain_init_fc(ph, domain, &dom->fc_info); + scmi_perf_domain_init_fc(ph, domain, dom); } pinfo->version = version; -- 2.42.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel