From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9DF0C4332F for ; Wed, 1 Nov 2023 08:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lNoPA4v+8DYV5WJECUBzQVeUAZOqMkmOJjfSsKQHv7E=; b=LawqZyj7tTrhms gBOHM0tuM9jcvwEWe2nYQC3++LLJN950mrOUGS4po3Gk1VOdhusLD0r/6PYFet6HrSxjNriVridZS YVGp2LvFB0w/3JRvSCMGODpQvTNOuoPjIolposK2Y8XyCn/E1piceY+zIqRW8d0mX5OM6OqSZFZ08 oM0EkbQafr9HjGJNZNnk4tahay2W/ZI2A6af/4Ma02EOfXpjQboYtjZ+JtI9Q1QEqY7CgiHJCP0fk KFKjp1qXiJB4lMFf8SSaz4GjOhs1IjPCshORLiy/Lc4aBGZ7FDii3Matj4aVnYY1Q/cWgqE9ySqbI szM6YQtM7Uq+7iuwHl2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qy6Pz-006sBB-1E; Wed, 01 Nov 2023 08:17:39 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qy6Pw-006sAp-1h for linux-arm-kernel@lists.infradead.org; Wed, 01 Nov 2023 08:17:37 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1cc3542e328so26755625ad.1 for ; Wed, 01 Nov 2023 01:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698826654; x=1699431454; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AScPjIzL2IRVVNBJtQbhX+2QHkK1rr3R5KLOy9omBhE=; b=ljUimPA8sJoAOfLjJZouKen+gULhmeb8EOZssxOprfR5cIcNynY1C1/WPl5Xlio+Zu zmQBBKhqPoYQ/sw42zurFRHNQmWUrIfJ3K5Cz3O5ZnLhyC6ah1tKhpKFF1la7X5JITBu nZDu1KrSbHF8Gw1KTzLaL+oggwcxs7OXtqq4Z4ngRTICOwRUQhouWDuDdOUKMd+1yA8h ZJcOEKfTOK5hYdZJ0CI+0WXgWW/m9MRsAbnzdYb6EpthkCxPTDY5KiGHgv8VbME2ZcdR pbG8ySDTu3E4FXyx4+L1wn2Coi7AV8nZNROqt6CTJRHAcVn1KjP1bsi0ET+xy8vSCZON 5VpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698826654; x=1699431454; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AScPjIzL2IRVVNBJtQbhX+2QHkK1rr3R5KLOy9omBhE=; b=f8UGE31m/XRHUg2Uog16Xxjnrv4TGNsnFECcDtsrCniQBR+SuxitkF7YYmeYaDjbh/ VdMFEFAPM/5W35O7UBqGv8qJoOQBCZFzfZ9ZSFn5Fx+IWjs6m222Oi1h4fs73z0+QoGW wCBdHP5Hrv7l3c5LPbBdE/1Visz9+Ey8dyXzimVhPzCt2ZnIsJArIxpOTY9sTdiRI6EB y5pdAJyWF83s7vmFOiHZ/PFMv/QZR76DtTm1ty/fw+PKjcLGAlOhgDskoS9A4hs7bNRw rZIZG+yOwRAVw6IppPBi/lbP+2lzprdndFVZtHt91uazDOc7ybkVSQcaCRhrKMk2Y5sd Tgdw== X-Gm-Message-State: AOJu0YyqSliSUjrKmW9W6EH+nfuCbizW4YTfO3NV8WR/uCfyTaTSVMjC qMZJSqflnbtgpRel2scQiRUaYp82ZSw= X-Google-Smtp-Source: AGHT+IESNcBVvfcEaGguSxKxC5k+YshPdi577IBqqLqnM76a4kpm+uohN4gS5J2sFq7KjgixfPD1hQ== X-Received: by 2002:a17:902:f94f:b0:1cc:3be6:b714 with SMTP id kx15-20020a170902f94f00b001cc3be6b714mr8327141plb.23.1698826654202; Wed, 01 Nov 2023 01:17:34 -0700 (PDT) Received: from localhost.localdomain ([58.48.52.254]) by smtp.gmail.com with ESMTPSA id e12-20020a170902d38c00b001ae0152d280sm819113pld.193.2023.11.01.01.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 01:17:33 -0700 (PDT) From: "xinglong.yang" X-Google-Original-From: "xinglong.yang" To: xinglong.yang@cixtech.com, sudeep.holla@arm.com, cristian.marussi@arm.com Cc: linux-arm-kernel@lists.infradead.org Subject: [PATCH] firmware: arm_scmi: Remove inappropriate error log. Date: Wed, 1 Nov 2023 16:17:26 +0800 Message-ID: <20231101081726.1163042-1-xinglong.yang@cixtech.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231101_011736_564657_7398103B X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The platform may not support fastchannel, but this is a legal operation. -Before this patch, when the platform not support fastchannel, goto err_xfer will print "Failed to ...". This log is misleading. -With this patch, when the fastchannel is not been supported, the "Failed to ..." log will be skipped. Signed-off-by: xinglong.yang --- drivers/firmware/arm_scmi/driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index b5957cc12fee..2b990e50c8a5 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1642,7 +1642,10 @@ scmi_common_fastchannel_init(const struct scmi_protocol_handle *ph, * fastchannels at all. */ ret = ph->xops->do_xfer(ph, t); - if (ret) + if (ret == -EOPNOTSUPP) { + ph->xops->xfer_put(ph, t); + goto return_normal; + } else if (ret) goto err_xfer; resp = t->rx.buf; @@ -1695,6 +1698,7 @@ scmi_common_fastchannel_init(const struct scmi_protocol_handle *ph, "Using valid FC for protocol %X [MSG_ID:%u / RES_ID:%u]\n", pi->proto->id, message_id, domain); +return_normal: return; err_db_mem: -- 2.42.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel