From: Bjorn Helgaas <helgaas@kernel.org>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: "Serge Semin" <fancer.lancer@gmail.com>,
"Niklas Cassel" <nks@flawful.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Simon Xue" <xxm@rock-chips.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: PCI: dwc: rockchip: Add optional dma interrupts
Date: Wed, 1 Nov 2023 17:23:28 -0500 [thread overview]
Message-ID: <20231101222328.GA101333@bhelgaas> (raw)
In-Reply-To: <ZUEiY5i7DUWThhNX@x1-carbon>
On Tue, Oct 31, 2023 at 03:51:03PM +0000, Niklas Cassel wrote:
> On Tue, Oct 31, 2023 at 04:10:17AM +0300, Serge Semin wrote:
> > On Fri, Oct 27, 2023 at 05:51:14PM +0200, Niklas Cassel wrote:
> > > However, e.g. rk3568 only has one channel for reads and one for writes.
> > > (Now this SoC doesn't have dedicated IRQs for the eDMA, but let's pretend
> > > that it did.)
> > >
> > > So for rk3568, it would then instead be:
> > > dma0: wr0
> > > dma1: rd0
> > > dma2: <unused>
> > > dma3: <unused>
> >
> > rk3568 doesn't have IRQs supplied in a normal way, as separate
> > signals. Instead they are combined in the 'sys' IRQ. So you should
> > define the IRQs constraint being device-specific by using for example
> > the "allOf: if-else" pattern.
>
> Thank you for your review comment.
>
> I agree. Will fix this in next version.
When you do, would you mind capitalizing "ATU", "DMA", etc in your
subject lines, commit logs, comments, etc? Then it'll be more obvious
that these aren't ordinary English words.
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-01 22:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231027145422.40265-1-nks@flawful.org>
[not found] ` <20231027145422.40265-2-nks@flawful.org>
[not found] ` <CAL_JsqJh6aJb7_qsVnVNEABBg2utf0FPN+qYyOfsF2dAfZpd0w@mail.gmail.com>
[not found] ` <ZTvh51PGCBhSjURY@x1-carbon>
2023-10-27 17:03 ` [PATCH v3 1/6] dt-bindings: PCI: dwc: rockchip: Add mandatory atu reg Rob Herring
2023-10-28 12:11 ` Niklas Cassel
2023-10-30 17:39 ` Rob Herring
2023-10-27 17:07 ` Heiko Stübner
[not found] ` <20231027145422.40265-3-nks@flawful.org>
2023-10-30 17:40 ` [PATCH v3 2/6] dt-bindings: PCI: dwc: rockchip: Add optional dma interrupts Rob Herring
2023-10-31 1:10 ` Serge Semin
2023-10-31 15:51 ` Niklas Cassel
2023-11-01 22:23 ` Bjorn Helgaas [this message]
[not found] ` <20231027145422.40265-4-nks@flawful.org>
2023-10-31 1:14 ` [PATCH v3 3/6] arm64: dts: rockchip: drop unused properties num-{ib,ob}-windows Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101222328.GA101333@bhelgaas \
--to=helgaas@kernel.org \
--cc=Niklas.Cassel@wdc.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=nks@flawful.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox