From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C95EC4332F for ; Thu, 2 Nov 2023 07:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=EEIF/tSTbDSpBb+ocvV7aeGOCvAA4CWEBh2f7UkqX84=; b=hxfTr9BPLN5LSn VXRlOetrqOTOiNK/5955JxhZ6S9H2vk5F02rvlYDgqAJd6ocmhV8RBuMcWqg9Bs4T/YI4XzxlhK/h HWWbIYHQlSOhV3uAtQkxAQHJtuwWT7LCQ4bqLTQLk2Ac44Lcu34P2rboQUkFB+J/3JfUNsBIzeS9G KEpC3IdBOgHcGKbKHq9Kpmw5ES2DZPCUPthfJLy72BSxplC4VHmJCK/jK+fyWpo0i8tWqx+rrPwxx 4HrXbg5uM88EBvgy5vrEg63UON6ybpZF576VGt+AO7ZYWRI8l97ddMhTkddj1QuDJH+GvOB7pYZNe RgWB4EZkwMyPd0O74P2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qySbg-008w7z-1n; Thu, 02 Nov 2023 07:59:12 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qySbb-008w7b-1o for linux-arm-kernel@lists.infradead.org; Thu, 02 Nov 2023 07:59:10 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-694ed847889so669802b3a.2 for ; Thu, 02 Nov 2023 00:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698911946; x=1699516746; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=j1wvnB3eDJn3rIhx1k3Y6cH10QBrnZBlhpmsJro00Tk=; b=L1Xf48m9lNE5DwLkRIj7y1ZjCrdl3SfoIpBiSfxNWLjwLbxO5hw6FyNFaB7rYMhpJR V+STW9tALUzi7HGnpLhh8kYD7nORAx2ovar61KTbAjNrkaEuVXaZAwE709HEk86i4gEX EpbZffh3i5Aoz3R+wtzA1NJQWRylGktXXad7ygVkoMxBMzeluK/d40IypfsLvdwusZtj zDpKj7W6UaAL6x3H6oL7FcXA2E/SEvBwvHexnGxWdhjIUxES7X4WxEELJFiYGFZJaITj 8BgaZZfMo6p1uh7xnMVdkPKa8MgOQEmq0ZNDNBMTu6cXwun9I0DjrUNW6hT0G4hjmsmU n93A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698911946; x=1699516746; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j1wvnB3eDJn3rIhx1k3Y6cH10QBrnZBlhpmsJro00Tk=; b=YiEIDHuYph/0LX9E/iND35LCiwY/P0aOjP7Mr8KpmPlWWZH+4lPVs4d5+G5fDV2v2j +ipRL6JDC3DugQmB5kZz4RW4+DKizTphjepYH+RHgP20n8L3vqTw2K9IsKso3KTe0rId 5FewI6vnvbk7gUEZjBbcUiQEbWFX13MH74ag2fTQzcA+nawCC7b0/LnMr2os8r3CFyDz ofhCHWzUg486xRxZmIlHupeKCmnB41L7HX5w2YdKJVym7gj4irxszjX2rR6N0jxIbnnX 3nVzEWyFoECNJb0EbS2dnS3QLkKxJedKwHunTTDb3wkAxAsLB0iCFKxMndy3ciTcLzqe Ic2A== X-Gm-Message-State: AOJu0YxXky9ZS9tv1kUQXy8uZngpqY1gP081aa+3CmOUUlAHz7NRZoeb fS+QoI2bM9cFL69bt3UiwUPr2deaG6E= X-Google-Smtp-Source: AGHT+IExscsWjrWsrozrJU16H0zYNGnXPmLWBsINekP8BfM7AE41arngpd4hjMnA3cVCrD7ggs1svA== X-Received: by 2002:a05:6a00:1a8a:b0:690:cae9:714d with SMTP id e10-20020a056a001a8a00b00690cae9714dmr16677386pfv.13.1698911946071; Thu, 02 Nov 2023 00:59:06 -0700 (PDT) Received: from localhost.localdomain ([58.48.52.254]) by smtp.gmail.com with ESMTPSA id q23-20020a056a0002b700b006be0fb89ac2sm2325919pfs.197.2023.11.02.00.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 00:59:05 -0700 (PDT) From: "xinglong.yang" X-Google-Original-From: "xinglong.yang" To: xinglong.yang@cixtech.com, sudeep.holla@arm.com, cristian.marussi@arm.com Cc: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] firmware: arm_scmi: Refrain set operations of perf Date: Thu, 2 Nov 2023 15:58:53 +0800 Message-ID: <20231102075853.1320710-1-xinglong.yang@cixtech.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231102_005907_622939_B2E385A3 X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Refrain from trying to take the SET operation where the set_* operations are not supported, because: (1.) avoid unneeded SCMI exchanges, (2.) avoids to trust the FW reply blindly. Signed-off-by: xinglong.yang --- drivers/firmware/arm_scmi/perf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c index 431bda9165c3..3bcdef91ed5c 100644 --- a/drivers/firmware/arm_scmi/perf.c +++ b/drivers/firmware/arm_scmi/perf.c @@ -377,6 +377,9 @@ static int scmi_perf_limits_set(const struct scmi_protocol_handle *ph, if (IS_ERR(dom)) return PTR_ERR(dom); + if (!dom->set_limits) + return -EOPNOTSUPP; + if (PROTOCOL_REV_MAJOR(pi->version) >= 0x3 && !max_perf && !min_perf) return -EINVAL; @@ -473,6 +476,9 @@ static int scmi_perf_level_set(const struct scmi_protocol_handle *ph, if (IS_ERR(dom)) return PTR_ERR(dom); + if (!dom->set_perf) + return -EOPNOTSUPP; + if (dom->fc_info && dom->fc_info[PERF_FC_LEVEL].set_addr) { struct scmi_fc_info *fci = &dom->fc_info[PERF_FC_LEVEL]; -- 2.42.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel