From: kernel test robot <lkp@intel.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: [arm:cex7 76/79] drivers/net/phy/qsfp.c:1229:3: warning: misleading indentation; statement is not part of the previous 'if'
Date: Sun, 5 Nov 2023 19:41:36 +0800 [thread overview]
Message-ID: <202311051950.gd99Mrfa-lkp@intel.com> (raw)
tree: git://git.armlinux.org.uk/~rmk/linux-arm.git cex7
head: 279d4f83510a7ff8fc1b449ff43195057e5429dd
commit: b7915b5f9ae73b600c44ce96346a0c246ea28ae3 [76/79] net: add qsfp support [*experimental*]
config: powerpc64-allyesconfig (https://download.01.org/0day-ci/archive/20231105/202311051950.gd99Mrfa-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231105/202311051950.gd99Mrfa-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311051950.gd99Mrfa-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/phy/qsfp.c:1229:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
1229 | qsfp_sm_ins_next(qsfp, SFP_MOD_PRESENT, 0);
| ^
drivers/net/phy/qsfp.c:1222:2: note: previous statement is here
1222 | if (!qsfp->gpio_irq[GPIO_INTL])
| ^
1 warning generated.
vim +/if +1229 drivers/net/phy/qsfp.c
1215
1216 if (qsfp->sm_dev_state == SFP_DEV_DETACHED) {
1217 qsfp_sm_ins_next(qsfp, SFP_MOD_WATTACH, 0);
1218 return;
1219 }
1220
1221 // Start the poller if there is no interrupt support if not running
1222 if (!qsfp->gpio_irq[GPIO_INTL])
1223 queue_delayed_work(system_wq, &qsfp->poll, poll_jiffies);
1224
1225 // ret = sfp_module_insert(qsfp->sfp_bus, &id);
1226 // if (ret < 0)
1227 // qsfp_sm_ins_next(qsfp, SFP_MOD_ERROR, 0);
1228 // else
> 1229 qsfp_sm_ins_next(qsfp, SFP_MOD_PRESENT, 0);
1230 }
1231
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reply other threads:[~2023-11-05 11:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311051950.gd99Mrfa-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).