From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F61BC4332F for ; Mon, 6 Nov 2023 23:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZKK569IDXJ6gyot5rzfM4efCQ2p2EFHQeTsMkVSEW4I=; b=0uJpnfuk8RTENU YM5exeL5g3I2+aVG4ejugR1iV5aqBvYL07W8wyEvDHOcV8wZJ9CYDwP97c+jd/lvFPhRP82kNVZvN 80KAXfOuTKqr0OR7UdaHRC9EuZ3hk1/hV5W5jwK7bPLDzrf669j+x3J9rpqRpgZFK8x5YId0i9e8O Uw8PdJUpFKMpAFv92D8LH0Ld5P98Lm+pWkOgqvsQQO3NIZ/8TDjfB9p8uATK76mO0V7TjhMuU3kt1 KXKYJet10q8o7RZpGsMl8SqtysEYN4GVfTjAJhmU2Bggg8ZauSJq6o538klvKJq7Xk+IW7ic2zy00 /o1e8/i/F6C5UYFZ1HJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r08qQ-0008HJ-0E; Mon, 06 Nov 2023 23:17:22 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r08qL-0008FM-3C for linux-arm-kernel@lists.infradead.org; Mon, 06 Nov 2023 23:17:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7BFA961072; Mon, 6 Nov 2023 23:17:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AA3BC116B1; Mon, 6 Nov 2023 23:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699312637; bh=3mJ+LCciYrX66nE0y5ZlruxIoBmabJFJGkwf+EKV+oo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hicWDTXwzcCdiFaTeXfrgExxlhatGEvLYnc+J7Aq2MrA6uqtrUg5OdMCmcgSwAV6u UaaM0yg3WiiKBVvFbZwhUPtr1MGE79LMdZX85VNE6lJFwRDzbyX4b2dfUpsxTm+e5s rBkwgtp6Admndar904u98vxgUly0UGO6rehAj76Sy2TX7ePiNq0NYjtMDBxyM0nNKl fLHbiB2vq1FJmE2OxuLCtyNLpZ6y17WMqsaljXt7gfIKjm1MvrF2RRW8X0roNruLbM cTwrp3UdHeaANgBfih8+v+DBUz5dnVWG9A5SjQJMPZ4U8zC8milXykM8LfTSwj0pIb RFbm4C/efoA0w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jacky Bai , Peng Fan , Daniel Lezcano , Sasha Levin , tglx@linutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 2/5] clocksource/drivers/timer-imx-gpt: Fix potential memory leak Date: Mon, 6 Nov 2023 18:17:05 -0500 Message-ID: <20231106231711.3735997-2-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231106231711.3735997-1-sashal@kernel.org> References: <20231106231711.3735997-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.297 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_151718_072358_26F782D4 X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Jacky Bai [ Upstream commit 8051a993ce222a5158bccc6ac22ace9253dd71cb ] Fix coverity Issue CID 250382: Resource leak (RESOURCE_LEAK). Add kfree when error return. Signed-off-by: Jacky Bai Reviewed-by: Peng Fan Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20231009083922.1942971-1-ping.bai@nxp.com Signed-off-by: Sasha Levin --- drivers/clocksource/timer-imx-gpt.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c index 165fbbb1c9a04..0e67026d782fe 100644 --- a/drivers/clocksource/timer-imx-gpt.c +++ b/drivers/clocksource/timer-imx-gpt.c @@ -473,12 +473,16 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t return -ENOMEM; imxtm->base = of_iomap(np, 0); - if (!imxtm->base) - return -ENXIO; + if (!imxtm->base) { + ret = -ENXIO; + goto err_kfree; + } imxtm->irq = irq_of_parse_and_map(np, 0); - if (imxtm->irq <= 0) - return -EINVAL; + if (imxtm->irq <= 0) { + ret = -EINVAL; + goto err_kfree; + } imxtm->clk_ipg = of_clk_get_by_name(np, "ipg"); @@ -491,11 +495,15 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t ret = _mxc_timer_init(imxtm); if (ret) - return ret; + goto err_kfree; initialized = 1; return 0; + +err_kfree: + kfree(imxtm); + return ret; } static int __init imx1_timer_init_dt(struct device_node *np) -- 2.42.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel