From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC140C4332F for ; Tue, 7 Nov 2023 12:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h5LHu3gtoH3IA+69+47kRgg0WpACH+DDIYPaglm+dCU=; b=cRECcsr3cdNuE+ 8wi5Yqec71eHLTlr2+WA0O60kgUEofuG+snVJRGro5TmWjIxKEB4ScgwkbWmuFscNW+4wQdcbrmHs WcYx3ataOnJCANjEm7edVcseZQi04tb4lIe/3VDX3BW5BC8cxYRIafjQwsuHewXt4bcBZP+88v2lO u05cbbJHJXSi6pFeCN9pmAhFeaNa/uvT9dEC4hcwueyA8JLqnr3EUSUEZKzQfOe0Jucu0vYgwDuIs 43VH/GX2gAepzfRnydyQo7mgJJ0fVjFAwZ9htc2+TZ7oHCRzH+5r1LuQ8HlEqmuxITU+rYQvqTh2H BSjI4doUo64JdTpga02g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0LLX-001WgG-0k; Tue, 07 Nov 2023 12:38:19 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0LLT-001Wf4-2q; Tue, 07 Nov 2023 12:38:17 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8672A552; Tue, 7 Nov 2023 13:37:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699360673; bh=qGyrRNsx+Ar7l7XICMuNQueoESk81EWoFZ+G3rOQR6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QbV9jX/94Nszyys6nt47rXj50EVggLGXPgnQk4v/fu4uK5dCeIfS4516NEPPoUw/V 39DexljXLFOR7Ji7wI44k8qGbOFYCvniK6ZDqpOXiAqLLHDsIm6057Y3FMYERaUunF dqcwIS3ij19sOTetuLCrq7l6ZD93U16vsX0rIOVY= Date: Tue, 7 Nov 2023 14:38:22 +0200 From: Laurent Pinchart To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Phil Elwell , Dave Stevenson Subject: Re: [PATCH 5/9] staging: vc04_services: Do not pass NULL to vchiq_log_error() Message-ID: <20231107123822.GC3051@pendragon.ideasonboard.com> References: <20231107095156.365492-1-umang.jain@ideasonboard.com> <20231107095156.365492-6-umang.jain@ideasonboard.com> <20231107122551.GA3051@pendragon.ideasonboard.com> <4a5f6ae3-2a1f-f708-d9e0-fad4f5b60a43@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4a5f6ae3-2a1f-f708-d9e0-fad4f5b60a43@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_043816_063719_C2B24CDF X-CRM114-Status: GOOD ( 30.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 07, 2023 at 06:01:58PM +0530, Umang Jain wrote: > On 11/7/23 5:55 PM, Laurent Pinchart wrote: > > On Tue, Nov 07, 2023 at 04:51:52AM -0500, Umang Jain wrote: > >> vchiq_add_connected_callback() logs using vchiq_log_error() macro, > >> but passes NULL instead of a struct device pointer. Fix it. > >> > >> vchiq_add_connected_callback() is not used anywhere in the vc04_services > >> as of now. It will be used when we add new drivers(VC shared memory and > >> bcm2835-isp), hence it kept as it is for now. > >> > >> Fixes: 1d8915cf8899 ("staging: vc04: Convert vchiq_log_error() to use dynamic debug") > >> Signed-off-by: Umang Jain > >> --- > >> .../vc04_services/interface/vchiq_arm/vchiq_connected.c | 4 ++-- > >> .../vc04_services/interface/vchiq_arm/vchiq_connected.h | 4 +++- > >> 2 files changed, 5 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > >> index b3928bd8c9c6..21f9fa1a1713 100644 > >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > >> @@ -27,7 +27,7 @@ static void connected_init(void) > >> * be made immediately, otherwise it will be deferred until > >> * vchiq_call_connected_callbacks is called. > >> */ > >> -void vchiq_add_connected_callback(void (*callback)(void)) > >> +void vchiq_add_connected_callback(struct vchiq_device *device, void (*callback)(void)) > > > > You're changing the prototype of the function, but the patch doesn't > > update any user. If the function is unused, it looks like you can drop > > it instead. Looking at the rest of the vchiq_connected.c file, I think > > you can actually drop the whole file. > > I mentioned in the commit message of this patch. There will be users in > the near future. Yes sorry I missed it, I should have read it more carefully. My fault. > >> { > >> connected_init(); > >> > >> @@ -39,7 +39,7 @@ void vchiq_add_connected_callback(void (*callback)(void)) > >> callback(); > >> } else { > >> if (g_num_deferred_callbacks >= MAX_CALLBACKS) { > >> - vchiq_log_error(NULL, VCHIQ_CORE, > >> + vchiq_log_error(&device->dev, VCHIQ_CORE, > >> "There already %d callback registered - please increase MAX_CALLBACKS", > >> g_num_deferred_callbacks); > >> } else { > >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h > >> index 4caf5e30099d..e4ed56446f8a 100644 > >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h > >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h > >> @@ -1,10 +1,12 @@ > >> /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ > >> /* Copyright (c) 2010-2012 Broadcom. All rights reserved. */ > >> > >> +#include "vchiq_bus.h" > >> + > >> #ifndef VCHIQ_CONNECTED_H > >> #define VCHIQ_CONNECTED_H > >> > >> -void vchiq_add_connected_callback(void (*callback)(void)); > >> +void vchiq_add_connected_callback(struct vchiq_device *device, void (*callback)(void)); > >> void vchiq_call_connected_callbacks(void); > >> > >> #endif /* VCHIQ_CONNECTED_H */ -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel