From: Conor Dooley <conor@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles
Date: Wed, 8 Nov 2023 12:37:52 +0000 [thread overview]
Message-ID: <20231108-wisdom-overall-753fbb76ac74@spud> (raw)
In-Reply-To: <20231106153926.dqvx56fegqpmw3k7@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1507 bytes --]
On Mon, Nov 06, 2023 at 04:39:26PM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 06, 2023 at 04:13:24PM +0100, Alexander Stein wrote:
> > Use #pwm-cells for all i.MX variants. Only fsl,imx1-pwm does not support
> > inverted PWM output. Keep it the same for consistency.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 10 ++++------
> > 1 file changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > index c01dff3b7f843..a84a240a61dc1 100644
> > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > @@ -14,12 +14,10 @@ allOf:
> >
> > properties:
> > "#pwm-cells":
> > - description: |
> > - Should be 2 for i.MX1 and 3 for i.MX27 and newer SoCs. See pwm.yaml
> > - in this directory for a description of the cells format.
> > - enum:
> > - - 2
> > - - 3
> > + description:
> > + The only third cell flag supported by this binding is
> > + PWM_POLARITY_INVERTED. fsl,imx1-pwm does not support this flags.
> > + const: 3
>
> You dropped the | from the description line, but with my understanding
> of yaml this should be fine.
Ya, it was not required there in the first place.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-08 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 15:13 [PATCH v2 0/3] imx8qm/imx8qxp: Support for inverted PWM Alexander Stein
2023-11-06 15:13 ` [PATCH v2 1/3] dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles Alexander Stein
2023-11-06 15:39 ` Uwe Kleine-König
2023-11-08 12:37 ` Conor Dooley [this message]
2023-11-06 15:13 ` [PATCH v2 2/3] arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells Alexander Stein
2023-12-05 12:32 ` Shawn Guo
2023-11-06 15:13 ` [PATCH v2 3/3] arm64: dts: freescale: imx8-ss-dma: " Alexander Stein
2023-12-05 12:32 ` Shawn Guo
2023-11-14 11:39 ` [PATCH v2 0/3] imx8qm/imx8qxp: Support for inverted PWM Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108-wisdom-overall-753fbb76ac74@spud \
--to=conor@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox