From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15731C4332F for ; Wed, 8 Nov 2023 11:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cTpmxape4StqcUwTlj/+6xDEsUl4WY8GNquisQ2C8P4=; b=lBKJL4eJOdFcg6 mcqkc+vwdaE8Et0FMmGr8b1Mh5x6pdK+v1+0ScHVRj1D94ssqT7U5t+GBCgMyqQsDZejlb8cvvPud reBaAx51aRJPM+mI+PtneADrmvpl34XXu1RvSVXqTobHOBM2sOpfdnDByogkBTgHsvBXnidzcyiCK bOJymuGbosodACAgfNm9DHeHgMQsVj5jTp0KbWkxmvEl0/7o3cnooAkN0XMIj1pY+W+CesesokFtZ A5CZFTJIfKKUYCD6wvcekZyd36OGf8V3ApOAJ4hT4EINTR21DpSEFhZk/rxWkfZwwljofP1gY6ALP U7KRB6piHej/Ixs4SvOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0gXP-003X3X-1H; Wed, 08 Nov 2023 11:15:59 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0gXN-003X2l-0D for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2023 11:15:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 2BAE3B81AD3; Wed, 8 Nov 2023 11:15:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E732C433C8; Wed, 8 Nov 2023 11:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699442154; bh=9vSG7HGCOMlTVvwxD3z5KGQGOs/uBAQpqQz6PsNzUOc=; h=From:To:Cc:Subject:Date:From; b=KELedhSb1ggZIE5lSHcxdyePAcQohLzvKDPj1AfkXtcO+iEvN41Z56Tsiie86P1s6 YXyTaRL/8dV2BNl/ECqEPUvQuXNVv90Oaffelbsp/MMJFDv2TJw2uL4vuXzUCKtnNo 7iSoAGbC73dffDoE7zOD0YFbad5D9uvgackPTs0iUrq/MWEevnRdILKBspDQufTUdN gVFJRNCIJcFtbWtSOOY01/IicBipWofNuij+tzQ46LGKap1imtzYD7SB3+G1hLGfGT WcM3z8ZVg9x9n3CJ42bPf34mShn8O67Ur64PvLG4jvfPoBPBGclczSM35acpyU+owq 9sl7FFTTDWS2w== From: Lorenzo Pieralisi To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Sudeep Holla Subject: [PATCH] firmware: arm_ffa: Fix ffa_notification_info_get() IDs handling Date: Wed, 8 Nov 2023 12:15:49 +0100 Message-Id: <20231108111549.155974-1-lpieralisi@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_031557_283287_64E40189 X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org To parse the retrieved ID lists appropriately in ffa_notification_info_get() the ids_processed variable should not be pre-incremented - we are dropping an identifier at the beginning of the list. Fix it by using the post-increment operator to increment the number of processed IDs. Fixes: 3522be48d82b ("firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface") Signed-off-by: Lorenzo Pieralisi Cc: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 07b72c679247..ccf91a795c3d 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -782,7 +782,7 @@ static void ffa_notification_info_get(void) if (ids_processed >= max_ids - 1) break; - part_id = packed_id_list[++ids_processed]; + part_id = packed_id_list[ids_processed++]; if (!ids_count[list]) { /* Global Notification */ __do_sched_recv_cb(part_id, 0, false); @@ -794,7 +794,7 @@ static void ffa_notification_info_get(void) if (ids_processed >= max_ids - 1) break; - vcpu_id = packed_id_list[++ids_processed]; + vcpu_id = packed_id_list[ids_processed++]; __do_sched_recv_cb(part_id, vcpu_id, true); } -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel