From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0761C4332F for ; Wed, 8 Nov 2023 11:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=66PJ5Xqc1jpdOFfx9FOqpQkMUIm4iJNzEBwcewbMqTI=; b=IKRJOEGitfjN9r rVVwToLd6ib0fBkq7nGEYYBCzBG49mA6qUsfKLzzfPYitPHzxW9vZVpDw8oI4XWW0MfiTjmjVJl80 WhHpkk06nL+XkiPO4l07WWtBquNJC4Z6xruK6f8sL+MSMw962AU9AAsQLStELd7/PRY7OkNdSq+Bw mS7gnHVgsJN8B0JiqggPFzPbtfvI2rn/K0hbjeNGTgJ+KkqW1dfAjRXrufjnaM7VLMYcspQn35zq2 OImBJmQbv64hEVj/CDXbQHUtmkFSsawTQbc2TUp989PzYqu3nCsjBMHtwT1eOiVraKoLCBgFxuEYv uwvrST7AgKMOZanUFfQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0goo-003ZsF-2U; Wed, 08 Nov 2023 11:33:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0gol-003Zrk-2c for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2023 11:33:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2FD591477; Wed, 8 Nov 2023 03:34:37 -0800 (PST) Received: from bogus (unknown [10.57.82.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ABC6E3F703; Wed, 8 Nov 2023 03:33:51 -0800 (PST) Date: Wed, 8 Nov 2023 11:32:19 +0000 From: Sudeep Holla To: Lorenzo Pieralisi Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sudeep Holla Subject: Re: [PATCH] firmware: arm_ffa: Fix ffa_notification_info_get() IDs handling Message-ID: <20231108113219.GA1345456@bogus> References: <20231108111549.155974-1-lpieralisi@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231108111549.155974-1-lpieralisi@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_033355_917850_51B03602 X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 08, 2023 at 12:15:49PM +0100, Lorenzo Pieralisi wrote: > To parse the retrieved ID lists appropriately in > ffa_notification_info_get() the ids_processed variable should not > be pre-incremented - we are dropping an identifier at the > beginning of the list. > > Fix it by using the post-increment operator to increment the number > of processed IDs. > > Fixes: 3522be48d82b ("firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface") Thanks for spotting and fixing this. Much appreciated! I will queue at -rc1. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel