From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E493C4332F for ; Wed, 8 Nov 2023 14:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vwqazeB09eBjIGchxLS7zntNVQIRI2qbLlMxrnNpk4k=; b=hxNYz0sCXa1ZxJ w6+s/KLQXX7UXA3pHrgnUg25jhtIMKEMXohrUWL5FSjbc+UCKwX+KMb8xXhU27UtZCinvjpY2Cpfv HIFtgGhCuaDsXPSAFkCV0P2ONi3J3/uV70mKlMmhIMozUwJLDVoyn83VJSlxrATKsoEvl8PEtgXC/ SKJokDNe1uxUYQSg2piqQUFxt/uXP3ASsCLxo6c03v50qQBjqVSKVQnCdkxTaSheLLkTMjJl6Sqhj 4hq/rxnrN6SKm0b2SQsfUJ2lAUcosyxYGBsKikbL+G6PTINZP3r+p91SQpVaOAehE8xvojJty6HEk id204cqOPrBhfldrE7VA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0jW7-0040UK-0L; Wed, 08 Nov 2023 14:26:51 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0jW3-0040Sg-2k for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2023 14:26:49 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-52bd9ddb741so11770530a12.0 for ; Wed, 08 Nov 2023 06:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699453604; x=1700058404; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iVBE77VBxR9IpyvzgJwRw9S64V6IXgaNTy2Pl9D2aH4=; b=MqLlLdJYm2NyOuj9msNgqgrJZo4IWIWpNpOodXzKfLPnpWDW6yicpVvjqn6uhs/ULY DDS6alYqIgDhkZy+yYlyqruxyKRKPsLxjHfZ3gaO77yKsTVfDxlM81uuylEaWm2CXUGJ mxUZL+q/AdwR68LMM5OrA0REcqdkX3ORdmOFa9kyl74CW06POOU6Tj+vEgLhj5d10HM3 kuTKuSE+YUMXjRXZOCHsGP6w7wLpPFOawXx+dRXHQu/4nV1BglaY7YDHgWzC31XBpM+u FeuCESqWL01IzkKmePzXlOgxSuMBBEpn9tB6HY06yYbsNQkOZ64XdgaHp/saJMEeczYN WdsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699453604; x=1700058404; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iVBE77VBxR9IpyvzgJwRw9S64V6IXgaNTy2Pl9D2aH4=; b=wqNwl3bHGZmh3u4Uh18SO0tQBzFQZaZR7f7EKq9RgI2U8EqCbHdjAMyE/0jK74ihtw rS4OOhTqrPstWXgvT7f+nSrDjJdDey4nfXoXitllcLBnU8N5Sr1W/UYh8wVWap30scDL 1orpLDJeE7jIX+GghnODV7NbQRN0VZ67CO6OCf7nIMGjyMw13lV+llNe6S+oLk30DIA7 eWPik2S3aixIcFd96IeguEM2zihmpIu/mbAWyoxbU+V3Sylzxn6zT1ESTqLkGnVyZLU4 vbaWJQI9Tq0S9/hbjaal3VW9k/z5RDchmcxodw8am/e+ZXfQeKj+1cL+XPL0GXE5I/dH zvfQ== X-Gm-Message-State: AOJu0YxAUg4Yh7MvagVSW8gBg+YhaNH0uBuUveFzUaF5pIECVeAJUXfL HvivNLaMUpc+tc/Ai6ou5lU= X-Google-Smtp-Source: AGHT+IGeu2yOuVGSxMaBwyf6wUUUWNLB7feoE7z9tAd1EQvhOpC3cE3veLdFXFYH4H49MAE6ulIGJA== X-Received: by 2002:a17:907:6d13:b0:9bf:65b0:1122 with SMTP id sa19-20020a1709076d1300b009bf65b01122mr1702011ejc.69.1699453603434; Wed, 08 Nov 2023 06:26:43 -0800 (PST) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id q24-20020a1709066b1800b009b2ca104988sm1136317ejr.98.2023.11.08.06.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 06:26:43 -0800 (PST) Date: Wed, 8 Nov 2023 16:26:40 +0200 From: Vladimir Oltean To: Linus Walleij Cc: Hans Ulli Kroll , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrew Lunn , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v3 1/4] net: ethernet: cortina: Fix MTU max setting Message-ID: <20231108142640.tmly4ifgsoeo7m3e@skbuf> References: <20231107-gemini-largeframe-fix-v3-0-e3803c080b75@linaro.org> <20231107-gemini-largeframe-fix-v3-1-e3803c080b75@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231107-gemini-largeframe-fix-v3-1-e3803c080b75@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_062647_891880_64796E5D X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 07, 2023 at 10:54:26AM +0100, Linus Walleij wrote: > The RX max frame size is over 10000 for the Gemini ethernet, > but the TX max frame size is actually just 2047 (0x7ff after > checking the datasheet). Reflect this in what we offer to Linux, > cap the MTU at the TX max frame minus ethernet headers. > > Use the BIT() macro for related bit flags so these TX settings > are consistent. What does this second paragraph intend to say? The patch doesn't use the BIT() macro. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel