From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C652C4332F for ; Wed, 8 Nov 2023 15:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dNWMIm9oRCWISMT6kQXtMZV5aKx69i2TkczpUWc3RR8=; b=iQiE4QujDv8WXY Kbpn8q5SCkaC3j+97d3Nc4Q6esFM28db6vKUKXConIWGip2JicM8zIsSq/Ivd3Qxh7VHo9+qYgUbi oW9TO7pt7BHEKqejLcPN1EqNM5mDimg9g9aayZ535qzvvXsmQgfZlzBf31IFvUtuNtykEe8sGJV9i 5a9Ki/QqQjd7GFDsh3QUJhOVy6Cz87Tn8GL5ik5asRBuXz/pNEU4COFaS7l/fOLlUNHKRcIJCISNx F8IYtAWj7P6ZjPM2MBJl2BhHFnEgzmKMn9iHgSc9DVktb6uKU9VPFpwhuXbG//KmC3KC343y5uKcv 6gI6AFh+POrA5kPDlQeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0kLM-004B3v-2S; Wed, 08 Nov 2023 15:19:48 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0kLJ-004B1h-1n for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2023 15:19:47 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9dd5879a126so838380566b.3 for ; Wed, 08 Nov 2023 07:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699456780; x=1700061580; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MYNVo9ibeelXZMFCx2bih7YcjMCRn9oc8F4dU6CJcZw=; b=NOo2vfK5o9FK6oWeihjh4s5mB+LrDVF8yu5T3o0JwpUHWaZ3rC4ptDVIrqys1pS1FM LR47cjJ1SGU1DnjZQwoD+Quz3RApSET7vYBjlpnk3jkVV5Lo/JnWMQLF8izYIh48YPuP it7NfPlGJ16G7t64r7/scebqEEFEa+aYSBRy9omZRWCEesy5LaXrC2jHE2zss0EkK5wC ShyPSZhJdjW8LZ5XgeRn2VvJqbweyyCnOHv7rLiCniB2pczmnppHcedZQ87CvID8uhZM BK3HJ31F2TObqhOU9rm7FPLhJxs5FqnUG3c3AAUoe59mAsIbkdplMrhhLGk36KCOK28/ zvmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699456780; x=1700061580; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MYNVo9ibeelXZMFCx2bih7YcjMCRn9oc8F4dU6CJcZw=; b=tJjmmcKSN/+evEGdY4DT29A9PpsRVDvWHQdY+KGZ3LF6siksNAKmQSGlgxt4s4zVT2 C7l0MHdVAKUVfdmYbpLwUOcT6dkU8lTAxdNdBgLQU2VnO8hJ1LcqrflfBiE7uWBcnm2x 6HZOZaPWT139SZa4cwmLRZYCxVUDDrCvIX89qYU+s0V3MXs8Q7Z9H4LFYz1NDdcR3VIn L/lgXPswoHy9BfpP9R0cMctcc5jlZIRq9j35tnWASpVzNZalG6Br+4fn8eqCj+40n2/L RZi99mUuFYXUKSSTtgoGna7l/HGjLx/D66z/B0wsuuyAoyYaXSWebqdkRYbkG0SVIVuD hVVA== X-Gm-Message-State: AOJu0Yw+R0oeazs/AXB2nKPbwXvnfkdZER1AACoYjYSIM1WcMa44HCCG cDQLZ5UxZvZvzz2C9SjcEfI= X-Google-Smtp-Source: AGHT+IGsTV4eYFd+IyDPEhPcw+Ng23LK8rz1I1gklG/eo0ESwFqDvCLgNYk6DOddqjRMjGrBBufATQ== X-Received: by 2002:a17:906:fe45:b0:9be:2469:bdf5 with SMTP id wz5-20020a170906fe4500b009be2469bdf5mr1720133ejb.15.1699456779981; Wed, 08 Nov 2023 07:19:39 -0800 (PST) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id u20-20020a170906125400b009928b4e3b9fsm1186061eja.114.2023.11.08.07.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 07:19:39 -0800 (PST) Date: Wed, 8 Nov 2023 17:19:37 +0200 From: Vladimir Oltean To: Linus Walleij Cc: Hans Ulli Kroll , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrew Lunn , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v3 4/4] net: ethernet: cortina: Checksum only TCP and UDP Message-ID: <20231108151937.uf3ui4z6vy3i2uhu@skbuf> References: <20231107-gemini-largeframe-fix-v3-0-e3803c080b75@linaro.org> <20231107-gemini-largeframe-fix-v3-4-e3803c080b75@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231107-gemini-largeframe-fix-v3-4-e3803c080b75@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_071945_590678_9C109D82 X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 07, 2023 at 10:54:29AM +0100, Linus Walleij wrote: > It is a bit odd that frames that are neither TCP or UDP > (such as ICMP or ARP) are still sent to the checksumming > engine, where they are clearly just ignored. > > Rewrite the logic slightly so that we first check if the > frame is TCP or UDP, in that case bypass the checksum > engine. > > Reported-by: Vladimir Oltean > Signed-off-by: Linus Walleij > --- If this patch doesn't fix anything and isn't a dependency for anything, it shouldn't be present in a series targeted for "net". And anyway, I think it's not needed in general after the discussion on v2. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel