From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC5E1C4332F for ; Thu, 9 Nov 2023 10:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hFZ86EVZPLfJhDFV5YMGL3lzYjEF5ohLw0ZGv032V4s=; b=cgfYNfVNjnC3vd 6SPBBX/maNEva3/F0UcI+PwKpC5rwlyR4KiqkYJiQtUCuTO3brI725sWJuJFUI6K681Bb2MxAGnIv DuIu1eHOPZTSBThal2TUTUN4HNmJtNKl1JJp7Q1ow6ZZ9HyoVOAzPBenDrVpvbbIcqAo6LhtTV1NY ycnu2VlFOY+jZonnCUXprWfgJLATlHUEz8U31ysZNH/bVdTRyR1ZzUczErNuo+sCbHarSmGZdUqjp aR5Qz/xWGcFMwAMI5SSwVHP1BuUcwbHeIXVo7VEOar8vOzRz6zXE8IY98Ow1Dm3wMfzJaRE3Jeoce xJTn5lj1EJ6poMneDimg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r12ZP-005ymN-0E; Thu, 09 Nov 2023 10:47:31 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r12ZM-005ylj-0F for linux-arm-kernel@lists.infradead.org; Thu, 09 Nov 2023 10:47:29 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4081ccf69dcso11032225e9.0 for ; Thu, 09 Nov 2023 02:47:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699526846; x=1700131646; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HU6Rk9mQBtZM0uAVQC4cwcuLTXlxJFUrIWkkQhv6s1Q=; b=eWg57ao1eKaB3yX53QAqp6NfLsai/KkGBjMaK8wRcH5fD1bdl7ze18AUF/JuQgoQcI CdQ+PxT1Wjalo2oqw46Ykd+kuFXyAjy0iDO7mpNz+BvczEQ203JInyQIR6uyRedTatER DA5mwWWbKh4dLYQWn9HEI8NqdOSw18r8M1f59Q2MagD9AWqf293J1Qw/UEGzOrfPj9Ep 7NRiAG19MsC3ngYYo2zOdV6e530Gw/8AfrN+qbSw9jw6452z+GGhMOtirzNM/ZMcsUK6 /8grGnILprTQsyVxp2+xI3zvbShLM80rG5LuiIcPeaZca9FE8SHZo/IH93EdxP/J3TLQ TvPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699526846; x=1700131646; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HU6Rk9mQBtZM0uAVQC4cwcuLTXlxJFUrIWkkQhv6s1Q=; b=bxX6at/0vgbv4+dJyay2g9mCyhxXc2nKgjleH7Yjw6n5QUKwssohx8hlqb9WOxuA+0 2iftBXJUSS/kg0hJWZHLJVVIz0hSDR4Mz4obXA3tpRDFFveQ0sODL5gTR3bGF4qmKQrH Wb7Xb/g1JRkTxwTeJr75zOE2F7YQIU9zX+oEeesv6Pn/ISWof61y+WZvSHWVaISsF4TQ KcuFVc2rw4mhD7Uvry8kv2TGfXgDrV4X7PyY482GW/tELbztpsai1N9MIXQKgG84MZYk JgtQLr580Yr9zTl52iaa0btejqT3SzkAIihQwXXDFzEBjcW+44HwCwvWMW1h6msLGaJG zDCg== X-Gm-Message-State: AOJu0YwOhsgr1j2nn1BwLWRWOthsYzpruHYu29mQbL9IPuL1T2QYR6s9 5trP+pUhn5mCSClAeyheBck= X-Google-Smtp-Source: AGHT+IFzWcoUglTgvCK+nVyrYytnnaGvyoCcZb5uYxZ4lo4eu/SpjBPNzF1WetwatuAXkfRMBjqgcw== X-Received: by 2002:a5d:658a:0:b0:32f:a254:c8b2 with SMTP id q10-20020a5d658a000000b0032fa254c8b2mr5527744wru.20.1699526845882; Thu, 09 Nov 2023 02:47:25 -0800 (PST) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id v5-20020adfa1c5000000b0032d81837433sm7142165wrv.30.2023.11.09.02.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 02:47:25 -0800 (PST) Date: Thu, 9 Nov 2023 12:47:23 +0200 From: Vladimir Oltean To: Linus Walleij Cc: Hans Ulli Kroll , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrew Lunn , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v4 3/3] net: ethernet: cortina: Fix MTU max setting Message-ID: <20231109104723.2f47d2slwkbmqctt@skbuf> References: <20231109-gemini-largeframe-fix-v4-0-6e611528db08@linaro.org> <20231109-gemini-largeframe-fix-v4-0-6e611528db08@linaro.org> <20231109-gemini-largeframe-fix-v4-3-6e611528db08@linaro.org> <20231109-gemini-largeframe-fix-v4-3-6e611528db08@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231109-gemini-largeframe-fix-v4-3-6e611528db08@linaro.org> <20231109-gemini-largeframe-fix-v4-3-6e611528db08@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_024728_117435_3AACDEBA X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 09, 2023 at 10:03:14AM +0100, Linus Walleij wrote: > The RX max frame size is over 10000 for the Gemini ethernet, > but the TX max frame size is actually just 2047 (0x7ff after > checking the datasheet). Reflect this in what we offer to Linux, > cap the MTU at the TX max frame minus ethernet headers. > > We delete the code disabling the hardware checksum for large > MTUs as netdev->mtu can no longer be larger than > netdev->max_mtu meaning the if()-clause in gmac_fix_features() > is never true. > > Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") > Reviewed-by: Andrew Lunn > Signed-off-by: Linus Walleij > --- Reviewed-by: Vladimir Oltean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel