From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04417C4332F for ; Thu, 9 Nov 2023 10:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1POdnOT+eOpOIocosVNcqOcaVu0Qu6Di1JU9OWzeJ8Q=; b=uiDgniZMAYO8Ya 0acK7n2BRjSE2wIwl2U7jto4F0XIXSYSD9G7CGWikwR7KjPJmfYNQYlqbHMBLCpB7uLuT1YuXCA8a i2HXfgcSNI04wXXDfVaYbfZ5ubZRAzn/GdZCUJcj7Z9hafXVjI+IViyfalJY4yBIUaeToWzR0ehNQ 4o1itkE+RRge+VckzIJxVQsin8wPwLdsQP5Mrvu+5J0RMH58IqPemiH4cVFcDvmuDRjo9bZSU7eNW h4oCj8qXeEHaqo+WIec3h2cIGUhOwzHwnW2WBvVphaivsRx6+aSjcsfJ6DAiWkr/7LHacdh4umxwa qAw1g2WJdyjX+smSzPLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r12cY-005zNs-0D; Thu, 09 Nov 2023 10:50:46 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r12cW-005zNE-0w for linux-arm-kernel@lists.infradead.org; Thu, 09 Nov 2023 10:50:45 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4083f613272so5081815e9.1 for ; Thu, 09 Nov 2023 02:50:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699527040; x=1700131840; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M6XHp8ZxUUWF+Lmmh8ZFzScZepwpVrVtTeNoN9NNTn4=; b=l4VZM5WC3q8PzKWcLddPjR362ByW+iR0R8bMQaJT+Q+F68t8YL4nLcgy+o+JtO4qQp vxIU86lAsNJWsOwHFG4XLc44naRiV6JHFPwM+aSlJx/Z5k8XquVnBzHh3bf7/M7dG359 +sZt503uEeuz/wUYxtpCXcilmgDeVsXmcRcruiKcHocbSO25sTaA/XpHzed+VCA8et4x /YNKRBjF8B4Cn1BXvMzTM1d3cRY6GInudYoz2m4NhZquLSV+SVNJTT7BVEIvx+xrmnVA zj6ERbwgqQYIMBKgV8qyWLoLA/c2mLs/BMQxW5WiU9SssPsnId8rB2/D/7VGRiHl3UqG dzxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699527040; x=1700131840; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M6XHp8ZxUUWF+Lmmh8ZFzScZepwpVrVtTeNoN9NNTn4=; b=h7teqT8YpU1dwzutjHEHzluEYRx6qoytUOnkwQzafwQkdslq/HaCwWCfJCPaw5Sqdb 3dZywfCcPn6zLeSiZ7OYGrdyFmTwpKsq02bVof+PDNRcyHhytObg0jOxD/42DsW/8oTf RDSnfqJCHPQmw9mEBqqkPUFldhD1s00l5tRXfqku4PYuHfsTnY7VEZHdhAFhurFWlz+4 5Sd9NDr3s/a0qGWX5Vezi6IxSy6es5YHLZADsZFxcPCgXdes1lAUASZhWWnrPcy7J1/o fLX3JXNdlyTv85f+KoWu6sQ9TcF9QjizaLVi46Vt3grSeD1SZUzVc4LAlCMxBTH19zgc e1Qg== X-Gm-Message-State: AOJu0YwrhX+azRIZf6z1O91Gyedps6EezE2T+TNH6Xx8POsVXS787oAN CN7Jh+g+nbc4w73mUJZy5gU= X-Google-Smtp-Source: AGHT+IHkTzzHCRer28VEszakWXegQq7fkpcKQVYrtPkskdHGdqFchpM3qgS6wDDvnF2Oa4VQcpPgqQ== X-Received: by 2002:a05:6000:188b:b0:32f:89e5:ef60 with SMTP id a11-20020a056000188b00b0032f89e5ef60mr3501570wri.11.1699527040321; Thu, 09 Nov 2023 02:50:40 -0800 (PST) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id n7-20020a5d6607000000b0032db1d741a6sm7079646wru.99.2023.11.09.02.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 02:50:40 -0800 (PST) Date: Thu, 9 Nov 2023 12:50:37 +0200 From: Vladimir Oltean To: Linus Walleij Cc: Hans Ulli Kroll , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrew Lunn , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v4 0/3] Fix large frames in the Gemini ethernet driver Message-ID: <20231109105037.zppxrr3bptd7a7i6@skbuf> References: <20231109-gemini-largeframe-fix-v4-0-6e611528db08@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231109-gemini-largeframe-fix-v4-0-6e611528db08@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_025044_327112_DAE89D3B X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 09, 2023 at 10:03:11AM +0100, Linus Walleij wrote: > This is the result of a bug hunt for a problem with the > RTL8366RB DSA switch leading me wrong all over the place. > > I am indebted to Vladimir Oltean who as usual pointed > out where the real problem was, many thanks! > > Tryig to actually use big ("jumbo") frames on this > hardware uncovered the real bugs. Then I tested it on > the DSA switch and it indeed fixes the issue. > > To make sure it also works fine with big frames on > non-DSA devices I also copied a large video file over > scp to a device with maximum frame size, the data > was transported in large TCP packets ending up in > 0x7ff sized frames using software checksumming at > ~2.0 MB/s. > > If I set down the MTU to the standard 1500 bytes so > that hardware checksumming is used, the scp transfer > of the same file was slightly lower, ~1.8-1.9 MB/s. > > Despite this not being the best test it shows that > we can now stress the hardware with large frames > and that software checksum works fine. > > Signed-off-by: Linus Walleij > --- Thanks for being persistent with this! I hope we didn't miss today's "net" pull request :) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel