* [PATCH 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support
2023-11-13 11:23 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
@ 2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 20:42 ` Heiko Stübner
2023-11-13 11:23 ` [PATCH 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-13 11:23 UTC (permalink / raw)
To: Wolfram Sang, Sandy Huang
Cc: linux-i2c, Heiner Kallweit, Heiko Stübner, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter,
dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index 6e5b922a1..a7739b27c 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi)
init_completion(&i2c->cmp);
adap = &i2c->adap;
- adap->class = I2C_CLASS_DDC;
adap->owner = THIS_MODULE;
adap->dev.parent = hdmi->dev;
adap->dev.of_node = hdmi->dev->of_node;
diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
index fa6e592e0..7a3f71aa2 100644
--- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c
+++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
@@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi)
init_completion(&i2c->cmpltn);
adap = &i2c->adap;
- adap->class = I2C_CLASS_DDC;
adap->owner = THIS_MODULE;
adap->dev.parent = hdmi->dev;
adap->dev.of_node = hdmi->dev->of_node;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support
2023-11-13 11:23 ` [PATCH 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
@ 2023-11-13 20:42 ` Heiko Stübner
0 siblings, 0 replies; 10+ messages in thread
From: Heiko Stübner @ 2023-11-13 20:42 UTC (permalink / raw)
To: Wolfram Sang, Sandy Huang, Heiner Kallweit
Cc: linux-i2c, Heiner Kallweit, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, dri-devel,
linux-arm-kernel, linux-rockchip, linux-kernel
Am Montag, 13. November 2023, 12:23:25 CET schrieb Heiner Kallweit:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
>
> ---
> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
> index 6e5b922a1..a7739b27c 100644
> --- a/drivers/gpu/drm/rockchip/inno_hdmi.c
> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
> @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi)
> init_completion(&i2c->cmp);
>
> adap = &i2c->adap;
> - adap->class = I2C_CLASS_DDC;
> adap->owner = THIS_MODULE;
> adap->dev.parent = hdmi->dev;
> adap->dev.of_node = hdmi->dev->of_node;
> diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
> index fa6e592e0..7a3f71aa2 100644
> --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c
> +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
> @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi)
> init_completion(&i2c->cmpltn);
>
> adap = &i2c->adap;
> - adap->class = I2C_CLASS_DDC;
> adap->owner = THIS_MODULE;
> adap->dev.parent = hdmi->dev;
> adap->dev.of_node = hdmi->dev->of_node;
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support
2023-11-13 11:23 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-13 11:23 ` [PATCH 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
@ 2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-13 11:23 UTC (permalink / raw)
To: Wolfram Sang, Maxime Ripard
Cc: linux-i2c, Heiner Kallweit, Chen-Yu Tsai, Maarten Lankhorst,
Thomas Zimmermann, David Airlie, Daniel Vetter, Jernej Skrabec,
Samuel Holland, dri-devel, linux-arm-kernel, linux-sunxi,
linux-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c
index d1a65a921..f5f62eb0e 100644
--- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c
+++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c
@@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi)
return -ENOMEM;
adap->owner = THIS_MODULE;
- adap->class = I2C_CLASS_DDC;
adap->algo = &sun4i_hdmi_i2c_algorithm;
strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name));
i2c_set_adapdata(adap, hdmi);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support
2023-11-13 11:23 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-13 11:23 ` [PATCH 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
@ 2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-13 17:49 ` [PATCH 00/20] " Wolfram Sang
4 siblings, 0 replies; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-13 11:23 UTC (permalink / raw)
To: Wolfram Sang, Russell King
Cc: linux-i2c, Heiner Kallweit, Helge Deller, linux-arm-kernel,
linux-fbdev, dri-devel, linux-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/video/fbdev/cyber2000fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c
index 52105dc1a..79775deda 100644
--- a/drivers/video/fbdev/cyber2000fb.c
+++ b/drivers/video/fbdev/cyber2000fb.c
@@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb)
strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id,
sizeof(cfb->ddc_adapter.name));
cfb->ddc_adapter.owner = THIS_MODULE;
- cfb->ddc_adapter.class = I2C_CLASS_DDC;
cfb->ddc_adapter.algo_data = &cfb->ddc_algo;
cfb->ddc_adapter.dev.parent = cfb->fb.device;
cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support
2023-11-13 11:23 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
` (2 preceding siblings ...)
2023-11-13 11:23 ` [PATCH 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
@ 2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 17:49 ` [PATCH 00/20] " Wolfram Sang
4 siblings, 0 replies; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-13 11:23 UTC (permalink / raw)
To: Wolfram Sang, Chun-Kuang Hu
Cc: linux-i2c, Heiner Kallweit, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger, AngeloGioacchino Del Regno,
dri-devel, linux-mediatek, linux-kernel, linux-arm-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
index d675c954b..54e46e440 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
@@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev)
strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name));
ddc->adap.owner = THIS_MODULE;
- ddc->adap.class = I2C_CLASS_DDC;
ddc->adap.algo = &mtk_hdmi_ddc_algorithm;
ddc->adap.retries = 3;
ddc->adap.dev.of_node = dev->of_node;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 00/20] remove I2C_CLASS_DDC support
2023-11-13 11:23 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
` (3 preceding siblings ...)
2023-11-13 11:23 ` [PATCH 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
@ 2023-11-13 17:49 ` Wolfram Sang
2023-11-13 18:21 ` Heiner Kallweit
4 siblings, 1 reply; 10+ messages in thread
From: Wolfram Sang @ 2023-11-13 17:49 UTC (permalink / raw)
To: Heiner Kallweit
Cc: intel-gfx, linux-i2c, Jernej Skrabec, Jonas Karlman,
Laurent Pinchart, linux-fbdev, amd-gfx, linux-rockchip,
linux-arm-kernel, dri-devel, linux-kernel, Thomas Zimmermann,
Jocelyn Falempe, linux-sunxi, linux-mediatek, Sean Paul,
Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
[-- Attachment #1.1: Type: text/plain, Size: 261 bytes --]
> Preferably this series should be applied via the i2c tree.
Are we in a hurry here, i.e. does it block further development of the
i801 smbus driver? My gut feeling says the patches should rather go via
drm and fbdev trees, but I may be convinced otherwise.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 00/20] remove I2C_CLASS_DDC support
2023-11-13 17:49 ` [PATCH 00/20] " Wolfram Sang
@ 2023-11-13 18:21 ` Heiner Kallweit
2023-11-13 20:54 ` Wolfram Sang
0 siblings, 1 reply; 10+ messages in thread
From: Heiner Kallweit @ 2023-11-13 18:21 UTC (permalink / raw)
To: Wolfram Sang, intel-gfx, linux-i2c, Jernej Skrabec, Jonas Karlman,
Laurent Pinchart, linux-fbdev, amd-gfx, linux-rockchip,
linux-arm-kernel, dri-devel, linux-kernel, Thomas Zimmermann,
Jocelyn Falempe, linux-sunxi, linux-mediatek, Sean Paul,
Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
On 13.11.2023 18:49, Wolfram Sang wrote:
>
>> Preferably this series should be applied via the i2c tree.
>
> Are we in a hurry here, i.e. does it block further development of the
> i801 smbus driver? My gut feeling says the patches should rather go via
> drm and fbdev trees, but I may be convinced otherwise.
>
We're not in a hurry. It's just my experience with patch series' affecting
multiple subsystems that typically the decision was to apply the full
series via one tree. Also to avoid inquires from maintainers like:
Shall I take it or are you going to take it?
Of course there may be different opinions. Please advise.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/20] remove I2C_CLASS_DDC support
2023-11-13 18:21 ` Heiner Kallweit
@ 2023-11-13 20:54 ` Wolfram Sang
2023-11-16 19:17 ` Alex Deucher
0 siblings, 1 reply; 10+ messages in thread
From: Wolfram Sang @ 2023-11-13 20:54 UTC (permalink / raw)
To: Heiner Kallweit
Cc: intel-gfx, linux-i2c, Jernej Skrabec, Jonas Karlman,
Laurent Pinchart, linux-fbdev, amd-gfx, linux-rockchip,
linux-arm-kernel, dri-devel, linux-kernel, Thomas Zimmermann,
Jocelyn Falempe, linux-sunxi, linux-mediatek, Sean Paul,
Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
[-- Attachment #1.1: Type: text/plain, Size: 573 bytes --]
> We're not in a hurry. It's just my experience with patch series' affecting
> multiple subsystems that typically the decision was to apply the full
> series via one tree. Also to avoid inquires from maintainers like:
> Shall I take it or are you going to take it?
> Of course there may be different opinions. Please advise.
Ok, then this turns out to be a negotation thing between the drm/fbdev
maintainers and me. I *can* take all the patches, of course. But since
the number of patches touching the non-i2c subsystems is high, I'd like
to hear their preference, too.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/20] remove I2C_CLASS_DDC support
2023-11-13 20:54 ` Wolfram Sang
@ 2023-11-16 19:17 ` Alex Deucher
0 siblings, 0 replies; 10+ messages in thread
From: Alex Deucher @ 2023-11-16 19:17 UTC (permalink / raw)
To: Wolfram Sang, Heiner Kallweit, intel-gfx, linux-i2c,
Jernej Skrabec, Jonas Karlman, Laurent Pinchart, linux-fbdev,
amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Thomas Zimmermann, Jocelyn Falempe, linux-sunxi,
linux-mediatek, Sean Paul, Marijn Suijten, linux-arm-msm,
freedreno, Xinwei Kong, Sumit Semwal, Yongqin Liu, John Stultz
On Mon, Nov 13, 2023 at 3:55 PM Wolfram Sang <wsa@kernel.org> wrote:
>
>
> > We're not in a hurry. It's just my experience with patch series' affecting
> > multiple subsystems that typically the decision was to apply the full
> > series via one tree. Also to avoid inquires from maintainers like:
> > Shall I take it or are you going to take it?
> > Of course there may be different opinions. Please advise.
>
> Ok, then this turns out to be a negotation thing between the drm/fbdev
> maintainers and me. I *can* take all the patches, of course. But since
> the number of patches touching the non-i2c subsystems is high, I'd like
> to hear their preference, too.
>
I don't have a preference if you would prefer to take these via i2c.
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread