From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CA37C4332F for ; Mon, 13 Nov 2023 14:31:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XBa+4tQd4Sjy8CgUvEGNvFRpwLnXeczUxs+HA2uQBfo=; b=g21+w9n8flT3Mn y+8RQNWogTl1jBKIiDNFBqoEjQvRnLjlwcXC91MU8iiCfNKBmVmPPolJZ4DLWEQJ+tQV4va3gIrg8 CPG5VjVo8d8EIqxvQRr9Dpf8QHRUvtjDbU6DkaofDi1vGgMWOU17sB8/m8V2rO6XLTbL08p2cYjCq tAuyc5+vF7k+owQzT3myPj8nsg/e0NMDP3pTMItMCAG4bbicNR3eydD5477hpNz2Skhh0r3MwUMyO sC0rJf0cW5U7DvAFEhe3k4n2O1XI2zlC3jlKSwryYkSekUfd0holh6+QqG1bzPE9iuSJxLt/e9zZf tW1gnoXWt/+VgBUpKEBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2Xy5-00E990-03; Mon, 13 Nov 2023 14:31:13 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r2Xy2-00E98X-2X for linux-arm-kernel@lists.infradead.org; Mon, 13 Nov 2023 14:31:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2C19660F54; Mon, 13 Nov 2023 14:31:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F554C433C7; Mon, 13 Nov 2023 14:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1699885868; bh=EFRRufbeFQ+IM6jr2E8iXNUpk4Tyw5xoM0LYuJZwr8w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pPDiCWXSIqFqXZ9MOcD99iR88SRKkLJSmnwlm8qL6KDxCfToWHGm6CcOqGS1gASdr /iJKFCZcJeiJhzAti/ScTSRQ1etmlJdz1geaJa/4TYngvaPNFQyDBywqYk4QQRyOrs 0vnlmNE10/B5JXu0n+NRzGFs4gr19pkFXSACiE9I= Date: Mon, 13 Nov 2023 09:31:04 -0500 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Michal Simek , Jiri Slaby , Petr Mladek , linux-serial@vger.kernel.org, John Ogness , Ruan Jinjie , Julien Malik , kernel@pengutronix.de, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 52/52] serial: xilinx_uartps: Convert to platform remove callback returning void Message-ID: <2023111330-tigress-suffering-e329@gregkh> References: <20231110152927.70601-1-u.kleine-koenig@pengutronix.de> <20231110152927.70601-53-u.kleine-koenig@pengutronix.de> <15784357-6557-4431-a1dd-128152b48160@amd.com> <20231113100342.sih3te7a7z5jeh4j@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231113100342.sih3te7a7z5jeh4j@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231113_063110_885889_801AE69A X-CRM114-Status: GOOD ( 28.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 13, 2023 at 11:03:42AM +0100, Uwe Kleine-K=F6nig wrote: > On Mon, Nov 13, 2023 at 10:41:17AM +0100, Michal Simek wrote: > > = > > = > > On 11/10/23 16:30, Uwe Kleine-K=F6nig wrote: > > > The .remove() callback for a platform driver returns an int which mak= es > > > many driver authors wrongly assume it's possible to do error handling= by > > > returning an error code. However the value returned is ignored (apart > > > from emitting a warning) and this typically results in resource leaks. > > > = > > > To improve here there is a quest to make the remove callback return > > > void. In the first step of this quest all drivers are converted to > > > .remove_new(), which already returns void. Eventually after all drive= rs > > > are converted, .remove_new() will be renamed to .remove(). > > > = > > > Trivially convert this driver from always returning zero in the remove > > > callback to the void returning variant. > > > = > > > Signed-off-by: Uwe Kleine-K=F6nig > > > --- > > > drivers/tty/serial/xilinx_uartps.c | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > = > > > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/= xilinx_uartps.c > > > index 66a45a634158..6decf2b13340 100644 > > > --- a/drivers/tty/serial/xilinx_uartps.c > > > +++ b/drivers/tty/serial/xilinx_uartps.c > > > @@ -1666,7 +1666,7 @@ static int cdns_uart_probe(struct platform_devi= ce *pdev) > > > * > > > * Return: 0 on success, negative errno otherwise > > = > > this line should be also removed. > = > Good catch. > = > @gregkh: What is the preferred way to address that? I can follow up with > a patch on top of this one (and you squash it or not), I can send a > patch that gets that does the conversion and drops the comment (and you > skip this incomplete patch when applying this series) or I can resend > the whole series in a week or so. Follow-on patch is fine, I'll take this whole series in a week when I catch up from the merge-window-backlog as I'm at the Plumbers conference this week... thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel