From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAD4DC4332F for ; Tue, 14 Nov 2023 17:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hd8jrfyetjT55nrrSUjW31z+ECwfly5qedm2MgLWH0A=; b=vBYGj8C/5VQjrSV3PY1k4t5s58 UU3g/mn9YLCqWY1miuYqjpdLdy19GP3rLkYtb5aps260N/A3qwNK7tmIcC03gKcc7/iecZfFNbG7d MCZngQuqKgdmagTpQqEAcdxJFBnfkM7gMZ6tF0i8M/xjYDHg+wyZiz1O5INb9DaOS/28yHIcfwBDt Xv8qNjesw+KuxeKiL3GV5377K2i2JAt2O9tgHkk3AUTbhazp0R9uZV9u588B3vmYF2knaNLC412mc nIpIm+iPQlG/CNEBX5oWm/N77xOH/PctRZZhDjy6XcU8keXpMsjO9TeO8md+xWFjOi6zs7BFk18YI 1XTZ/VjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2xfA-00GXjT-2v; Tue, 14 Nov 2023 17:57:24 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r2xf6-00GXi7-1n for linux-arm-kernel@lists.infradead.org; Tue, 14 Nov 2023 17:57:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 10BA7B8164B; Tue, 14 Nov 2023 17:57:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40AB3C433C7; Tue, 14 Nov 2023 17:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699984638; bh=TA5MITJHC2T13fQnufVaK7/sIlajF1q5F1aF0YWeztQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o+symr6MkA9aQtcw1bYamXK14WvN66KoLpemZUMdLpN8Qbn0Gd4LmHGlxICWnnK+I bLQSlMekeZ6g3DRpfnA5Cia2b0XOaEbBldtmYQ/3FY/F0rrGNEXKZZmePsxa7iZKVl oM81pFh3xQR35RdndIs+oxCDXQSopGzNfvf9oTOeqZ2bIGE856FGsoyVkToG+hdDc0 e4HUi80KaAVnP5D5umNzo8s6fbiH7U/87nR9gpRv1e9UZ9q2IBs5QMkQJ7uFOnzHEe 2V2gGdA9aW7NOqCvI6yX6qnThXGPCf7GizmMno6zzg54i1sFfRwMx39VjZNCcwWDBr 21VwijL1bAl0Q== Date: Tue, 14 Nov 2023 17:57:15 +0000 From: Conor Dooley To: Ji Sheng Teoh Cc: Will Deacon , Mark Rutland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Peter Zijlstra , Ley Foon Tan , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: perf: starfive: Add StarLink PMU Message-ID: <20231114-policy-routing-8df2607e76cf@squawk> References: <20231114021254.3009799-1-jisheng.teoh@starfivetech.com> <20231114021254.3009799-3-jisheng.teoh@starfivetech.com> MIME-Version: 1.0 In-Reply-To: <20231114021254.3009799-3-jisheng.teoh@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231114_095720_882012_BAB7606F X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4072062213492426290==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4072062213492426290== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GVUN6CsEXv0BSbNb" Content-Disposition: inline --GVUN6CsEXv0BSbNb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 14, 2023 at 10:12:54AM +0800, Ji Sheng Teoh wrote: > Add device tree binding for StarFive's StarLink PMU (Performance > Monitor Unit). >=20 > Signed-off-by: Ji Sheng Teoh > --- > .../bindings/perf/starfive,starlink-pmu.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/perf/starfive,starl= ink-pmu.yaml >=20 > diff --git a/Documentation/devicetree/bindings/perf/starfive,starlink-pmu= =2Eyaml b/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > new file mode 100644 > index 000000000000..b164f6849055 > --- /dev/null > +++ b/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/perf/starfive,starlink-pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive StarLink PMU > + > +maintainers: > + - Ji Sheng Teoh > + > +description: > + StarFive's StarLink PMU integrates one or more CPU cores with a shared= L3 > + memory system. The PMU support overflow interrupt, up to 16 programmab= le > + 64bit event counters, and an independent 64bit cycle counter. > + StarLink PMU is accessed via MMIO. > + > +properties: > + compatible: > + const: starfive,starlink-pmu This compatible (in isolation) is far too generic. Please add a device specific compatible for the device that has this PMU. Thanks, Conor. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + soc { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + > + l3_pmu: pmu@12900000 { > + compatible =3D "starfive,starlink-pmu"; > + reg =3D <0x0 0x12900000 0x0 0x10000>; > + interrupts =3D <34>; > + }; > + }; > --=20 > 2.25.1 >=20 --GVUN6CsEXv0BSbNb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHQEARYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZVO09wAKCRB4tDGHoIJi 0oKyAQDMGNLblbWwPrbf2IDZPlUbqUp3cf3FJJlST27PCfSlPAD3fxa4mjKlBXxF rBGin84XnMj9T1tFSy1yt3KRXzJsCA== =5OaB -----END PGP SIGNATURE----- --GVUN6CsEXv0BSbNb-- --===============4072062213492426290== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4072062213492426290==--