From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8835C4332F for ; Tue, 14 Nov 2023 13:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kPZgfg1NrvVtPmAEhlk3vT9SIcfNrhoA+sZataYO5HA=; b=qlIde/kOpAW7ch tI6L3su7XKDknvFIAPzuzeo5Pe8qnWWnGoskNOAaKSvb2rmVC2brffxb6EcUR3SLEpbySN4r0UUpF tG4MPVfMpuE4RIIpjVSu+/RGN0Vu/tb3nkK34H7J2uQ+0y0lks7yg3NmFpU1XYEy/HR4dHotk6NbZ U+VdGmLBLVaXALm0bc3Jv+5bUIIxaM6zaabjlOsRR1LIqCQwcxx79nkalqNYCXJIW/o+Ft3MwkJrT U06eHyTXB3+UwhRJGZAjummVYfLOHJGTBVfm3o37AycFSjaXXx8a1L0guxP1Fstsi5Plmox2+doFU RDZm3QP1tPKOj8TdRY/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2tiU-00G4nf-25; Tue, 14 Nov 2023 13:44:34 +0000 Received: from mail-oi1-f173.google.com ([209.85.167.173]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r2tiR-00G4ma-1v; Tue, 14 Nov 2023 13:44:33 +0000 Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3b2f2b9a176so3671768b6e.0; Tue, 14 Nov 2023 05:44:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699969469; x=1700574269; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fVoXranZuhbJagmViZ0Bh2J7LLpRAZVBS/w9Sa8ohYo=; b=v8/PY3sGt2X9Nv2Bjpid55177DtOO7C/dZtqZb4PXJOnvxQcfpUEWjDO3XSbFTVshV vksoQIBQEm/UQIt+gMCHIEchRgK2nC8pEwd1zNY/dAIjtFt3s15KZwi5MKEyXaFQVBgJ 7pO5FKzpXAOzd2LQY0NrWWAvehMzSa3BFuGSD4hqbCld7BegswsD52gR1B/ip1/z+KsP kWrpGqZYWfdZmH8YVQEaw6/VjXHq/V71fMLZPUZOZd9ubLc7BfshvrdV7Ctp6qbQP44M fVmIjpImExqFK7PR55mG6/hTfbpPUMvaZIHn0txWBzGwbccnfr7b0It8eqykNJN47+VM rh5w== X-Gm-Message-State: AOJu0Yz8MyC+tTaRGJNMQmO2MORYWL4X/2C6J1m4PN3fFL8Ty2JREDYE N3HwOdFWvStlG8uUibosgQ== X-Google-Smtp-Source: AGHT+IEa2yiGK/vrgIGrYDQftkP/r/QgCl5oWffc3V6kN1weHVqSkoufro4lODlc4XqFTDIWhqoefQ== X-Received: by 2002:aca:f07:0:b0:3b6:cc01:aba2 with SMTP id 7-20020aca0f07000000b003b6cc01aba2mr10713866oip.55.1699969469146; Tue, 14 Nov 2023 05:44:29 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id k13-20020a54440d000000b003ac9e775706sm1115062oiw.1.2023.11.14.05.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 05:44:28 -0800 (PST) Received: (nullmailer pid 1651909 invoked by uid 1000); Tue, 14 Nov 2023 13:44:27 -0000 Date: Tue, 14 Nov 2023 07:44:27 -0600 From: Rob Herring To: Daniel Golle Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Heiner Kallweit , Russell King , Alexander Couzens , Philipp Zabel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org Subject: Re: [RFC PATCH 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings Message-ID: <20231114134427.GB1645963-robh@kernel.org> References: <924c2c6316e6d51a17423eded3a2c5c5bbf349d2.1699565880.git.daniel@makrotopia.org> <797ea94b-9c26-43a2-85d7-633990ed8c57@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231114_054431_632368_E4F9D64E X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 09, 2023 at 11:11:02PM +0000, Daniel Golle wrote: > Hi Andrew, > > On Thu, Nov 09, 2023 at 10:55:55PM +0100, Andrew Lunn wrote: > > > + mediatek,usxgmii-performance-errata: > > > + $ref: /schemas/types.yaml#/definitions/flag > > > + description: > > > + USXGMII0 on MT7988 suffers from a performance problem in 10GBase-R > > > + mode which needs a work-around in the driver. The work-around is > > > + enabled using this flag. > > > > Is there more details about this? I'm just wondering if this should be > > based on the compatible, rather than a bool property. > > The vendor sources where this is coming from are here: > > https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/a500d94cd47e279015ce22947e1ce396a7516598%5E%21/#F0 > > And I'm afraid this is as much detail as it gets. And yes, we could > also base this on the compatible and just have two different ones for > the two PEXTP instances found in MT7988. > Let me know your conclusion in that regard. I'd go with a property in this case unless you think there may be other per instance differences. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel