From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C081EC54FB9 for ; Wed, 15 Nov 2023 20:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qVUlmYoWzDn6TEuVB7TOMWKDFXSzw75P025WgPF54N4=; b=0ix7jq0DYr0o2GPJ6xBsWU0ihe pa+RexdHfK/UXpFIMq7ACZMrLW4EB3Oz6bN2a5ep+ZQAKxJ5+OdPdKNTav6N+qylh3Tp1TJpqLbL1 K+CLvqgSqDc/ku2kcXyACF/UeZgzE899vot4Lmt4J2rZOpNRhFTxBwuBgOzFuJj6shcAxQjCEYU67 MPU6v7fSfTrrB0JE8GYEHqDM4MplPNDrTNwhfe/QgbFpdBVpvrYPdkXOWZRflEe5/v3PQ0+KCeme4 k+lvma1F5yOjDLueHh+NpTdE1XkOvovs8+GrnXk5gg/X3FPjL0JCpZuZkwIFuriR8eyQD7qEouOmc GiERnKNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3M7I-001dwm-1J; Wed, 15 Nov 2023 20:04:04 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3M7F-001dvq-09 for linux-arm-kernel@lists.infradead.org; Wed, 15 Nov 2023 20:04:02 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 577F9B81BF1; Wed, 15 Nov 2023 20:03:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C8DAC433C8; Wed, 15 Nov 2023 20:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700078636; bh=9gA1SSlMEsWjuei3UKMYBTh6Esefr+kPZMNw658qCGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gZ96er5fDI3Hrb3A0NBZbCcphakUE0V2O2qg43+oZzgiIa190iQWAygYvFtYt1QC8 sbjYuVb1iQRPw669JELGD3SJzo6klfKnjGTpDcgPowfMMfUD1jRn9b56m4RfFUHmrR J4dAnzVJqDmHxJSIU6f3tE7vagsHghIOw1iDi2Xjrfwd3AR5HHcKGeNYF/JyFJwiPr IzgmzR2FpqWPY4hOAMcumaCGcrPakgQS5MDiMs45aRGAWuvbx585BWY4diqDNPUMN6 hcvimuhX3E6N2AO0g/RCBn2E5kFXlpCpI/oLs2pR6UedqeGyZ5DhULYrjcxZb0Blhp a/UTy5JDVGhEA== Date: Wed, 15 Nov 2023 20:03:53 +0000 From: Conor Dooley To: Ji Sheng Teoh Cc: Will Deacon , Mark Rutland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Peter Zijlstra , Ley Foon Tan , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] dt-bindings: perf: starfive: Add StarLink PMU Message-ID: <20231115-landing-earflap-ed11982ac610@squawk> References: <20231115033608.1597807-1-jisheng.teoh@starfivetech.com> <20231115033608.1597807-3-jisheng.teoh@starfivetech.com> MIME-Version: 1.0 In-Reply-To: <20231115033608.1597807-3-jisheng.teoh@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231115_120401_371442_5F7C33C5 X-CRM114-Status: GOOD ( 24.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5598409789720484474==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5598409789720484474== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HD0SkcLTdpU4AA/8" Content-Disposition: inline --HD0SkcLTdpU4AA/8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Yo, On Wed, Nov 15, 2023 at 11:36:08AM +0800, Ji Sheng Teoh wrote: > Add device tree binding for StarFive's StarLink PMU (Performance > Monitor Unit). >=20 > Signed-off-by: Ji Sheng Teoh > --- > .../bindings/perf/starfive,starlink-pmu.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/perf/starfive,starl= ink-pmu.yaml >=20 > diff --git a/Documentation/devicetree/bindings/perf/starfive,starlink-pmu= =2Eyaml b/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > new file mode 100644 > index 000000000000..a9426a7faeae > --- /dev/null > +++ b/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml btw, since you changed the compatible, the filename should have been changed to match it. > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/perf/starfive,starlink-pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive StarLink PMU > + > +maintainers: > + - Ji Sheng Teoh > + > +description: > + StarFive's StarLink PMU integrates one or more CPU cores with a shared= L3 > + memory system. The PMU support overflow interrupt, up to 16 programmab= le > + 64bit event counters, and an independent 64bit cycle counter. > + StarLink PMU is accessed via MMIO. > + > +properties: > + compatible: > + const: starfive,starlink-500-pmu So this is not what I had in mind by a "device". I was looking for a compatible representing an soc in which this IP had been integrated. A soc-specific compatible, rather than something generic, is requirement for devicetree - we don't want various integrations of this IP to all be using a generic compatible when there may be subtle (or less subtle) differences between integrations. I'm trying to come up with the syntax for enforcing having two compatibles with your current one as the fallback, but I have yet to come up with the correct syntax for that that works correctly. Hopefully by the time you get some feedback on the driver side of this submission I will have a concrete suggestion for what to do here. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + soc { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + > + l3_pmu: pmu@12900000 { This label here is never used and should be dropped. Cheers. Conor. > + compatible =3D "starfive,starlink-500-pmu"; > + reg =3D <0x0 0x12900000 0x0 0x10000>; > + interrupts =3D <34>; > + }; > + }; > --=20 > 2.25.1 >=20 --HD0SkcLTdpU4AA/8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZVUkJQAKCRB4tDGHoIJi 0n3NAQD0knou/atomQF2Z85HnmH/aE8gajj97pHsdl855DMM9AEAv0JCQx/Icnxb sWr3jQAML5n6hsxtgPM9lOA5D8h1NQQ= =Cv0H -----END PGP SIGNATURE----- --HD0SkcLTdpU4AA/8-- --===============5598409789720484474== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5598409789720484474==--