From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDED5C2BB3F for ; Wed, 15 Nov 2023 19:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DH5dDAnEUX9yd93tNcVTOXlYmk3TnkAXrQ5lxxXeSFw=; b=EQqb8D3RUtOHre wF9Cd9KU8qmdnyNGpQYW4t3JkTQH8XEiYl3HmA3em7l/NVyllQi1tWP+Dwt2qOOj+oUJvotMzpsED J1YCCIVdFAOx3xMOZ7Or9ACnv8RTISBNg7932mTFTwd3TQW6Jbbj6AWYCDIqNr/uxFn2dVht7MriV 0/ZW9yqOPy9Ez3lT9f8fs0LIakB/X3CZTcAb6aWtJvEz8F0AQPuJmarCwppQ26CukYWTI3KX4KilP eL0Eyj5lXVu3+AZWlvApL56Lc4qUceLDbGWWcUCr1Y4aZpUHoOOg6fSg+NP/iSEb7emdTWsjLj0EJ OvqMsfnrLYjfUHG1BBgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3M01-001ctl-0E; Wed, 15 Nov 2023 19:56:33 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3Lzz-001ctB-06; Wed, 15 Nov 2023 19:56:32 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EC1964A4; Wed, 15 Nov 2023 20:56:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1700078163; bh=6JOB/9VYx7h3AYgO11Fk1AxgBXD3Uh3mlJ3vucexPmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kKKw1mBwlTa4Eq+tDYltUVDm6XnYh4h5DEawKF8NvPJq1YT4nP3LHHQ1OQgcBLCC+ 1t5U6MKgDtCvS4Wgw9BGpIX1W7shw/9+Za7ranUsJ5JlZ/wu9LqZeJQCIg9fkhcuw3 YQaBG7pgqankbpm62iVXLuinAfsg3dGwT8WDG/98= Date: Wed, 15 Nov 2023 21:56:34 +0200 From: Laurent Pinchart To: Stefan Wahren Cc: Umang Jain , linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Dave Stevenson , Kieran Bingham , "Ricardo B . Marliere" , Dan Carpenter Subject: Re: [PATCH v2 01/15] staging: vc04_services: Add new vc-sm-cma driver Message-ID: <20231115195634.GC29486@pendragon.ideasonboard.com> References: <20231109210309.638594-1-umang.jain@ideasonboard.com> <20231109210309.638594-2-umang.jain@ideasonboard.com> <5263ecbd-23af-4889-a7e0-b21aaf8bcfe0@i2se.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5263ecbd-23af-4889-a7e0-b21aaf8bcfe0@i2se.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231115_115631_212059_C45EA9FD X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 13, 2023 at 06:56:06PM +0100, Stefan Wahren wrote: > Hi Umang, > > Am 09.11.23 um 22:02 schrieb Umang Jain: > > From: Dave Stevenson > > > > Add Broadcom VideoCore Shared Memory support. > > > > This new driver allows contiguous memory blocks to be imported > > into the VideoCore VPU memory map, and manages the lifetime of > > those objects, only releasing the source dmabuf once the VPU has > > confirmed it has finished with it. > > > > Signed-off-by: Dave Stevenson > > Signed-off-by: Umang Jain > > --- > > drivers/staging/vc04_services/Kconfig | 2 + > > drivers/staging/vc04_services/Makefile | 2 +- > > .../staging/vc04_services/vc-sm-cma/Kconfig | 10 + > > .../staging/vc04_services/vc-sm-cma/Makefile | 4 + > > .../staging/vc04_services/vc-sm-cma/vc_sm.c | 817 ++++++++++++++++++ > > .../staging/vc04_services/vc-sm-cma/vc_sm.h | 54 ++ > > .../vc04_services/vc-sm-cma/vc_sm_cma_vchi.c | 507 +++++++++++ > > .../vc04_services/vc-sm-cma/vc_sm_cma_vchi.h | 63 ++ > > .../vc04_services/vc-sm-cma/vc_sm_defs.h | 187 ++++ > > .../vc04_services/vc-sm-cma/vc_sm_knl.h | 28 + > > 10 files changed, 1673 insertions(+), 1 deletion(-) > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/Kconfig > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/Makefile > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm.c > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm.h > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.c > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.h > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_defs.h > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_knl.h [snip] > > diff --git a/drivers/staging/vc04_services/vc-sm-cma/vc_sm.c b/drivers/staging/vc04_services/vc-sm-cma/vc_sm.c > > new file mode 100644 > > index 000000000000..5bbdb3a8468b > > --- /dev/null > > +++ b/drivers/staging/vc04_services/vc-sm-cma/vc_sm.c > > @@ -0,0 +1,817 @@ [snip] > > +/* ---- Private Variables ----------------------------------------------- */ > > + > > +static struct sm_state_t *sm_state; > > +static int sm_inited; > > In case the driver cannot be loaded again, a comment about this should > be here. Better, could we remove global variables ? [snip] -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel