From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66F60C54FB9 for ; Thu, 16 Nov 2023 14:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g4QJ3eHS9DwupZUFYuZsIFhYdusjeUQE+t75gFaSZNU=; b=HOjqkph6HoCC06X/Ih4nLIZKh7 LY0N65ovcWeUASsJopu6+h1MIg3PWjBurEkB6k4N2kSpJ7kSm5vnXCGm4eYskYEFNO7AgWY0EsjaS FR3yOnEfoOLvblV96Sl2FlXesBYiqQJlRRdEQcH+KUdTMKnSdY+5XLoQhsyPCbg6PnsWSOvJk+7Iy Csvw+4/Y1d9V5zxQPc2s2mRse3BadHyTtv71yN/fEAn8sToUBJWfmbWWGDWh9W5NCgyu8+le+hx7y FRw0SsojRfnMP0jrsJ4scEjW2kB6GkdgBcPctuOl8VKRWhfQXrDWDRA8uQZWy4P+BdAB6Cr1ivS4/ FyfRMCAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3dRY-003iEv-2d; Thu, 16 Nov 2023 14:34:08 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3dRV-003iDv-34 for linux-arm-kernel@lists.infradead.org; Thu, 16 Nov 2023 14:34:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 43C11CE1FF6; Thu, 16 Nov 2023 14:34:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CF14C433C8; Thu, 16 Nov 2023 14:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700145243; bh=FiM5uoBP4dPLMB8pp4YAe7ANs6BDZ5GS+5pPKeBh66g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B+cMhHynOBWDxN7MDjAB6t4bYMechNEoM4SnXHn3Z/93Jf0IThJwuyJ/YJ9yjP5HX 0l4CMw/zHNYifJ39j4Y//zETebY0hgdpLKxukD0dCZ0jftD3gYG2j6amc7EQBQB+zk nKkWVHB4ncjS71GvL0gte0cNnY8yESiiqTQPOzuqXwHkMfrCD40q7DEMxKLiC07S6f ulvILHl+g601D7tUNCtK3gMSfTfmF0X76uiqdrAsxkcrfJRKZtjq+Fnq0mK1sjDP8x UTHOU2jywHheXAnlZnFGdWFMUWUH+rmrS9wwVQYzY0WJQSOVtA7SvBQH8+oyFBF2mR j5OXv+qT6szkw== Date: Thu, 16 Nov 2023 14:34:00 +0000 From: Conor Dooley To: Ji Sheng Teoh Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, leyfoon.tan@starfivetech.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, peterz@infradead.org, robh+dt@kernel.org, tglx@linutronix.de, will@kernel.org Subject: Re: [PATCH v3 2/2] dt-bindings: perf: starfive: Add StarLink PMU Message-ID: <20231116-penalize-turbojet-bf8ea2a9a2ad@squawk> References: <20231115-landing-earflap-ed11982ac610@squawk> <20231116021035.4043907-1-jisheng.teoh@starfivetech.com> MIME-Version: 1.0 In-Reply-To: <20231116021035.4043907-1-jisheng.teoh@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231116_063406_337612_BC20FFC9 X-CRM114-Status: GOOD ( 35.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5606888476409483578==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5606888476409483578== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vZUGkCs0d2KdwaC/" Content-Disposition: inline --vZUGkCs0d2KdwaC/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 16, 2023 at 10:10:35AM +0800, Ji Sheng Teoh wrote: > On Wed, 15 Nov 2023 20:03:53 +0000 > Conor Dooley wrote: > > On Wed, Nov 15, 2023 at 11:36:08AM +0800, Ji Sheng Teoh wrote: > > > Add device tree binding for StarFive's StarLink PMU (Performance > > > Monitor Unit). > > >=20 > > > Signed-off-by: Ji Sheng Teoh > > > --- > > > .../bindings/perf/starfive,starlink-pmu.yaml | 46 > > > +++++++++++++++++++ 1 file changed, 46 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > > >=20 > > > diff --git > > > a/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > > > b/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > > > new file mode 100644 index 000000000000..a9426a7faeae --- /dev/null > > > +++ > > > b/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > > > =20 > >=20 > > btw, since you changed the compatible, the filename should have been > > changed to match it. >=20 > The intention to keep the filename generic is to allow addition of new > version of StarLink PMU in future if any, similar to what arm,cmn.yaml > is doing. Hope that makes sense. No, please keep the filename matching the compatible. Even if the filename contains "500", there's nothing stopping you from then adding other pmu variants. There are many many examples of this in the tree. > > > @@ -0,0 +1,46 @@ > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/perf/starfive,starlink-pmu.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: StarFive StarLink PMU > > > + > > > +maintainers: > > > + - Ji Sheng Teoh > > > + > > > +description: > > > + StarFive's StarLink PMU integrates one or more CPU cores with a > > > shared L3 > > > + memory system. The PMU support overflow interrupt, up to 16 > > > programmable > > > + 64bit event counters, and an independent 64bit cycle counter. > > > + StarLink PMU is accessed via MMIO. > > > + > > > +properties: > > > + compatible: > > > + const: starfive,starlink-500-pmu =20 > >=20 > > So this is not what I had in mind by a "device". I was looking for a > > compatible representing an soc in which this IP had been integrated. > > A soc-specific compatible, rather than something generic, is > > requirement for devicetree - we don't want various integrations of > > this IP to all be using a generic compatible when there may be subtle > > (or less subtle) differences between integrations. > >=20 > > I'm trying to come up with the syntax for enforcing having two > > compatibles with your current one as the fallback, but I have yet to > > come up with the correct syntax for that that works correctly. > >=20 > > Hopefully by the time you get some feedback on the driver side of this > > submission I will have a concrete suggestion for what to do here. >=20 > Thanks Conor for the enlightenment. In the meantime, to fit the requireme= nt > I would suggest going for "starfive,jh8100-starlink-pmu", making it JH8100 > SOC specific if that makes sense. Okay, you could definitely do that! Cheers, Conor. --vZUGkCs0d2KdwaC/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZVYoVgAKCRB4tDGHoIJi 0jrqAP9DgqOaWCgCUMw/6lyacLL6RmvNrLfL+z/IOcfGcjzDmQEA4+no0sYz9JiW dJwGk8nkps3Om/UUGm1tlKn4TdWBbgc= =BTKI -----END PGP SIGNATURE----- --vZUGkCs0d2KdwaC/-- --===============5606888476409483578== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5606888476409483578==--