From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92ADBC072A2 for ; Sun, 19 Nov 2023 13:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0xeukVehQiFQVUX6ObCIXSwfpraVpTs78v/pDJukZ5E=; b=Nat+ggfFBeLrZa9Fo+n5LaMNOb 0k57/B8UlcBxVChs2kkOlnAJIOHGakPgTv2oYkhGYYdS0LLsQwuR5bLamZFzoPMNuMudZDicWpY+f 6Ca6a5PfgEjGIcHO7d2RrNVothvi0Yxw7AqIJTvNp6aiMsentoh11mfBZnlGedED8UyXqHz4eA7Iv O8wuWhd1p3P5Uio8qHyigz0NzebKl8z3a3yy/egrUJRio2MyvLupum0yQ7SCK+wXrLm5YKMVD2YcB k0MSQDDieoVG4G9C2lnM5/gvacdtyWwj6X1s7Mu+3DBSf2oVP0IwFsoHqpFfC1G5R7h8hryQLfKCF U3UjMPWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r4hwk-00AEX3-2D; Sun, 19 Nov 2023 13:34:46 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r4hwh-00AEWc-19 for linux-arm-kernel@lists.infradead.org; Sun, 19 Nov 2023 13:34:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id CA3E6B80BA4; Sun, 19 Nov 2023 13:34:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9934FC433C8; Sun, 19 Nov 2023 13:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700400880; bh=gRy63m5oP/eWC/wD8dCNRHAQkB1ST3bcQJr/HYdhsh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oz9FhMObmBmJL//1ggZ/WYka61XnaOKnxASiIecv4k2Ck/fiaD+P/ymRKE8ICOeOW FGsejM8suwiVXBkj5t+hY1GLgTzaEF5AZC12Yu53VeXjNZjsI9Tg2UZMO4EbZ+RUKn 1V5prOlZxOsG6GI6TZJWbmAMZd8NzJRI0Ja3EDS9eXTzx2Js4AI5FpJ31x373wiBAo ofneWTeA+1rxC2YhaA123MP6BefDoLYozE5MbdYHq7EhKgDyid+Z34wvb3HexQLa/k UbEn+23GI+ZcR9mb4LoBMX3QBJ+G9Zbtmbes+WbhQ8DSgYGyVPrebkreEc2H2yAQZp 6KPTouC5iSZSg== Date: Sun, 19 Nov 2023 13:34:35 +0000 From: Conor Dooley To: Elad Nachman Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pali@kernel.org, mrkiko.rs@gmail.com, chris.packham@alliedtelesis.co.nz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cyuval@marvell.com Subject: Re: [PATCH v5 2/3] dt-bindings: arm64: add Marvell COM Express boards Message-ID: <20231119-avatar-implicate-75cd2f12dff5@spud> References: <20231119102638.1041978-1-enachman@marvell.com> <20231119102638.1041978-3-enachman@marvell.com> MIME-Version: 1.0 In-Reply-To: <20231119102638.1041978-3-enachman@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231119_053443_551229_2CF5B47D X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2112216838241390997==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2112216838241390997== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bpE9nlwIO/xMULOZ" Content-Disposition: inline --bpE9nlwIO/xMULOZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 19, 2023 at 12:26:37PM +0200, Elad Nachman wrote: > From: Elad Nachman >=20 > Add dt bindings for: > CN9130 COM Express CPU module Did you forget this one? There's only the CN9191 system here. > CN9131 COM Express CPU module > AC5X RD COM Express Type 7 carrier board. > AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module. >=20 > Signed-off-by: Elad Nachman > --- > .../bindings/arm/marvell/armada-7k-8k.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.y= aml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..6b19f23bcf63 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,16 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > =20 > + - description: > + Alleycat5X (98DX35xx) Reference Design as COM Express Carrie= r plus > + Armada CN9131 COM Express CPU module > + items: > + - enum: > + - marvell,ac5x-car-with-cn9131 Why not just marvell,cn9131-ac5x-carrier or similar? The "with" isn't particularly helpful. Cheers, Conor. > + - const: marvell,rd-ac5x-carrier > + - const: marvell,cn9131-cpu-module > + - const: marvell,cn9131 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > additionalProperties: true > --=20 > 2.25.1 >=20 --bpE9nlwIO/xMULOZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZVoO6wAKCRB4tDGHoIJi 0kxzAQDIfFI+4D2QNGfT6wBPbYpCaJ1MkWDRfkjLXjPko/hmegEAjvIIcJgfVeUr PLVO2PiimvxVQH4b9rJT75dpFQOHYwM= =7ZHL -----END PGP SIGNATURE----- --bpE9nlwIO/xMULOZ-- --===============2112216838241390997== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2112216838241390997==--