public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Migrate MT8188 VPPSYS 0/1 to mtk-mmsys driver
@ 2023-11-17  5:39 yu-chang.lee
  2023-11-17  5:39 ` [PATCH v3 1/2] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS yu-chang.lee
  2023-11-17  5:39 ` [PATCH v3 2/2] dt-bindings: arm: mediatek: mmsys: Add VPPSYS compatible for MT8188 yu-chang.lee
  0 siblings, 2 replies; 5+ messages in thread
From: yu-chang.lee @ 2023-11-17  5:39 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Michael Turquette,
	Stephen Boyd, Matthias Brugger, AngeloGioacchino Del Regno
  Cc: Garmin Chang, devicetree, linux-kernel, linux-clk,
	linux-arm-kernel, linux-mediatek,
	Project_Global_Chrome_Upstream_Group, yu-chang . lee

Changes in v3:
- Separate binding patch from driver patch

Changes in v2:
- Refine commit message
- Refine commit title

Hi,

The purpose of series is to separate MT8188 VPPSYS-related binding patch
from the original mailing list mentioned below:
https://lore.kernel.org/all/20231116080129.20617-1-yu-chang.lee@mediatek.com/

These binding files reflect VPPSYS' dependency on mtk-mmsys for mediatek
MT8188 platform.


yu-chang.lee (2):
  dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS
  dt-bindings: arm: mediatek: mmsys: Add VPPSYS compatible for MT8188

 .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml        | 2 ++
 .../devicetree/bindings/clock/mediatek,mt8188-clock.yaml        | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 1/2] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS
  2023-11-17  5:39 [PATCH v3 0/2] Migrate MT8188 VPPSYS 0/1 to mtk-mmsys driver yu-chang.lee
@ 2023-11-17  5:39 ` yu-chang.lee
  2023-11-19 13:13   ` Conor Dooley
  2023-11-17  5:39 ` [PATCH v3 2/2] dt-bindings: arm: mediatek: mmsys: Add VPPSYS compatible for MT8188 yu-chang.lee
  1 sibling, 1 reply; 5+ messages in thread
From: yu-chang.lee @ 2023-11-17  5:39 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Michael Turquette,
	Stephen Boyd, Matthias Brugger, AngeloGioacchino Del Regno
  Cc: Garmin Chang, devicetree, linux-kernel, linux-clk,
	linux-arm-kernel, linux-mediatek,
	Project_Global_Chrome_Upstream_Group, yu-chang . lee

MT8188 VPPSYS 0/1 should be probed from mtk-mmsys driver to
populate device by platform_device_register_data then start
its own clock driver.

Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
---
 .../devicetree/bindings/clock/mediatek,mt8188-clock.yaml        | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
index d7214d97b2ba..860570320545 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
@@ -43,8 +43,6 @@ properties:
       - mediatek,mt8188-vdecsys
       - mediatek,mt8188-vdecsys-soc
       - mediatek,mt8188-vencsys
-      - mediatek,mt8188-vppsys0
-      - mediatek,mt8188-vppsys1
       - mediatek,mt8188-wpesys
       - mediatek,mt8188-wpesys-vpp0
 
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 2/2] dt-bindings: arm: mediatek: mmsys: Add VPPSYS compatible for MT8188
  2023-11-17  5:39 [PATCH v3 0/2] Migrate MT8188 VPPSYS 0/1 to mtk-mmsys driver yu-chang.lee
  2023-11-17  5:39 ` [PATCH v3 1/2] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS yu-chang.lee
@ 2023-11-17  5:39 ` yu-chang.lee
  1 sibling, 0 replies; 5+ messages in thread
From: yu-chang.lee @ 2023-11-17  5:39 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Michael Turquette,
	Stephen Boyd, Matthias Brugger, AngeloGioacchino Del Regno
  Cc: Garmin Chang, devicetree, linux-kernel, linux-clk,
	linux-arm-kernel, linux-mediatek,
	Project_Global_Chrome_Upstream_Group, yu-chang . lee

For MT8188, VPPSYS0 and VPPSYS1 are 2 display pipes with
hardware differences in power domains, clocks and subsystem counts,
which should be determined by compatible names.

Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
---
 .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml        | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
index 536f5a5ebd24..50324248b965 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
@@ -32,6 +32,8 @@ properties:
               - mediatek,mt8183-mmsys
               - mediatek,mt8186-mmsys
               - mediatek,mt8188-vdosys0
+              - mediatek,mt8188-vppsys0
+              - mediatek,mt8188-vppsys1
               - mediatek,mt8192-mmsys
               - mediatek,mt8195-vdosys1
               - mediatek,mt8195-vppsys0
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS
  2023-11-17  5:39 ` [PATCH v3 1/2] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS yu-chang.lee
@ 2023-11-19 13:13   ` Conor Dooley
  2023-11-19 13:25     ` Conor Dooley
  0 siblings, 1 reply; 5+ messages in thread
From: Conor Dooley @ 2023-11-19 13:13 UTC (permalink / raw)
  To: yu-chang.lee
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Michael Turquette,
	Stephen Boyd, Matthias Brugger, AngeloGioacchino Del Regno,
	Garmin Chang, devicetree, linux-kernel, linux-clk,
	linux-arm-kernel, linux-mediatek,
	Project_Global_Chrome_Upstream_Group


[-- Attachment #1.1: Type: text/plain, Size: 1179 bytes --]

On Fri, Nov 17, 2023 at 01:39:33PM +0800, yu-chang.lee wrote:
> MT8188 VPPSYS 0/1 should be probed from mtk-mmsys driver to
> populate device by platform_device_register_data then start
> its own clock driver.

How does one operating system's driver probing model render these
compatibles invalid?

Cheers,
Conor.

> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
> ---
>  .../devicetree/bindings/clock/mediatek,mt8188-clock.yaml        | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
> index d7214d97b2ba..860570320545 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
> @@ -43,8 +43,6 @@ properties:
>        - mediatek,mt8188-vdecsys
>        - mediatek,mt8188-vdecsys-soc
>        - mediatek,mt8188-vencsys
> -      - mediatek,mt8188-vppsys0
> -      - mediatek,mt8188-vppsys1
>        - mediatek,mt8188-wpesys
>        - mediatek,mt8188-wpesys-vpp0
>  
> -- 
> 2.18.0
> 
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS
  2023-11-19 13:13   ` Conor Dooley
@ 2023-11-19 13:25     ` Conor Dooley
  0 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2023-11-19 13:25 UTC (permalink / raw)
  To: yu-chang.lee
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Michael Turquette,
	Stephen Boyd, Matthias Brugger, AngeloGioacchino Del Regno,
	Garmin Chang, devicetree, linux-kernel, linux-clk,
	linux-arm-kernel, linux-mediatek,
	Project_Global_Chrome_Upstream_Group


[-- Attachment #1.1: Type: text/plain, Size: 534 bytes --]

On Sun, Nov 19, 2023 at 01:13:47PM +0000, Conor Dooley wrote:
> On Fri, Nov 17, 2023 at 01:39:33PM +0800, yu-chang.lee wrote:
> > MT8188 VPPSYS 0/1 should be probed from mtk-mmsys driver to
> > populate device by platform_device_register_data then start
> > its own clock driver.
> 
> How does one operating system's driver probing model render these
> compatibles invalid?

I see there are 2 patches in the series. Merging them into one would
likely make it easier to explain the hardware-related reason for this
change.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-11-19 13:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-17  5:39 [PATCH v3 0/2] Migrate MT8188 VPPSYS 0/1 to mtk-mmsys driver yu-chang.lee
2023-11-17  5:39 ` [PATCH v3 1/2] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS yu-chang.lee
2023-11-19 13:13   ` Conor Dooley
2023-11-19 13:25     ` Conor Dooley
2023-11-17  5:39 ` [PATCH v3 2/2] dt-bindings: arm: mediatek: mmsys: Add VPPSYS compatible for MT8188 yu-chang.lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox