From: Raag Jadav <raag.jadav@intel.com>
To: mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, rafael@kernel.org,
lenb@kernel.org, robert.moore@intel.com, ardb@kernel.org,
will@kernel.org, mark.rutland@arm.com
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v2 5/6] efi: dev-path-parser: use acpi_dev_uid_match() for matching _UID
Date: Tue, 21 Nov 2023 16:08:28 +0530 [thread overview]
Message-ID: <20231121103829.10027-6-raag.jadav@intel.com> (raw)
In-Reply-To: <20231121103829.10027-1-raag.jadav@intel.com>
Now that we have _UID matching support for integer types, we can use
acpi_dev_uid_match() for it.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/firmware/efi/dev-path-parser.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/efi/dev-path-parser.c b/drivers/firmware/efi/dev-path-parser.c
index f80d87c199c3..937be269fee8 100644
--- a/drivers/firmware/efi/dev-path-parser.c
+++ b/drivers/firmware/efi/dev-path-parser.c
@@ -18,8 +18,6 @@ static long __init parse_acpi_path(const struct efi_dev_path *node,
struct acpi_device *adev;
struct device *phys_dev;
char hid[ACPI_ID_LEN];
- u64 uid;
- int ret;
if (node->header.length != 12)
return -EINVAL;
@@ -31,10 +29,9 @@ static long __init parse_acpi_path(const struct efi_dev_path *node,
node->acpi.hid >> 16);
for_each_acpi_dev_match(adev, hid, NULL, -1) {
- ret = acpi_dev_uid_to_integer(adev, &uid);
- if (ret == 0 && node->acpi.uid == uid)
+ if (acpi_dev_uid_match(adev, node->acpi.uid))
break;
- if (ret == -ENODATA && node->acpi.uid == 0)
+ if (!acpi_device_uid(adev) && node->acpi.uid == 0)
break;
}
if (!adev)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-21 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 10:38 [PATCH v2 0/6] Support _UID matching for integer types Raag Jadav
2023-11-21 10:38 ` [PATCH v2 1/6] compiler.h: Introduce helpers for identifying array and pointer types Raag Jadav
2023-11-21 10:38 ` [PATCH v2 2/6] ACPI: bus: update acpi_dev_uid_match() to support multiple types Raag Jadav
2023-11-21 16:50 ` Mika Westerberg
2023-11-21 19:25 ` Rafael J. Wysocki
2023-11-22 4:58 ` Raag Jadav
2023-11-22 11:55 ` Rafael J. Wysocki
2023-11-22 10:12 ` Andy Shevchenko
2023-11-21 10:38 ` [PATCH v2 3/6] ACPI: bus: update acpi_dev_hid_uid_match() " Raag Jadav
2023-11-21 16:52 ` Mika Westerberg
2023-11-21 10:38 ` [PATCH v2 4/6] ACPI: LPSS: use acpi_dev_uid_match() for matching _UID Raag Jadav
2023-11-21 16:52 ` Mika Westerberg
2023-11-21 10:38 ` Raag Jadav [this message]
2023-11-21 16:19 ` [PATCH v2 5/6] efi: dev-path-parser: " Ard Biesheuvel
2023-11-21 10:38 ` [PATCH v2 6/6] perf: arm_cspmu: drop redundant acpi_dev_uid_to_integer() Raag Jadav
2023-11-21 15:59 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121103829.10027-6-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=bala.senthil@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).