From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88C89C61D92 for ; Tue, 21 Nov 2023 10:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sQ83UMrDSaWUWojSg+zKQ05sMdxTwtAKlibQE8xOM/U=; b=p7B+3T0tqnIckl z7XCirTS4jdKcuHIOn62UFWIrwAjm2vgtTEqyrmH+MFAwS5ujgNxFPIxzVFQiIPu85EMgCLLZyIx+ 2Y4UJ5pRiQb6vCAOKMg28/+GbvQ6U7nUEmYDPaPJ3Me4KNJ1Fu9uxT58RsAZKk7nvkocjHCgQYn9j ycGB/7w2vTof846temehz2wYfS8BpJqvfJfsR/6TMjtWRYS+VIrvX8lB7OoqXZR1LwMhC7YIENodc 1T40umh7MReq6ijkBKGKRA9wNePZK6hMwlNcuUpCeJWs9nLjYN+JrmdXHlvtS4lYX660ESPSt0lyE ZFmUnhMQtPVGylOYJSwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5OBx-00GIOB-2m; Tue, 21 Nov 2023 10:41:17 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5OBs-00GILx-2v for linux-arm-kernel@lists.infradead.org; Tue, 21 Nov 2023 10:41:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CD486CE1AEF; Tue, 21 Nov 2023 10:41:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42018C433C8; Tue, 21 Nov 2023 10:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700563268; bh=6ssmz9Fzj5B5OmCb07mIm3SGwRw9YGJdqqjNOMzjqjI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D4vK5vs4oL3icSXZydnqDM56wAeOdVXHDrdnc5HGhc07aObDsKuXDA6nPc9Kb/AjO tFTsFjQsYLFV6t2wKtWlJRyz8RSctyacMs0ecueARCS6ikBk4balsn1z9IN/cBBhf5 b8a4mu42V8h2H1j9aw4XOLMiz4gg1lBZeQc8Rcqdpa7CAMwhGOZUPS43Aoercery22 A+VWLfY9me9tZNzztinOEcud0MxToeqAgO3RzE+vgDoV0GfSa1VN6plMRXx4ONNNBw 52A1UllKq6WlZhEA3yy3s6mPDMlPFWkKB4LuyaHcT/uK52CcIyMSq30d/3K552YJil 8xS4+R7zYbMxg== Date: Tue, 21 Nov 2023 18:40:56 +0800 From: Peter Chen To: =?iso-8859-1?Q?Th=E9o?= Lebrun Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Roger Quadros , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ThomasPetazzonithomas.petazzoni@bootlin.com, =?iso-8859-1?Q?Gr=E9gory?= Clement Subject: Re: [PATCH v2 5/7] usb: cdns3: add quirk to platform data for reset-on-resume Message-ID: <20231121104056.GA541474@nchen-desktop> References: <20231120-j7200-usb-suspend-v2-0-038c7e4a3df4@bootlin.com> <20231120-j7200-usb-suspend-v2-5-038c7e4a3df4@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231120-j7200-usb-suspend-v2-5-038c7e4a3df4@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231121_024113_187760_3FE96783 X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-11-20 18:06:05, Th=E9o Lebrun wrote: > The cdns3 host role does not care about reset-on-resume. xHCI however > reconfigures itself in silence rather than printing a warning about a > resume error. Related warning example: > = > [ 16.017462] xhci-hcd xhci-hcd.1.auto: xHC error in resume, USBSTS 0x= 401, Reinit > = > Allow passing a CDNS3_RESET_ON_RESUME quirk flag from cdns3 pdata down > to xHCI pdata. The goal is to allow signaling about reset-on-resume > behavior from platform wrapper drivers. > = > When used, remote wakeup is not expected to work. > = > Signed-off-by: Th=E9o Lebrun Acked-by: Peter Chen > --- > drivers/usb/cdns3/core.h | 1 + > drivers/usb/cdns3/host.c | 3 +++ > 2 files changed, 4 insertions(+) > = > diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h > index 81a9c9d6be08..7487067ba23f 100644 > --- a/drivers/usb/cdns3/core.h > +++ b/drivers/usb/cdns3/core.h > @@ -44,6 +44,7 @@ struct cdns3_platform_data { > bool suspend, bool wakeup); > unsigned long quirks; > #define CDNS3_DEFAULT_PM_RUNTIME_ALLOW BIT(0) > +#define CDNS3_RESET_ON_RESUME BIT(1) > }; > = > /** > diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c > index 6164fc4c96a4..28c4d1deb231 100644 > --- a/drivers/usb/cdns3/host.c > +++ b/drivers/usb/cdns3/host.c > @@ -91,6 +91,9 @@ static int __cdns_host_init(struct cdns *cdns) > if (cdns->pdata && (cdns->pdata->quirks & CDNS3_DEFAULT_PM_RUNTIME_ALLO= W)) > cdns->xhci_plat_data->quirks |=3D XHCI_DEFAULT_PM_RUNTIME_ALLOW; > = > + if (cdns->pdata && (cdns->pdata->quirks & CDNS3_RESET_ON_RESUME)) > + cdns->xhci_plat_data->quirks |=3D XHCI_RESET_ON_RESUME; > + > ret =3D platform_device_add_data(xhci, cdns->xhci_plat_data, > sizeof(struct xhci_plat_priv)); > if (ret) > = > -- = > 2.42.0 > = -- = Thanks, Peter Chen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel