From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D088DC61D97 for ; Wed, 22 Nov 2023 12:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HFIG+Fs30auR30k0fCLc6gpu9tPhzLVrqW+FXOYeFhc=; b=CZ6Iz6w8vqA1+o 2o0NIQM8ldASazTgglo1Du9SI2yvb3LyeN2dXsBfeQBGdUHKsL2ZBKW5noSzGAtN90u8oEe0+fuSD IoZrgobRZx+EAnFIj+nCMzCfSO7IgEOJbWc7AUxYJbp001/JUzRfqyqju0RSy+ld9jwhznutGzXiJ +PD6mq7tp1OrO5No0VNgD3CQ+W0uRe5IyPumj8oVSQ2Y17MM4bs07Os/szs75vWVwRJ+qHWLNbZEy O5QrNkFEcOkk9UHF45aDBDeXE2ZAx8HIFYnFvVeq5zWLDCtB2XepHrhxx7/ecIVtwU6xw5iK6xELP FFf+7/paXeSxGeXT81/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5m42-001k5f-1T; Wed, 22 Nov 2023 12:10:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5m3z-001k4s-0l for linux-arm-kernel@lists.infradead.org; Wed, 22 Nov 2023 12:10:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 71BD161D59; Wed, 22 Nov 2023 12:10:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A65E0C433C9; Wed, 22 Nov 2023 12:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700655038; bh=wl0JFYvB32NP7y30q+NX9TJJbF3cXUAoYsHbwutxyDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L8PF9xHLNQicGYNp8JtaNyx/n8NDLkfwt2tBPdzukJLzsRucicY7f/SIUft+4P54x 7RuPTI8ETjaKi9ABpt5831/IdepwzgPfvCET6UsbhBN2/ZpPgdnZEt/TGd5IkwUPgW mRsQpX+OmnWmBwBINOlxM69RtI6EUvVlshgHQMhs= Date: Wed, 22 Nov 2023 12:10:34 +0000 From: Greg KH To: Kunwu Chan Cc: joel@jms.id.au, andrew@codeconstruct.com.au, andriy.shevchenko@linux.intel.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kunwu.chan@hotmail.com, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: aspeed: Check return value of kasprintf in ast_vhub_alloc_epn Message-ID: <2023112236-bullseye-pranker-491e@gregkh> References: <20231122014212.304254-1-chentao@kylinos.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231122014212.304254-1-chentao@kylinos.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231122_041039_659180_4885480B X-CRM114-Status: GOOD ( 15.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 22, 2023 at 09:42:12AM +0800, Kunwu Chan wrote: > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. Ensure the allocation was successful > by checking the pointer validity. > > Signed-off-by: Kunwu Chan > --- > drivers/usb/gadget/udc/aspeed-vhub/epn.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/epn.c b/drivers/usb/gadget/udc/aspeed-vhub/epn.c > index 148d7ec3ebf4..e0854e878411 100644 > --- a/drivers/usb/gadget/udc/aspeed-vhub/epn.c > +++ b/drivers/usb/gadget/udc/aspeed-vhub/epn.c > @@ -826,6 +826,8 @@ struct ast_vhub_ep *ast_vhub_alloc_epn(struct ast_vhub_dev *d, u8 addr) > ep->vhub = vhub; > ep->ep.ops = &ast_vhub_epn_ops; > ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", addr); > + if (!ep->ep.name) > + return NULL; This will break things if this ever triggers. How was this tested? The "slot" for this device will still be seen as used and so the resources never freed and then you can run out of space for real devices, right? Looks like the other error handling in this function below this call is also broken, can you fix that up too? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel