Re: [PATCH] arm64: dts: ti: k3-am625-sk: Add support for WL1837 module onboard

From: Nishanth Menon <nm@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	sukrut bellary <sukrut.bellary@gmail.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am625-sk: Add support for WL1837 module onboard
Date: Thu, 23 Nov 2023 01:10:15 -0600	[thread overview]
Message-ID: <20231123071015.is4sffvdkunko5ws@radar> (raw)
In-Reply-To: <20231121122441.64385-1-tony@atomide.com>

On 14:24-20231121, Tony Lindgren wrote:
> From: Vignesh Raghavendra <vigneshr@ti.com>
> 
> WL1837 WLAN card is present on the original AM625 SK board. It
> communicates with the SoC using 4 bit SDIO through the second instance of
> MMCSD.
> 
> Starting with SK-AM62B, there is a M.2 WLAN device connector instead of

We support AM62B-SK.

> the integrated WL1837 WLAN. The M.2 connector should be handled separately
> in the k3-am62a.dtsi and k3-am62b.dtsi files as needed.

Should this rather be an overlay instead of integrated dts fixup? M2
connector allows for various options including the newer 33xx family[2].

It makes sense for the regulator etc to be on the main dts file, but I
am not convinced about it being integrated as part of the dts.

> 
> Note that WLAN currently needs fw_devlink=permissive set on the command
> line. Not sure what is missing here but that seems like a separate change.
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> [tony@atomide.com: updated for pinctrl, improved comments]
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am625-sk.dts | 79 ++++++++++++++++++++++++++
>  1 file changed, 79 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> @@ -103,6 +103,32 @@ vcc_1v8: regulator-5 {
	[...]

> +	};
>  };
>  
>  &main_gpio0 {
> @@ -200,6 +253,32 @@ &sdhci1 {
>  	vqmmc-supply = <&vdd_sd_dv>;
>  };
>  
> +&sdhci2 {
> +	status = "okay";
> +	vmmc-supply = <&wlan_en>;

Should we use mmc-pwrseq ?
Looks like we have run into an issue in BeaglePlay with wlan_en
being always on for loading firmware. so is there a need to keep the
wlan on while suspended?

[1] https://sukrutb.github.io/s2d_TI_am625-BeaglePlay/ (see towards the
end)
[2] https://www.ti.com/tool/M2-CC3301

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel