From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C713C61DF7 for ; Thu, 23 Nov 2023 13:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=taNn5gz2NK3bVpK7QFMVPPlHgxoKGyEaJ0jlbNTxQWo=; b=CG+9EXkBWxoXCv q9QXDceMBAIeWwi6lI+dvGrMYiyeBSmJ7+Lk5UN+nKRjcAGnntUoLWM/Eioxh1Hl3FcgKuDIa74Ab myCwMssx1lxTxXKXyfpo76WcRwKOBuRmY7iUv6wyj+8pVBOyZKYso0q/xG8r5X+1k9q3SdR34+Csl IKuMrqtr4E8EmXCUgzNwdzPfcXvJX69fxH4U5Hl2QbUVUTT7a+LmuXM/QKb9VW6nhSHsXsts4fSWI VOroxHYwn4eSGe5RTy5qWlnsEGZ8VOA3woOoYUzP0wfUmuZgD5yplEn76O4dZYPXsb9YQfScovD1m wvUt/B+GzluyTGJlcxvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r69Z5-004rjC-1d; Thu, 23 Nov 2023 13:16:19 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r69Ye-004rau-1l; Thu, 23 Nov 2023 13:15:53 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 1E7DAB82CB1; Thu, 23 Nov 2023 13:15:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5462CC433C7; Thu, 23 Nov 2023 13:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700745350; bh=Ql73lSrKwKhqup+abmtnnxEZYubEKUABQoHRGC8oFho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uzDThtuXu/PTCtexQ8HN9QaXYAK0BZpNI/5gjSpKvL8SxEECMfj34sfZDWvr6O1tb IMT3H4LdZs5gZT6FBvD2vwfzlrwvAj/o6Dcv9hlpndFV/UiFp2nz7ZyaA8T4VKd6n4 c2NkJRs7t0Cs+ai/173/MXHqduMLNNq8ly1jj/Jk= Date: Thu, 23 Nov 2023 13:04:10 +0000 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Phil Elwell , Dave Stevenson Subject: Re: [PATCH 7/9] staging: vc04_services: Drop vchiq_log_warning() in favour of dev_dbg Message-ID: <2023112309-shape-machinist-9271@gregkh> References: <20231107095156.365492-1-umang.jain@ideasonboard.com> <20231107095156.365492-8-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231107095156.365492-8-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_051552_735909_21DA19CC X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 07, 2023 at 04:51:54AM -0500, Umang Jain wrote: > Drop vchiq_log_warning() macro which wraps dev_dbg(). Introduce the usage > of dev_dbg() directly. > > Signed-off-by: Umang Jain > --- > .../interface/vchiq_arm/vchiq_arm.c | 35 ++++++++++--------- > .../interface/vchiq_arm/vchiq_core.c | 33 +++++++++-------- > .../interface/vchiq_arm/vchiq_core.h | 4 --- > 3 files changed, 37 insertions(+), 35 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 2cb2a6503058..bc0ee8b9d1c3 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -690,8 +690,8 @@ int vchiq_initialise(struct vchiq_instance **instance_out) > pr_err("%s: videocore not initialized\n", __func__); > return -ENOTCONN; > } else if (i > 0) { > - vchiq_log_warning(state->dev, VCHIQ_CORE, > - "%s: videocore initialized after %d retries\n", __func__, i); > + dev_dbg(state->dev, "%s: %s: %s: videocore initialized after %d retries\n", > + log_cat(VCHIQ_CORE), log_type(WARN), __func__, i); what is the log_type(WARN) stuff for? How does that work? You should just use the normal dev_dbg() call and don't try to add new prefixes to the message as that will just confuse the common parsing tools we have for these types of things. Also, as before, __func__ is redundant, and now you see it twice in the output :( thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel