From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1352C61DF7 for ; Thu, 23 Nov 2023 13:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2KazdoW2vyqhsWTxLuUU7QkgtC9ccWOUsoA3PAzgHps=; b=FlrhyCX5xhLxbQ jZoENbMK/RU3UQ6EvPNW6U2FaxQzNdsf8BbOdDh0UcwVnsIYIue9Cbkax9Jwr/6NjGTophf6cEHq5 nUVxj3PRdufvHcJBQ1V/rcWMRpC9+4Y0jHQBgArK1FVVs4u1x1nmpTw4GHcEg+WURFvT/sp4cVM6m OLqJhNcltKTC8bs6ntenFCV8UtyNmsMu1znEbNdYQmEiiquU6KqO41CvFK1R2eobcPBX8m0u39azA MJ+Yh0DYJ3F3s3p0YuVyu99hxthlGngOHkCQ6WKWLqGnpryvTdwxK0ebS+2EatL3RbKAj0B2C2fjZ 39k+COGdHNMpjHudkk9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r69xS-004v4W-2x; Thu, 23 Nov 2023 13:41:30 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r69xL-004v1S-3D; Thu, 23 Nov 2023 13:41:25 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3CF41DB7; Thu, 23 Nov 2023 14:40:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1700746848; bh=LVXsJmqRupqKxn+TPDKtP0WCk3ociJdrzCihBHeH9sg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CUO8l99JOoME7vGI5V9qrYVQQDpAUMckSVXqD2N1w+w1Nad/L34lsj+tzFX2qBKzs RXtwjyDQAghquCV4BR9LaV0dEkG6jDODYV/o/sJf1YD0F82bl4lbMB8pmLL6zoBdiO 8PYqQRg9ia2R7FMXRnj/iPSltWQ2BGrpuIZRZwis= Date: Thu, 23 Nov 2023 15:41:27 +0200 From: Laurent Pinchart To: Greg Kroah-Hartman Cc: Umang Jain , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Phil Elwell , Dave Stevenson Subject: Re: [PATCH 5/9] staging: vc04_services: Do not pass NULL to vchiq_log_error() Message-ID: <20231123134127.GB16377@pendragon.ideasonboard.com> References: <20231107095156.365492-1-umang.jain@ideasonboard.com> <20231107095156.365492-6-umang.jain@ideasonboard.com> <20231107122551.GA3051@pendragon.ideasonboard.com> <4a5f6ae3-2a1f-f708-d9e0-fad4f5b60a43@ideasonboard.com> <2023112341-daughter-richness-c87b@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2023112341-daughter-richness-c87b@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_054124_183211_4D7F407B X-CRM114-Status: GOOD ( 34.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 23, 2023 at 12:57:14PM +0000, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2023 at 06:01:58PM +0530, Umang Jain wrote: > > Hi Laurent, > > > > On 11/7/23 5:55 PM, Laurent Pinchart wrote: > > > Hi Umang, > > > > > > Thank you for the patch. > > > > > > On Tue, Nov 07, 2023 at 04:51:52AM -0500, Umang Jain wrote: > > > > vchiq_add_connected_callback() logs using vchiq_log_error() macro, > > > > but passes NULL instead of a struct device pointer. Fix it. > > > > > > > > vchiq_add_connected_callback() is not used anywhere in the vc04_services > > > > as of now. It will be used when we add new drivers(VC shared memory and > > > > bcm2835-isp), hence it kept as it is for now. > > > > > > > > Fixes: 1d8915cf8899 ("staging: vc04: Convert vchiq_log_error() to use dynamic debug") > > > > Signed-off-by: Umang Jain > > > > --- > > > > .../vc04_services/interface/vchiq_arm/vchiq_connected.c | 4 ++-- > > > > .../vc04_services/interface/vchiq_arm/vchiq_connected.h | 4 +++- > > > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > > > index b3928bd8c9c6..21f9fa1a1713 100644 > > > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > > > @@ -27,7 +27,7 @@ static void connected_init(void) > > > > * be made immediately, otherwise it will be deferred until > > > > * vchiq_call_connected_callbacks is called. > > > > */ > > > > -void vchiq_add_connected_callback(void (*callback)(void)) > > > > +void vchiq_add_connected_callback(struct vchiq_device *device, void (*callback)(void)) > > > You're changing the prototype of the function, but the patch doesn't > > > update any user. If the function is unused, it looks like you can drop > > > it instead. Looking at the rest of the vchiq_connected.c file, I think > > > you can actually drop the whole file. > > > > I mentioned in the commit message of this patch. There will be users in the > > near future. > > We write code for today, not any potential users in the future. If it's > not used now, let's delete it and then when we need it in the future, > you can add it back then. What was the near future on November the 7th is now the present :-) Umang has sent a new version of the ISP driver that uses this API. I think this kind of near future is fine, and we routinely do the same during review when large feature are split across multiple series (whether those series are merged together or independently is another question of course). -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel