From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA248C5AD4C for ; Thu, 23 Nov 2023 13:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P9F10rL47wSZXVhlyOV8wdtDzcmkdXIjJU3R/AAG8Ec=; b=PePHpVL445PSfo eX+/bKLTqtr+S0YDblBm/A4DzG96PvS46nRjnvwHGeDII0Qsw6yc6rwwouJR8xO0T18E+uLYCLE6j 1+N2BXe9ddEA5uJiF3uIomB1GTVcqZ3Ut6Tw1E09qAywKLq33VpyPX9BMyYweKhrY+c9gFttZ1MP2 Tu/1gNkrqwbQZkkPdIu08LpK+OL+YV8aok+bqM3rYz0CkeKTKArFqNgGuY+7cEDk7/ql3nAdiO7IV w54QThsbsrxYhPuUn+atIvQ7q9u5gdd6cK2aJsWsxto3Rgks0bo0F06bbQZ8QgApLkq7x7eRiCJqY TqDgleGOZMbfP1xAr4/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r69yV-004vJJ-27; Thu, 23 Nov 2023 13:42:35 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r69yT-004vIe-1u; Thu, 23 Nov 2023 13:42:34 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9ACF5DB7; Thu, 23 Nov 2023 14:42:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1700746920; bh=ipKTtdDTQQuc8CbZO5+BiK1yiMtst+GzoqvW0dIfOWk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NfZ7kKJbp5Wetza26Dc230y/OoTY9inYiaMZm8htbLkyMSxHaUNHXBzgg2V1ZSM59 +j1cImBybILAOrW/LzrsUm9bqNO8CxC7WZS2DRfBRrOaFWiHAReKq64qAqQPcSgFl2 hmtFW4Mq84VpZrYAcDoI2YuBP3r02WHC2UsMhBeQ= Date: Thu, 23 Nov 2023 15:42:39 +0200 From: Laurent Pinchart To: Greg Kroah-Hartman Cc: Umang Jain , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Phil Elwell , Dave Stevenson , "Ricardo B . Marliere" Subject: Re: [PATCH 1/9] staging: vc04_services: vchiq_core: Log through struct vchiq_instance Message-ID: <20231123134239.GC16377@pendragon.ideasonboard.com> References: <20231107095156.365492-1-umang.jain@ideasonboard.com> <20231107095156.365492-2-umang.jain@ideasonboard.com> <2023112324-boxing-amiss-6df8@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2023112324-boxing-amiss-6df8@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_054233_768451_035D7AC0 X-CRM114-Status: UNSURE ( 9.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 23, 2023 at 12:57:33PM +0000, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2023 at 04:51:48AM -0500, Umang Jain wrote: > > The handle_to_service() helper can return NULL, so `service` pointer > > can indeed be set to NULL. So, do not log through service pointer > > (which will cause NULL-deference), instead, use the vchiq_instance > > function argument to get access to the struct device. > > > > Fixes: f67af5940d6d("staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug") > > You need a space there :( I have this in my .bashrc: gpf() { git show --pretty=fixes -s ${1:-HEAD} | wl-copy } It's quite handy. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel