From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 256ADC624B4 for ; Thu, 23 Nov 2023 13:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GrE2sjHf07vLTrUDHC+2TsJYEzwLMVZIpTTtb6hCPfc=; b=LBdQq4Yz4nLDYq 3YHywvwtkrMrxRwrLBSU3Djrrh3Qfe+2z78eCLfd9ERR7TdZ2n9PFbZCWZq0SG45vGtvxDozacGxT xIWsWo6jSkvdcBJrboN25s9514UkkYffs1UHEIxHewfw/FTmFDkBNrz3JCJa9hzhibGk86qkm+ahs oEGphLPc4XAnpaTQSbhmZ64UGXFeCN42WLfP3zj1gJz4oPyKvfb5JU9zk+d51aMDlgQqH7DXl/TjK VG42noLqmbsgYvlI9bq3qbWefGgnX7F1gZT8kPxqokCOtA5P2bAU0vRVje7PHTv2ERriRim7Ft8jA ZCJDUuvn6usk/6z7Sumw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r69Z4-004rig-2M; Thu, 23 Nov 2023 13:16:18 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r69Ya-004rZf-1P; Thu, 23 Nov 2023 13:15:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 192FBCE2901; Thu, 23 Nov 2023 13:15:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 717B4C433C8; Thu, 23 Nov 2023 13:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700745345; bh=eJTy5aMrNtZAv8SIwMLQ3REahBl73WirIDU8LHCm6JU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jaQ/h+JmhhWZwfEqGyzsMAjEut3UCUY5hUGmVL1rymqCqtlZ7j9zZbNx3nW6xpKop OmB/90ht5t47jgkdJIzjyXCEAUIQMdJZ7HsTcS4uFriashxUq8oFUKr25pI1TjgGBx cp+cnDltoMPfhmHubZ8DOS2kEHkScX8KltABAYUg= Date: Thu, 23 Nov 2023 13:02:45 +0000 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Phil Elwell , Dave Stevenson Subject: Re: [PATCH 6/9] staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg Message-ID: <2023112322-wife-aspect-135b@gregkh> References: <20231107095156.365492-1-umang.jain@ideasonboard.com> <20231107095156.365492-7-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231107095156.365492-7-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_051548_709546_3A684FE0 X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 07, 2023 at 04:51:53AM -0500, Umang Jain wrote: > Drop vchiq_log_error() macro which wraps dev_dbg(). Introduce the usage > of dev_dbg() directly. > > Add a new enum vchiq_log_type and log_type() helper to faciliate the > type of logging in dev_dbg(). This will help to determine the type of > logging("error", "warning", "debug", "trace") to dynamic debug. > > Signed-off-by: Umang Jain > --- > .../interface/vchiq_arm/vchiq_arm.c | 54 ++++---- > .../interface/vchiq_arm/vchiq_connected.c | 6 +- > .../interface/vchiq_arm/vchiq_core.c | 126 ++++++++++-------- > .../interface/vchiq_arm/vchiq_core.h | 23 +++- > .../interface/vchiq_arm/vchiq_dev.c | 47 ++++--- > 5 files changed, 143 insertions(+), 113 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 9fb3e240d9de..2cb2a6503058 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -696,8 +696,8 @@ int vchiq_initialise(struct vchiq_instance **instance_out) > > instance = kzalloc(sizeof(*instance), GFP_KERNEL); > if (!instance) { > - vchiq_log_error(state->dev, VCHIQ_CORE, > - "%s: error allocating vchiq instance\n", __func__); > + dev_dbg(state->dev, "%s: %s: %s: error allocating vchiq instance\n", > + log_cat(VCHIQ_CORE), log_type(ERROR), __func__); All dev_dbg() calls have __func__ in them automatically, you never need to duplicate it again as that's redundant :( thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel