From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89D6DC61DF7 for ; Thu, 23 Nov 2023 13:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=695H5+xFY7JJSGZT0PghTXcJnfFDXVo4PBIyLlONNXE=; b=kwp+Y3fsMCNUMR If1OPpsCbiPUv7nl0jcoJz15hgJfngM9sBPu+5ljYDyCJRopJ7nN9UBhlcDH6XjiL8cfSOTGpZpP7 FvKwgqX2Cr3KkaHvhyA9zkM9UpCBFP4uT33QGtSpmk/Lztgo25/DfltPaZQgAiky1JkG/sPN0cBCe gJu4X9pGzZYwXq+4zMJwq/oXf6LZ0+q11JuWqskjKyIjPS7Uip0pG0hgSuanDT9avB4yhSpQvlng1 0ysD5KylsoEaNv3Dy3BaB9dVnnIJayhyrsN8kh2otZlVXgKw5k1gWbHqieM1woRgfKQR9HTUGpS5D 8lHCPecrOBV69mlragog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r69YR-004rWm-1f; Thu, 23 Nov 2023 13:15:39 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r69YK-004rUY-23; Thu, 23 Nov 2023 13:15:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E78BB620E8; Thu, 23 Nov 2023 13:15:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBACFC433C8; Thu, 23 Nov 2023 13:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700745331; bh=WVFrUjgUeBcXNPWGgnrCb8KWifQK1zYq9aT4ZeaCau4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=siQPBVND2EtFti7EfUoVLqMkDENgDN9MLMjhEehaUN/ma9rdpbHECOkn0KybQIZJw w6Ytnpek3RFttyxbZK/eiAZw5qMxgA073Y1Rtt0TLockJT2tzj1DJZtiz5MQ6367o8 qFul222RW0+NxIAxPN8Datw00fBj0ioHVmcasJ0o= Date: Thu, 23 Nov 2023 12:57:33 +0000 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Phil Elwell , Dave Stevenson , "Ricardo B . Marliere" Subject: Re: [PATCH 1/9] staging: vc04_services: vchiq_core: Log through struct vchiq_instance Message-ID: <2023112324-boxing-amiss-6df8@gregkh> References: <20231107095156.365492-1-umang.jain@ideasonboard.com> <20231107095156.365492-2-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231107095156.365492-2-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_051532_717309_CD38B517 X-CRM114-Status: UNSURE ( 6.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 07, 2023 at 04:51:48AM -0500, Umang Jain wrote: > The handle_to_service() helper can return NULL, so `service` pointer > can indeed be set to NULL. So, do not log through service pointer > (which will cause NULL-deference), instead, use the vchiq_instance > function argument to get access to the struct device. > > Fixes: f67af5940d6d("staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug") You need a space there :( _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel