From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90F77C624B4 for ; Thu, 23 Nov 2023 17:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nwmoOpxoK7XweekhY+laJMNDkSQUvrQQRY7DkMgL5C8=; b=escPEmePL7yIPF I3R6NVQRSeVl2vLR7luf7yJLhHR8SlBcRuJPhI9Dv6w9eosE82vRngfXubzuZr842+jKtWBYzceg9 HPhUs6foc0ghH+Y3ZR/+Y586DwVO9ZOKALzeDmlA3ZnwA8cr/+OdQ/G40lFICEKy9RfLWCuE+GH4+ CbZmUS+R+MrlZENGgyY721tdJeyvR3Vzb5L2wkEjNu5fJTzLGR6tKCz75oQG3dC8iEYMxB8mSNHYH +Xc88fsBEh9fWqFiPEwLlJxzSIrhbB9UOk4RFncwmeAf+viClPp0NPk4EgjHhbhdcE2z5gOOS5e/m fVhMhwatqSfyvAwMtfIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6DPg-005PSG-1e; Thu, 23 Nov 2023 17:22:52 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6DPR-005PMw-0c; Thu, 23 Nov 2023 17:22:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7802F62272; Thu, 23 Nov 2023 17:22:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F23B4C433CA; Thu, 23 Nov 2023 17:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700760156; bh=0YrnFGZ6QHkvwo7JE//eP9vpdVSncHZkxX9I2Hi8upU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tq9eJ/6y+XOYym7djDhmD9M/GAQwCLx6ahz+n+BKxlSZAqCTPOJubI4mlstLXZVBJ Nm87g68jZH/poxfucgGXimM3goLVAx9wUWyuu2A3uTZua07uTpA7wW5T+Qd2BdqxyU 1XpEnExqBTWepe515OfkAReQuUCCkhZi46jX/dk0= Date: Thu, 23 Nov 2023 13:55:03 +0000 From: Greg Kroah-Hartman To: Laurent Pinchart Cc: Umang Jain , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Phil Elwell , Dave Stevenson Subject: Re: [PATCH 5/9] staging: vc04_services: Do not pass NULL to vchiq_log_error() Message-ID: <2023112331-cupid-neon-836a@gregkh> References: <20231107095156.365492-1-umang.jain@ideasonboard.com> <20231107095156.365492-6-umang.jain@ideasonboard.com> <20231107122551.GA3051@pendragon.ideasonboard.com> <4a5f6ae3-2a1f-f708-d9e0-fad4f5b60a43@ideasonboard.com> <2023112341-daughter-richness-c87b@gregkh> <20231123134127.GB16377@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231123134127.GB16377@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_092237_312632_DC1C515E X-CRM114-Status: GOOD ( 38.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 23, 2023 at 03:41:27PM +0200, Laurent Pinchart wrote: > On Thu, Nov 23, 2023 at 12:57:14PM +0000, Greg Kroah-Hartman wrote: > > On Tue, Nov 07, 2023 at 06:01:58PM +0530, Umang Jain wrote: > > > Hi Laurent, > > > > > > On 11/7/23 5:55 PM, Laurent Pinchart wrote: > > > > Hi Umang, > > > > > > > > Thank you for the patch. > > > > > > > > On Tue, Nov 07, 2023 at 04:51:52AM -0500, Umang Jain wrote: > > > > > vchiq_add_connected_callback() logs using vchiq_log_error() macro, > > > > > but passes NULL instead of a struct device pointer. Fix it. > > > > > > > > > > vchiq_add_connected_callback() is not used anywhere in the vc04_services > > > > > as of now. It will be used when we add new drivers(VC shared memory and > > > > > bcm2835-isp), hence it kept as it is for now. > > > > > > > > > > Fixes: 1d8915cf8899 ("staging: vc04: Convert vchiq_log_error() to use dynamic debug") > > > > > Signed-off-by: Umang Jain > > > > > --- > > > > > .../vc04_services/interface/vchiq_arm/vchiq_connected.c | 4 ++-- > > > > > .../vc04_services/interface/vchiq_arm/vchiq_connected.h | 4 +++- > > > > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > > > > index b3928bd8c9c6..21f9fa1a1713 100644 > > > > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > > > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > > > > @@ -27,7 +27,7 @@ static void connected_init(void) > > > > > * be made immediately, otherwise it will be deferred until > > > > > * vchiq_call_connected_callbacks is called. > > > > > */ > > > > > -void vchiq_add_connected_callback(void (*callback)(void)) > > > > > +void vchiq_add_connected_callback(struct vchiq_device *device, void (*callback)(void)) > > > > You're changing the prototype of the function, but the patch doesn't > > > > update any user. If the function is unused, it looks like you can drop > > > > it instead. Looking at the rest of the vchiq_connected.c file, I think > > > > you can actually drop the whole file. > > > > > > I mentioned in the commit message of this patch. There will be users in the > > > near future. > > > > We write code for today, not any potential users in the future. If it's > > not used now, let's delete it and then when we need it in the future, > > you can add it back then. > > What was the near future on November the 7th is now the present :-) > Umang has sent a new version of the ISP driver that uses this API. I > think this kind of near future is fine, and we routinely do the same > during review when large feature are split across multiple series > (whether those series are merged together or independently is another > question of course). That other series is long gone from my review queue after the first round of issues found with it, I had forgotten all about it :) greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel