From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E29DC5AD4C for ; Thu, 23 Nov 2023 13:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=31r6tIoeWyeR1xS3lnaTQR3myYSEitZT/5tovm3hiCE=; b=zbFRYUGlqFJ3Y6 wAR5qL6TjuI3d+d6D/FFjDhHqlXvZzdZVRh96CeQ8+4j57cNs1MEYm77mcBQws1qQJslLTaKoE0nv tIav9/hOzyAUZ9Ae99NwBq1MAqzwpxI6BjBnXNJqiBMqiK1gYRWt3WPHxv3GpRG1E6PaW6TARN26B qyn0s3bajPj+csA7xIjL1pu+1d8cqnwzampXyDq/eR7GMH+hLbHRyNDKRQUsHUNshQUAX9yf7mlJn p+B7FA4Lxs8dqmy/kL/BiDkOl0izURpubnM0htP+psEuCPNkute8UkhAg/khvYPnGeM9wMBcHJ0O8 F/EkCJCTJsNq2IPjB37Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r69Zg-004rtm-17; Thu, 23 Nov 2023 13:16:56 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r69Yn-004reV-22; Thu, 23 Nov 2023 13:16:02 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 50739B82CAE; Thu, 23 Nov 2023 13:16:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3785C433C8; Thu, 23 Nov 2023 13:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700745359; bh=zUbrdBm8Q2+P04oC+jzJgrh1Nr0G4L+l33QE59HItts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KFCrXextGh4GSnx37HAmDmG+R0W8UvxUd1JKSUBjjp3UvSBfPViS4evFVtCuGHOHm Qymn+moB4UzUOr/UD9mvWZgKwvEZnwxMthLHeKi7UJlY5tOirc2mqbaAgego12HM0R TZ262UJt1yakeKtFGvA0M5PkU8USgwSBDWoVc24Y= Date: Thu, 23 Nov 2023 13:14:10 +0000 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Dave Stevenson , Phil Elwell , "Ricardo B . Marliere" Subject: Re: [PATCH 0/2] staging: vc04_services: Use %p to log pointer Message-ID: <2023112334-projector-spoilage-fcbc@gregkh> References: <20231107165523.638555-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231107165523.638555-1-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_051601_812764_3B2B3ABD X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 07, 2023 at 11:55:21AM -0500, Umang Jain wrote: > %lx is used to print the unmodified pointer address for debugging. > %p will print the hashed pointer address to avoid leaking information > about kernel memory layout to userspace. But when `no_hash_pointers` > is passed as kernel parameter, unmodified pointer address will be > printed. > > Hence, drop %lx in favour of %p. For debugging purposes, one can > easily depend on `no_hash_pointers`. > > This also solves the following smatch warnings: > service_callback() warn: argument 7 to %lx specifier is cast from pointer > service_callback() warn: argument 11 to %lx specifier is cast from pointer > service_callback() warn: argument 12 to %lx specifier is cast from pointer > service_callback() warn: argument 13 to %lx specifier is cast from pointer > vchiq_release() warn: argument 7 to %lx specifier is cast from pointer Doesn't apply as I didn't take your other patch series. resend it when you have that one fixed up? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel