From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E13CC5AD4C for ; Thu, 23 Nov 2023 13:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jcqYiu073UlMCWiFGWL5VCiIxHozIiJ6jm5InryCzzo=; b=SJuU6yrhBOh825 o4AUW35whjRmImMuKIxQfLjUTc+yTRWL5iuRusk0Ji0aYTQ6PVEf1dXGf8brr+6yI3/D6pVm6nLM1 v1VqgCfltw6pX/sBmAyNiqR6GOtdshcD9XHPaBdNK0TuGj2aOo+PZ+kwa5r/qg87Mt6NrVEai++Fq RZVSrg5v9I7CszyossjQNTT/SpRMb4l1UxctPt/zZqA+8OYjvy/k7pDYWyqe3lid5GIC99SdPXu9i cJDpKb20LxGj5o7xdQsXnCfU+oC35nxpeFZ8uJGQOIwr3d5VK1uvPKilM4vPRV0KMFVaVZsrtCPB2 0AyxBO5jeOWj0EwvLJyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r69Z4-004riP-0h; Thu, 23 Nov 2023 13:16:18 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r69YR-004rWB-03; Thu, 23 Nov 2023 13:15:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id F1D58CE28C0; Thu, 23 Nov 2023 13:15:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B97FC433C8; Thu, 23 Nov 2023 13:15:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700745336; bh=ZPtKgbpZzFUFQPD2alKCmhEerwJY/Y+95EB9EdHdGUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lWjwKCgV6MYqxd/uuVbuZoUffAd9OOTW2pU6whP/FBXGAfGvQA8IzMkGyfm9C/x9Q 6e/91aVepueICuvy7F7SPogdsi5oKpm/erx5+mtfHNyAi4LkmW57bgCzCEy20CyeIu hreQZ/vtKf3CpY9fncf8rSWX/0LsiiG0Dk4SzXDI= Date: Thu, 23 Nov 2023 12:58:03 +0000 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Phil Elwell , Dave Stevenson , "Ricardo B . Marliere" Subject: Re: [PATCH 1/9] staging: vc04_services: vchiq_core: Log through struct vchiq_instance Message-ID: <2023112346-briskness-impaired-f545@gregkh> References: <20231107095156.365492-1-umang.jain@ideasonboard.com> <20231107095156.365492-2-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231107095156.365492-2-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_051539_284341_CE0EF40A X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 07, 2023 at 04:51:48AM -0500, Umang Jain wrote: > The handle_to_service() helper can return NULL, so `service` pointer > can indeed be set to NULL. So, do not log through service pointer > (which will cause NULL-deference), instead, use the vchiq_instance > function argument to get access to the struct device. > > Fixes: f67af5940d6d("staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug") > Signed-off-by: Umang Jain > Reviewed-by: Ricardo B. Marliere > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Also, please send this as a stand-alone patch so we can apply it for 6.7-final. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel