From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6BBEC61DF4 for ; Fri, 24 Nov 2023 12:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3Xg6Nwt2nst6JCRZStaQq3jg5plaYRGI+7xOkzI1dUw=; b=2+TVQ24/gzRXW/+wz1azrsw7+I cy28KkxxTU9sch7wr4EN7EA5V4czJxLmYEo2Fs9QZ5qmFvT5FITWeM2/jJa6Sr2p+7oWxJ/QBPKXU hu2qroWZFJnkpDMOJRzITO76KFrMzv4+C21gqngWESeQkOj76SxQBPj3MccYBOHubqOKecOsMlb4S NeFY0+H3oXyJu4Wv8grSlcIKQJw5ToFczcQBAVrSO2giVwq/snpviNFTexA7YyA61O7Ila5lgAbsc pslPnKFdhaInIdoJZ64IPvjuj43Xnbz7+K4AbSjjSLV2PACOOuLHlE/v1awrZydrb/AB8DoGHlY5k CeZW8NgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6VcL-007Eby-2n; Fri, 24 Nov 2023 12:49:09 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6VcJ-007Ebc-1N for linux-arm-kernel@lists.infradead.org; Fri, 24 Nov 2023 12:49:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 10B49B82FF6; Fri, 24 Nov 2023 12:49:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97706C433C8; Fri, 24 Nov 2023 12:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700830145; bh=0/fjlCNQfvRSIG2DQIR0FRU4Xx3x1rDhMmjCSc2dHTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LpqsmpXjNkQvLIxL/ylXUZ91zdM7G+iqppgN2q7cz2T4+sGCGpPVZdZYRXvKojtif JM1HZFTmyyVMXmO/BbzyQ1IraS78klmcvBQdJCm1GsPKnnbzwQ+818lecrSVzitWTN 2uhykAVa1811461fU36jc0eW6sVL+OaFoRntPPbx75HzI5hNu740qxbX+QZUh3lY1J VPs1Xa0LdBXirImjN7pSx+f9R0UyAq/8sI8izlhzDjvfjHVL5qpzznGNeczlnflsk7 CQa9N7TiTQfB5l9jnLNPWdF0A2GJAarSigH0aXAUHITc9K1pmVrwOwcXyzQA8RvTJ4 wsrCRFJonRdIA== Date: Fri, 24 Nov 2023 12:48:59 +0000 From: Conor Dooley To: "Manne, Nava kishore" Cc: "mdf@kernel.org" , "hao.wu@intel.com" , "yilun.xu@intel.com" , "trix@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "Simek, Michal" , "mathieu.poirier@linaro.org" , "Levinsky, Ben" , "Potthuri, Sai Krishna" , "Shah, Tanmay" , "dhaval.r.shah@amd.com" , "arnd@arndb.de" , "Datta, Shubhrajyoti" , "linux-fpga@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC PATCH 1/3] dt-bindings: fpga: Add support for user-key encrypted bitstream loading Message-ID: <20231124-tweezers-slug-0349a2188802@spud> References: <20231122054404.3764288-1-nava.kishore.manne@amd.com> <20231122054404.3764288-2-nava.kishore.manne@amd.com> <20231122-exert-gleeful-e4476851c489@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_044907_739298_0C2C3CA5 X-CRM114-Status: GOOD ( 36.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6908717052487934740==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6908717052487934740== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i9ugnADt+2no1y19" Content-Disposition: inline --i9ugnADt+2no1y19 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 24, 2023 at 06:35:19AM +0000, Manne, Nava kishore wrote: > Hi Conor, >=20 > Thanks for providing the review comments. > Please find my response inline. >=20 > > -----Original Message----- > > From: Conor Dooley > > Sent: Wednesday, November 22, 2023 10:21 PM > > To: Manne, Nava kishore > > Cc: mdf@kernel.org; hao.wu@intel.com; yilun.xu@intel.com; > > trix@redhat.com; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > > conor+dt@kernel.org; Simek, Michal ; > > mathieu.poirier@linaro.org; Levinsky, Ben ; > > Potthuri, Sai Krishna ; Shah, Tanmay > > ; dhaval.r.shah@amd.com; arnd@arndb.de; > > Datta, Shubhrajyoti ; linux- > > fpga@vger.kernel.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > > Subject: Re: [RFC PATCH 1/3] dt-bindings: fpga: Add support for user-key > > encrypted bitstream loading > >=20 > > On Wed, Nov 22, 2023 at 11:14:02AM +0530, Nava kishore Manne wrote: > > > Adds =E2=80=98encrypted-key-name=E2=80=99 property to support user-ke= y encrypted > > > bitstream loading use case. > > > > > > Signed-off-by: Nava kishore Manne > > > --- > > > .../devicetree/bindings/fpga/fpga-region.txt | 32 > > > +++++++++++++++++++ > >=20 > > Is there a reason that this has not yet been converted to yaml? > >=20 > I am not sure about the complication involved here why it's not converted= to yaml format. > Due to time constraints, I couldn=E2=80=99t spend much time so I have use= d this existing legacy format > to add my changes. >=20 > > > 1 file changed, 32 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > b/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > index 528df8a0e6d8..309334558b3f 100644 > > > --- a/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > +++ b/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > @@ -177,6 +177,9 @@ Optional properties: > > > it indicates that the FPGA has already been programmed with this > > image. > > > If this property is in an overlay targeting an FPGA region, it is a > > > request to program the FPGA with that image. > > > +- encrypted-key-name : should contain the name of an encrypted key f= ile > > located > > > + on the firmware search path. It will be used to decrypt the FPGA > > image > > > + file with user-key. > >=20 > > I might be misreading things, but your driver code seems to assume that= this > > is an aes key. Nothing here seems to document that this is supposed to = be a > > key of a particular type. > >=20 >=20 > Yes, these changes are intended to add the support for Aes user-key encry= pted bitstream loading use case. > Will fix it in v2, something like below. > aes-key-file-name : Should contain the AES key file name on the firmware = search path. > The key file contains the AES key and it will be used to decrypt = the FPGA image. Then when someone comes along looking for a different type of encryption we will end up with national-pride-foo-file-name etc. I think I'd rather have a second property that notes what type of cipher is being used and if that property is not present default to AES. --i9ugnADt+2no1y19 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWCbuwAKCRB4tDGHoIJi 0vV7AQCqNqM2cmGU/BCfxWj5TJvLx3rZlbmMCQx94IZ0wEBgcgD/SwPOUEDaTgm7 9HEV331ZuK9GycuqRUL7gyLlrRb7Fgw= =n0AP -----END PGP SIGNATURE----- --i9ugnADt+2no1y19-- --===============6908717052487934740== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6908717052487934740==--