From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B362C61DF4 for ; Fri, 24 Nov 2023 19:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ft09CejOq1LZmMgDpA+o61iNt8nqpZ3Q0qpW7Gek68I=; b=IE5vrvJHZNrr59 Ov0bxhSlCNaqj4QISWHAx0iqKq96pJSJBzxDE5tEouDfaSvfC+xpJzSHVnPp2WwSntjIv+45SYKAB w5NLK1SsWsUPIQn76zxhCArhYO9fyZpUvCSZUiZeKUasAaZZI51Dt+6ii8LXpz+I3CchrnocpyklY vd5PZXHhSA+1Do7rPguAC9yKv0zqI768kKClQ7Uww3IiEalsviXj6VNn6nZrKsjjsYtnBDQ/y9dsE mIo8jm6Wc9yeMpegltxM/aHdw7QhAN9BXqHEAP+6llmDv0DZCsxolFPL518dN8XY9ze2gSlm5iwey 7vq13AZ4NDOg9R5yOqsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6c2O-007xh2-1C; Fri, 24 Nov 2023 19:40:28 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6c2L-007xfY-0V; Fri, 24 Nov 2023 19:40:26 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-54a945861c6so3210963a12.3; Fri, 24 Nov 2023 11:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700854820; x=1701459620; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DKrRg2snxExqJdFGigUYh7T7Fc6aEzueP8JRF0HCrTo=; b=Fq48iP4c8eNk/hi1hqQl2UxiRVe29jjaaDLkiUWxixxYWc2Td9zlNxxszYk0M1XULu h2oATkTjNjBXx+is3jB27Uev4A6ltMmZTecuwniwbTOrgaV6Gs3BxIgwMhhYwIhxAqrS jGPJhbkkZEawyqHjiKeqfDqTMfMyiIghdp3XktDx2uRGI/BJZI4209uB8xBJ73cQWmCh sJBxi7hCINvMoBiLbyDDYS/WdxzkFqpyA6u3IxphSWUCV4WmO0IPYFxFgypPGNvaEI9T CiIcnW6XRMogXrtICl3fXVIyIquQ3W8+yUaZkRwZIr221F0vYX9NERTdg96rEwVhn4qA 2ghA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700854820; x=1701459620; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DKrRg2snxExqJdFGigUYh7T7Fc6aEzueP8JRF0HCrTo=; b=Tix9Ds1Puh/XRY/b3WDixxqU/Z7bmKzO1RU/xLc2wuuZMOxdOyIUD1DmxLqagfSCU6 TZB86vgEvBMSokdB/WBrAD79sltoTFE9QR5wbqZamNoX7BCGT2GFS5FDXkZ7pwBGl5il UxRLMP5G6Iw0wFq314pKOeZw3bSPYJ2ibvYCb9nNRn8VyOTJzgpWpT9WGHaFbmLpoYJb mmu/Id87NWdLDTIjqXqgdGqaGUeJvYZ5kVK7fZ+gwQVm0Funojqo180vucXj867R55FF 1zAOcWGIk2RvCf2E8SupBN3k0dpWgKhNj+rGXJwA9D2p9KCizRV2kJ3EZsKnuBhlb+UL GpaA== X-Gm-Message-State: AOJu0YzX7cxqJ7r4Tf8NXoCINf+11QXryoBY2bsKjR3+rfe3+EK6bqQD KyDFXuMT7qoPX3VZrE3xkN0= X-Google-Smtp-Source: AGHT+IGItN29AlffdfAFP+pdBb+pUmXR0qRXvVcejscZr6unZPC/VQI53oWhDMvt4V3MPYz/KIrdxQ== X-Received: by 2002:a17:906:f1d4:b0:9fb:f99c:3ea with SMTP id gx20-20020a170906f1d400b009fbf99c03eamr2802823ejb.52.1700854819659; Fri, 24 Nov 2023 11:40:19 -0800 (PST) Received: from skbuf ([188.26.185.12]) by smtp.gmail.com with ESMTPSA id h25-20020a170906111900b00a0435148ed7sm2464856eja.17.2023.11.24.11.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 11:40:19 -0800 (PST) Date: Fri, 24 Nov 2023 21:40:16 +0200 From: Vladimir Oltean To: Andrew Lunn Cc: Christian Marangi , Rob Herring , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heiner Kallweit , Russell King , Florian Fainelli , Broadcom internal kernel review list , Daniel Golle , Qingfang Deng , SkyLake Huang , Matthias Brugger , AngeloGioacchino Del Regno , David Epping , "Russell King (Oracle)" , Harini Katakam , Simon Horman , Robert Marko , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [net-next RFC PATCH 03/14] dt-bindings: net: document ethernet PHY package nodes Message-ID: <20231124194016.tcmu4w2r7jrnv6mo@skbuf> References: <20231120135041.15259-1-ansuelsmth@gmail.com> <20231120135041.15259-4-ansuelsmth@gmail.com> <20231121144244.GA1682395-robh@kernel.org> <655e4939.5d0a0220.d9a9e.0491@mx.google.com> <20231124165923.p2iozsrnwlogjzua@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_114025_197795_CC8AD08C X-CRM114-Status: GOOD ( 29.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 24, 2023 at 07:35:35PM +0100, Andrew Lunn wrote: > > I think you are hitting some of the same points I have hit with DSA. > > The PHY package could be considered an SoC with lots of peripherals on > > it, for which you'd want separate drivers. > > At least at the moment, this is not true. The package does just > contain PHYs. But it also has some properties which are shared across > those PHYs, e.g. reset. > > What you describe might become true in the future. e.g. The LED/GPIO > controller is currently part of the PHY, and each PHY has its own. I > could however imagine that becomes a block of its own, outside of the > PHY address space, and maybe it might want its own class LED > driver. Some PHYs have temperature sensors, which could be a package > sensor, so could in theory be an individual hwmon driver. However, > i've not yet seen such a package. > > Do we consider this now? At the moment i don't see an MFD style system > is required. We could crystal ball gaze and come up with some > requirements, but i would prefer to have some real devices and > datasheets. Without them, we will get the requirements wrong. > > I also think we are not that far away from it, in terms of DT, if you > consider the later comments. I suggested we need a phy package > specific compatible. At the moment, it will be ignored by the kernel, > the kernel does not need it, it probes the PHYs in the current way, > using the ID registers. But it could in future be used to probe a real > driver, which could be an MFD style driver. We need to see updated DT > binding examples, but i don't see why we cannot slot it in at a later > date. I'm not suggesting to go for MFD right away. Just with a structure that is extensible to possibly cover that. For now, a package node with a Qualcomm compatible, with the most minimal driver that forwards MDIO access to PHY children. I can't speak for the future of PHY drivers, since I don't know enough about PHYs. I'm just coming from the DSA background where I really wish we had this sort of infrastructure earlier. Now I have the SJA1110 which still lacks support for the interrupt controller for its integrated PHYs, and a bunch of other IP blocks in the package, because it's so incredibly hard to make the driver support the old-style and the new-style device trees. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel