From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C9F2C61D97 for ; Fri, 24 Nov 2023 11:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u0mohYGGUA22fCslNXQo8dDRqJWzU2thKEv5vWr9/qQ=; b=qdn5XeMqpsFJ9o JU7xUQnupj3C982c/G+WGvRyHkCUSYcnXoCrK35yLesBu6toy0ZDEEk36g809GJk9JmozwUig4ZQW JMY7BvAg5JVLTasVUyErUz3Yw65YMw9uGF2vBR36MSOLevu4V/W767spcrLXWcyyItGOHpszw7TDd wnPX4tj+lq0R2qlvXNZMrecPqzIC1OSLmabdK21gvD/v4mIAMDM57v4X/Wf49UWg9JcTaFYTqAuoJ VNIlDWwNMF3glVxANq0XCk3++sOO4zA1r5ZxEY0kqQxhHg12ESfD0QFFYfeMg1N+H32wtk/rjfUgH 1r9K2aN9SHIIm4yOB3hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6UgG-0071cz-1r; Fri, 24 Nov 2023 11:49:08 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6UgD-0071a9-2i for linux-arm-kernel@lists.infradead.org; Fri, 24 Nov 2023 11:49:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 317A2CE28FE; Fri, 24 Nov 2023 11:49:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA53FC433C7; Fri, 24 Nov 2023 11:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700826535; bh=rONuqkzfv7OVMDICs020cWoikJlqQwNfR2bb2s/gAyY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QunT1pFAdaStG+bNcYI2Y9HFDdH8/p1toE1YBO4CQoK7s8CLGhXWWKhwhjyEfXDh6 3AqD2VEK9ZZxLjMSCyJWoLa7w1l3ODJFxztSEPcIVCiYFiHEnc3/gL0EOV6841VxJ4 13S5eQmEIBuGtgExhY75KmuiCXmp6yevzfu61xDw= Date: Fri, 24 Nov 2023 11:48:53 +0000 From: Greg Kroah-Hartman To: Tony Lindgren Cc: linux-omap@vger.kernel.org, Dhruva Gole , Keerthy , Kevin Hilman , Nishanth Menon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] bus: ti-sysc: Flush posted write only after srst_udelay Message-ID: <2023112440-handiness-surely-6675@gregkh> References: <20231124104133.19100-1-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231124104133.19100-1-tony@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_034906_065233_B93BE027 X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 24, 2023 at 12:41:33PM +0200, Tony Lindgren wrote: > Commit 34539b442b3b ("bus: ti-sysc: Flush posted write on enable before > reset") caused a regression reproducable on omap4 duovero where the ISS > target module can produce interconnect errors on boot. Turns out the > registers are not accessible until after a delay for devices needing > a ti,sysc-delay-us value. > > Let's fix this by flushing the posted write only after the reset delay. > We do flushing also for ti,sysc-delay-us using devices as that should > trigger an interconnect error if the delay is not properly configured. > > Let's also add some comments while at it. > > Fixes: 34539b442b3b ("bus: ti-sysc: Flush posted write on enable before reset") > Signed-off-by: Tony Lindgren > --- > drivers/bus/ti-sysc.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel