From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 307BBC61D9D for ; Sat, 25 Nov 2023 05:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6lAWNut9ihP4aBypZHtM//zaKd6auRmKi5T5Nl6ixBQ=; b=NEewN0GshB0Vqh FtVaaVHIPs8FYDPNt34XpSPRkMH0AieFijgVWDzo2i0XhK0mdHDokUdt4sQ3wEDyzjQ9y/0cq1iv0 uaGLAS1srrpCRSX+xjR1gGp2iLqyUnWDPgjEN4hT9TagnQI8Mv9OIVB2G4c1t9bYT8qnIYDjviNWi jO1HiF/X/ETmcXuoYXVd9nKhYmEXTNVNocmsrVtCynU5k9jjve8VflSujLF270zu6x61HT/Gcj1vZ 2o5waMl8QIRRmA6Mcp2yym6dSPIBIk6qGHPcV9gI9NnWeuoXjZQrJWY8H/j9ebp8Z1PIM2UUEHpLf 3+CH3WxFMhLevGylpwaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6lDS-008bvL-3B; Sat, 25 Nov 2023 05:28:30 +0000 Received: from mail-yw1-x1132.google.com ([2607:f8b0:4864:20::1132]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6lDP-008bun-2r for linux-arm-kernel@lists.infradead.org; Sat, 25 Nov 2023 05:28:29 +0000 Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-5ca11922cedso24892047b3.2 for ; Fri, 24 Nov 2023 21:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700890106; x=1701494906; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=00zNmrmz8VCMGnwTQFhbmVp+ehsjjW8N/XcmWDXSbx8=; b=ljkpNuhpvtaD4iviCi7NRF5iIAmZaVnypFxfrhleD4W+bklFU2tkYwR16ZakyDtWke tXi7jrAZCrZzorASieufCN6iZis9XufXVD5Y/+j98xgnGXaWCdsKA1O6afcfQq58Pj46 w9W+3bNh1EhPZTuvqcPYuOz8Uk2fqeFgaR82xlATHUG00B69ZTSMCBHBOEfQ+DZusBe+ KZe4Amttx7h0qhYwbwq3SkG+MlxmUh1tzxcZAqNm9S7SK8TjpMvGEyG7U3EWs0hwCd2L tGl+w/6YqIK4JZL6+9HPFuYxUxdBkTz98FJ52J3BVpOu96G6yBZ8NnWq9kH2bJjcFpsT KDLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700890106; x=1701494906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=00zNmrmz8VCMGnwTQFhbmVp+ehsjjW8N/XcmWDXSbx8=; b=QdMwvv9+8nL9e9d3rnvd/i/vGj+ytRA2oPQ8ihMLUjcqAKpJoy9bSZXZKMAjpt1Hav dFZevOtmsq4qRlkTsJIiB2FdeW9C8ejV0JKOIYXYmWxd1B5cW4oM4x2zalxBOU6lCuo7 +VPZGaSVdH3ggRXmaR7gAdbTqu7gUG01v15Ze/jykY6roDP8Ml1l/gQQVwb/tNi9RL21 WcGvOMfNjBcd1gjYxgwHB2EL9EfsmWxitdchw1RLAVde6rrxvy+jD354YA3cYiNrrW9u hrAuxFm16F2ZH4rHiP8Gq/p6+RjssI2F/eBuKe+EcbUPIqEb1G4Y0FbQ9ffSY4kkvVaz 2ayg== X-Gm-Message-State: AOJu0Yzmh/TSKS6IJu9IAIs4w9Cn7uyS7iS7WX0ABsXrIwBYXZhQRvQI UP05EMwqGHSypjjogk7j/Zs= X-Google-Smtp-Source: AGHT+IEBqW2rZ9W4gTax6+1ZGLMqaSNMwq7hQ9LOiEHY5GwRTDONyL78C07sKevDT9PmhnHjh/SXVw== X-Received: by 2002:a0d:f2c7:0:b0:5cd:3d82:1ac6 with SMTP id b190-20020a0df2c7000000b005cd3d821ac6mr4837287ywf.42.1700890105921; Fri, 24 Nov 2023 21:28:25 -0800 (PST) Received: from localhost ([74.48.130.204]) by smtp.gmail.com with ESMTPSA id i7-20020a81d507000000b005cbc182523esm1441160ywj.49.2023.11.24.21.28.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 21:28:25 -0800 (PST) Date: Sat, 25 Nov 2023 13:28:14 +0800 From: Furong Xu <0x1207@gmail.com> To: Serge Semin Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Simon Horman , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net v2 1/1] net: stmmac: xgmac: Disable FPE MMC interrupts Message-ID: <20231125132814.00001482@gmail.com> In-Reply-To: References: <20231124015433.2223696-1-0x1207@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-w64-mingw32) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_212827_969641_E5E35070 X-CRM114-Status: GOOD ( 22.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 24 Nov 2023 20:03:43 +0300 Serge Semin wrote: > On Fri, Nov 24, 2023 at 09:54:33AM +0800, Furong Xu wrote: > > Commit aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts > > by default") tries to disable MMC interrupts to avoid a storm of > > unhandled interrupts, but leaves the FPE(Frame Preemption) MMC > > interrupts enabled. > > Now we mask FPE TX and RX interrupts to disable all MMC interrupts. > > > > Fixes: aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts by default") > > Signed-off-by: Furong Xu <0x1207@gmail.com> > > --- > > Changes in v2: > > - Update commit message, thanks Wojciech and Andrew. > > --- > > drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c > > index ea4910ae0921..cdd7fbde2bfa 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c > > @@ -177,8 +177,10 @@ > > #define MMC_XGMAC_RX_DISCARD_OCT_GB 0x1b4 > > #define MMC_XGMAC_RX_ALIGN_ERR_PKT 0x1bc > > > > > +#define MMC_XGMAC_FPE_TX_INTR_MASK 0x204 > > #define MMC_XGMAC_TX_FPE_FRAG 0x208 > > #define MMC_XGMAC_TX_HOLD_REQ 0x20c > > +#define MMC_XGMAC_FPE_RX_INTR_MASK 0x224 > > Could you please preserve the local implicit naming convention of > having the Tx_ and RX_ prefixes being placed before the rest of > CSR-specific name part: > #define MMC_XGMAC_TX_FPE_INTR_MASK > instead of > #define MMC_XGMAC_FPE_TX_INTR_MASK > and > #define MMC_XGMAC_RX_FPE_INTR_MASK > instead of > #define MMC_XGMAC_FPE_RX_INTR_MASK > > Your macros will then look similar to MMC_XGMAC_TX_*, MMC_XGMAC_RX_* > and finally MMC_XGMAC_RX_IPC_INTR_MASK macros. > > -Serge(y) > Hi Serge, Thanks for your advice, I copied these register names from Synopsys Databook, and forgot to preserve the local implicit naming convention, I will send a new patch. > > #define MMC_XGMAC_RX_PKT_ASSEMBLY_ERR 0x228 > > #define MMC_XGMAC_RX_PKT_SMD_ERR 0x22c > > #define MMC_XGMAC_RX_PKT_ASSEMBLY_OK 0x230 > > @@ -352,6 +354,8 @@ static void dwxgmac_mmc_intr_all_mask(void __iomem *mmcaddr) > > { > > writel(0x0, mmcaddr + MMC_RX_INTR_MASK); > > writel(0x0, mmcaddr + MMC_TX_INTR_MASK); > > + writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_FPE_TX_INTR_MASK); > > + writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_FPE_RX_INTR_MASK); > > writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_RX_IPC_INTR_MASK); > > } > > > > -- > > 2.34.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel